Bug 1380698 - Use lvm backup options only for commands that needs this option
Summary: Use lvm backup options only for commands that needs this option
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: vdsm
Classification: oVirt
Component: Core
Version: 4.18.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Nir Soffer
QA Contact: Elad
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-30 11:14 UTC by Nir Soffer
Modified: 2022-06-27 07:45 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-09-03 08:25:09 UTC
oVirt Team: Storage
Embargoed:
sbonazzo: ovirt-4.3-


Attachments (Terms of Use)
Output of grep ' backup ' on vdsm log in debug mode (9.73 KB, text/plain)
2016-09-30 11:14 UTC, Nir Soffer
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHV-46560 0 None None None 2022-06-27 07:45:45 UTC

Description Nir Soffer 2016-09-30 11:14:30 UTC
Created attachment 1206224 [details]
Output of grep ' backup ' on vdsm log in debug mode

Description of problem:

Vdsm uses --config 'backup { ... }' options for read only lvm commands that do not
need this option. This works since the commands ignore this option, but add noise
to vdsm log and make it harder to debug.

Example commands with unneeded backup options:

- vgs
- vgck

See backup.log.

There may be more commands with this issue.

Version-Release number of selected component (if applicable):
All

How reproducible:
Always

Steps to Reproduce:
1. Look in vdsm logs in DEBUG mode for lvm commands run by vdsm.

Actual results:
backup option used in read only commands

Expected results:
backup option used only in commands that may create a backup

Comment 1 Nir Soffer 2016-09-30 11:17:24 UTC
Zdenek, do we have a list of commands that needs this option, or we should just use
this on commands that mention the backup options in the manual?

$ man lvchange | grep backup
       tionPolicy] [-A|--autobackup {y|n}] [--cachepolicy policy] [--cachesettings key=value] [--commandprofile ProfileName] [-C|--contiguous {y|n}] [-d|--debug] [--degraded] [--deltag

Comment 2 Zdenek Kabelac 2016-09-30 11:37:16 UTC
There are more question to ask first:

1. Would there there be a plan to use this without locking_type=4 ?


2. There would be no point to configure backups on 'hosts' when executed command should be purely read-only  (locking_type=4).

Comment 3 Nir Soffer 2017-03-06 22:23:45 UTC
Removing old need infos.

Comment 4 Tal Nisan 2018-09-03 08:25:09 UTC
Closing old bugs, reopen if still needed.


Note You need to log in before you can comment on or make changes to this bug.