Bug 1380848 - atomic containers delete is parameter order dependent
Summary: atomic containers delete is parameter order dependent
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: atomic
Version: 7.3
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: rc
: ---
Assignee: Lokesh Mandvekar
QA Contact: atomic-bugs@redhat.com
URL:
Whiteboard:
Depends On: 1389707
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-30 18:53 UTC by Chris Evich
Modified: 2016-12-06 17:42 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-12-06 17:42:08 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:2857 0 normal SHIPPED_LIVE atomic bug fix and enhancement update 2016-12-06 22:40:27 UTC

Description Chris Evich 2016-09-30 18:53:37 UTC
Description of problem:
atomic containers delete is parameter order dependent

Version-Release number of selected component (if applicable):
docker-1.10.3-55.el7.x86_64
atomic-1.12.3-2.el7.x86_64

How reproducible:
trivial

Steps to Reproduce:
1. docker run -d --name rhel rhel sleep 1h
2. atomic containers delete 1288ad0e7049 --force

Actual results:
Failed operation for delete container 1288ad0e7049: 409 Client Error: Conflict ("Conflict, You cannot remove a running container. Stop the container before attempting removal or use -f")
Failed to delete container --force: 404 Client Error: Not Found ("No such container: --force")
(exit code 2)

Expected results:
Container 1288ad0e7049 is forcibly deleted

Additional info:
An easy fix could be to update the --help (usage) information to reflect that parameter order is important.  The more "friendly" fix is to assume all parameters beginning with '--' are options, unless they're preceded by a (throw away) '--' parameter.

Comment 2 Alex Jia 2016-10-10 08:54:35 UTC
 (In reply to Chris Evich from comment #0)

> Additional info:
> An easy fix could be to update the --help (usage) information to reflect
> that parameter order is important.  The more "friendly" fix is to assume all
> parameters beginning with '--' are options, unless they're preceded by a
> (throw away) '--' parameter.

Yes, it should be enough to update document I think, because docker has the same issue if we don't consider parameter order.

[root@atomic-host-001 cloud-user]# docker rm e5881ac96cc6 --force
Failed to remove container (e5881ac96cc6): Error response from daemon: Conflict, You cannot remove a running container. Stop the container before attempting removal or use -f
Failed to remove container (--force): Error response from daemon: No such container: --force

Comment 3 Daniel Walsh 2016-10-10 15:51:14 UTC
https://github.com/projectatomic/atomic/pull/690 Should clean this up

Comment 4 Daniel Walsh 2016-10-12 19:04:22 UTC
Fixed in atomic-1.13

Comment 6 Chris Evich 2016-10-28 13:54:36 UTC
> Yes, it should be enough to update document I think,

I agree, documentation/--help fix is totally cool

Comment 7 Alex Jia 2016-11-01 09:34:07 UTC
[root@atomic-00 cloud-user]# cat /etc/redhat-release 
Red Hat Enterprise Linux Atomic Host release 7.3

[root@atomic-00 cloud-user]# rpm -q atomic
atomic-1.13.5-1.el7.x86_64

[root@atomic-00 cloud-user]# atomic containers delete -h
usage: atomic containers delete [-h] [-f] [-a | container]

positional arguments:
  container    Specify one or more containers. Must be final arguments.

optional arguments:
  -h, --help   show this help message and exit
  -f, --force  Force removal of specified running containers
  -a, --all    Delete all containers

Comment 9 errata-xmlrpc 2016-12-06 17:42:08 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2857.html


Note You need to log in before you can comment on or make changes to this bug.