Hide Forgot
Description of problem: Username in dev-preview-staging does not render correctly if username (from GitHub) contains non-Alphanumeric characters (i.e. ' ) Version-Release number of selected component (if applicable): Pre-release dev staging Openshift Online How reproducible: Change name at GitHub (not account name) to Firstname 'Nickname' Secondname Steps to Reproduce: 1. Change name at GitHub 2. Log onto Openshift Online dev staging Actual results: Name is rendered as Firstname 'Nickname' Secondname Expected results: Name should be rendered as Firstname 'Nickname' Secondname Additional info:
If I log into an origin server with a user that has ' characters in their name then it works fine. I suspect this is something specifically related to the github integration. Can you open the developer tools for your browser, log out and log back in and look for the request that looks like https://<server>/oapi/v1/users/~ particularly interested in the content of the metadata.name field
Can you also do this query against github and include the results: curl https://api.github.com/users/$username
If I edit my github user: $ curl https://api.github.com/users/liggitt { "login": "liggitt", ... "name": "Jordan 'T' Liggitt", } and log in, I get this as expected: $ oc get user/~ apiVersion: v1 items: - apiVersion: v1 fullName: Jordan 'T' Liggitt ... and the web console shows my name with single quotes, as expected
The github user comes back correctly: { "login": "utherp0", ... "name": "Ian 'Uther' Lawson", } However, when I login I get: Ians-MacBook-Pro:hub uther$ oc get user/~ NAME UID FULL NAME IDENTITIES utherp0 cc341dae-86f6-11e6-97f9-0eaa067b1713 Ian 'Uther' Lawson github:2233236 Web console shows html encoded characters still....
If its coming back that way from user/~ then this is not a web console bug.
https://github.com/openshift/online/pull/525
Fixed in oso-reconciler-docker-v3.3.0.0-4
I try to change my name on Github, it seems that it does not make sense. The name showed on web console and get by 'oc get users/~' is still old one. And I registered a new Github account with has symbols in its name. After login Openshift, the same problem still exists. $ curl https://api.github.com/users/lizhe103 { .... "name": "li 'zhe';; li?/&", ... } on STG env: $ oc get users/~ NAME UID FULL NAME IDENTITIES lizhe103 **** li 'zhe';; li?/& ***** on INT env: $ oc get users/~ NAME UID FULL NAME IDENTITIES lizhe103 **** li 'zhe';; li?/& ***** Showed on web console: li 'zhe';; li?/&
@Dan, Thanks for your explanation! we will verify this bug once the image v3.3.0.0-4 is deployed to online.