Bug 1381741 - Review Request: ginga - Image Viewer and Toolkit
Summary: Review Request: ginga - Image Viewer and Toolkit
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Björn 'besser82' Esser
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Astronomy-SIG
TreeView+ depends on / blocked
 
Reported: 2016-10-04 21:17 UTC by Christian Dersch
Modified: 2016-11-03 23:54 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-31 07:35:54 UTC
Type: ---
Embargoed:
besser82: fedora-review+


Attachments (Terms of Use)
output of licensecheck (29.52 KB, text/plain)
2016-10-07 20:07 UTC, Björn 'besser82' Esser
no flags Details

Description Christian Dersch 2016-10-04 21:17:46 UTC
Spec URL: https://lupinix.fedorapeople.org/review/ginga.spec
SRPM URL: https://lupinix.fedorapeople.org/review/ginga-2.5.20160926130800-1.fc25.src.rpm

Description: Astronomical Image Viewer and Toolkit
Fedora Account System Username: lupinix

Koji scratch build (rawhide): http://koji.fedoraproject.org/koji/taskinfo?taskID=15941757

Thank you very much for review in advance!

Comment 1 Björn 'besser82' Esser 2016-10-07 19:24:58 UTC
taken…  =)

Comment 2 Björn 'besser82' Esser 2016-10-07 20:07:12 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated", "MIT/X11 (BSD like)",
     "PSF", "BSD (3 clause)", "*No copyright* Apache (v2.0)". 492 files
     have unknown license. Detailed output of licensecheck in
     /home/besser82/shared/fedora/review/1381741-ginga/licensecheck.txt

     ---> please fix License-tag and document license-breakdown in spec-file.

[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
     contains desktop file(s) with a MimeType: entry.
     Note: desktop file(s) with MimeType entry in ginga
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 3 files.
[!]: Package complies to the Packaging Guidelines

     ---> See Licensing…

[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files

     ---> Fonts should be unbundled and symlinked.

[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).

     ---> /usr/bin/env is required due to wrong shebang in examples.

[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python2-ginga , python3-ginga

     ---> Packages are useful as stand-alone.

[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: ginga-2.5.20160926130800-1.fc26.noarch.rpm
          python2-ginga-2.5.20160926130800-1.fc26.noarch.rpm
          python3-ginga-2.5.20160926130800-1.fc26.noarch.rpm
          ginga-2.5.20160926130800-1.fc26.src.rpm
ginga.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy
ginga.noarch: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
ginga.noarch: W: spelling-error %description -l en_US fwhm -> whom
ginga.noarch: W: no-manual-page-for-binary ginga
ginga.noarch: W: no-manual-page-for-binary ggrc
python2-ginga.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy
python2-ginga.noarch: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
python2-ginga.noarch: W: spelling-error %description -l en_US fwhm -> whom
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/gw/example2.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/gtk3/example2.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/gtk/fits2pdf.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/tk/example1_tk.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/gtk3/example1.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/web/pgw/ipg.py /usr/bin/env python
python2-ginga.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ginga/web/pgw/ipg.py 644 /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/qt/example2_qt.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/matplotlib/example2_mpl.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/matplotlib/example5_mpl.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/matplotlib/example1_mpl.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/gtk/example2_gtk.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/matplotlib/example4_mpl.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/pg/example2_pg.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/tk/example2_tk.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/gw/example1_video.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/matplotlib/example3_mpl.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/gtk/example1_gtk.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/util/mosaic.py /usr/bin/env python
python2-ginga.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ginga/util/mosaic.py 644 /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/gw/shared_canvas.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/qt/example1_qt.py /usr/bin/env python
python3-ginga.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy
python3-ginga.noarch: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
python3-ginga.noarch: W: spelling-error %description -l en_US fwhm -> whom
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/util/mosaic.py /usr/bin/env python
python3-ginga.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/ginga/util/mosaic.py 644 /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/gtk/example2_gtk.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/qt/example2_qt.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/tk/example1_tk.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/matplotlib/example3_mpl.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/matplotlib/example1_mpl.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/gtk3/example1.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/gtk/fits2pdf.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/pg/example2_pg.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/matplotlib/example5_mpl.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/gw/example2.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/gw/shared_canvas.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/qt/example1_qt.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/gtk/example1_gtk.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/matplotlib/example4_mpl.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/tk/example2_tk.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/gtk3/example2.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/gw/example1_video.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/matplotlib/example2_mpl.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/web/pgw/ipg.py /usr/bin/env python
python3-ginga.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/ginga/web/pgw/ipg.py 644 /usr/bin/env python
ginga.src: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy
ginga.src: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
ginga.src: W: spelling-error %description -l en_US fwhm -> whom
4 packages and 0 specfiles checked; 44 errors, 14 warnings.




Rpmlint (installed packages)
----------------------------
python2-ginga.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy
python2-ginga.noarch: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
python2-ginga.noarch: W: spelling-error %description -l en_US fwhm -> whom
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/gw/shared_canvas.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/gw/example1_video.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/tk/example2_tk.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/gtk3/example1.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/gw/example2.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/qt/example2_qt.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/matplotlib/example3_mpl.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/util/mosaic.py /usr/bin/env python
python2-ginga.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ginga/util/mosaic.py 644 /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/gtk3/example2.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/matplotlib/example2_mpl.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/gtk/fits2pdf.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/web/pgw/ipg.py /usr/bin/env python
python2-ginga.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ginga/web/pgw/ipg.py 644 /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/gtk/example1_gtk.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/pg/example2_pg.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/matplotlib/example5_mpl.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/matplotlib/example4_mpl.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/gtk/example2_gtk.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/tk/example1_tk.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/matplotlib/example1_mpl.py /usr/bin/env python
python2-ginga.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ginga/examples/qt/example1_qt.py /usr/bin/env python
python3-ginga.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy
python3-ginga.noarch: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
python3-ginga.noarch: W: spelling-error %description -l en_US fwhm -> whom
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/web/pgw/ipg.py /usr/bin/env python
python3-ginga.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/ginga/web/pgw/ipg.py 644 /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/gw/example2.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/matplotlib/example5_mpl.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/util/mosaic.py /usr/bin/env python
python3-ginga.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/ginga/util/mosaic.py 644 /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/gtk/example1_gtk.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/gtk3/example2.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/gw/shared_canvas.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/qt/example2_qt.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/gtk3/example1.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/qt/example1_qt.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/gw/example1_video.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/tk/example1_tk.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/matplotlib/example3_mpl.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/matplotlib/example2_mpl.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/matplotlib/example4_mpl.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/tk/example2_tk.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/pg/example2_pg.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/gtk/example2_gtk.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/matplotlib/example1_mpl.py /usr/bin/env python
python3-ginga.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/ginga/examples/gtk/fits2pdf.py /usr/bin/env python
ginga.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy
ginga.noarch: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
ginga.noarch: W: spelling-error %description -l en_US fwhm -> whom
ginga.noarch: W: no-manual-page-for-binary ggrc
ginga.noarch: W: no-manual-page-for-binary ginga
3 packages and 0 specfiles checked; 44 errors, 11 warnings.


---> Please move the scripts to %%doc and fix up the interpreter.


Requires
--------
python2-ginga (rpmlib, GLIBC filtered):
    /usr/bin/env
    python(abi)
    python2-astropy
    python2-matplotlib-qt5
    python2-qt5
    python2-scipy

python3-ginga (rpmlib, GLIBC filtered):
    /usr/bin/env
    python(abi)
    python3-astropy
    python3-matplotlib-qt5
    python3-qt5
    python3-scipy

ginga (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/python3
    python3-ginga



Provides
--------
python2-ginga:
    python-ginga
    python2-ginga
    python2.7dist(ginga)
    python2dist(ginga)

python3-ginga:
    python3-ginga
    python3.5dist(ginga)
    python3dist(ginga)

ginga:
    application()
    application(ginga.desktop)
    ginga
    mimehandler(image/x-fits)



Source checksums
----------------
https://files.pythonhosted.org/packages/source/g/ginga/ginga-2.5.20160926130800.tar.gz :
  CHECKSUM(SHA256) this package     : 78ebf612a12510382ac84c1a2156a59fa36a1138b591f42e0b7fd99f94392ee0
  CHECKSUM(SHA256) upstream package : 78ebf612a12510382ac84c1a2156a59fa36a1138b591f42e0b7fd99f94392ee0


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1381741
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6


===== Solution =====

Package NOT approved…  Please fix the lined out issues.

Comment 3 Björn 'besser82' Esser 2016-10-07 20:07:34 UTC
Created attachment 1208232 [details]
output of licensecheck

Comment 4 Christian Dersch 2016-10-07 20:55:20 UTC
Thank you :) I will fix the licensing breakdown and investigate the font unbundling.

Comment 5 Christian Dersch 2016-10-22 22:05:41 UTC
Spec URL: https://lupinix.fedorapeople.org/review/ginga.spec
SRPM URL: https://lupinix.fedorapeople.org/review/ginga-2.5.20161005204600-1.fc25.src.rpm

Fonts unbundled, wrong permissions and interpreters fixed, license breakdown added. I decided to move the examples to a special subpackage. Hopefully I'm done now :)

Comment 6 Björn 'besser82' Esser 2016-10-22 23:40:04 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
=======
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 5519360 bytes in 91 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

  ---> Coming from examples.  That's fine, since it is a separated package.


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated", "MIT/X11 (BSD like)",
     "PSF", "BSD (3 clause)", "*No copyright* Apache (v2.0)". 584 files
     have unknown license. Detailed output of licensecheck in
     /home/besser82/shared/fedora/review/1381741-ginga/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
     contains desktop file(s) with a MimeType: entry.
     Note: desktop file(s) with MimeType entry in ginga
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep


===== SHOULD items =====

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files

     ---> Fonts are symlinked and font-package is required.


[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python2-ginga , python3-ginga

     ---> pythonX-packages are stand-alone.

[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.

     ---> I suggest to run the testsuite during %%check using nosetests


[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.


===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: ginga-2.5.20161005204600-1.fc26.noarch.rpm
          python2-ginga-2.5.20161005204600-1.fc26.noarch.rpm
          python2-ginga-examples-2.5.20161005204600-1.fc26.noarch.rpm
          python3-ginga-2.5.20161005204600-1.fc26.noarch.rpm
          python3-ginga-examples-2.5.20161005204600-1.fc26.noarch.rpm
          ginga-2.5.20161005204600-1.fc26.src.rpm
ginga.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy
ginga.noarch: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
ginga.noarch: W: spelling-error %description -l en_US fwhm -> whom
ginga.noarch: W: no-manual-page-for-binary ggrc
ginga.noarch: W: no-manual-page-for-binary ginga
python2-ginga.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy
python2-ginga.noarch: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
python2-ginga.noarch: W: spelling-error %description -l en_US fwhm -> whom
python2-ginga.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/ginga/fonts/Roboto/Roboto-Medium.ttf /usr/share/fonts/google-roboto/Roboto-Medium.ttf
python2-ginga.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/ginga/fonts/Roboto/Roboto-Bold.ttf /usr/share/fonts/google-roboto/Roboto-Bold.ttf
python2-ginga.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/ginga/fonts/Roboto/Roboto-Light.ttf /usr/share/fonts/google-roboto/Roboto-Light.ttf
python2-ginga.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/ginga/fonts/Roboto/Roboto-Thin.ttf /usr/share/fonts/google-roboto/Roboto-Thin.ttf
python2-ginga.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/ginga/fonts/Roboto/Roboto-Regular.ttf /usr/share/fonts/google-roboto/Roboto-Regular.ttf
python2-ginga.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/ginga/fonts/Roboto/Roboto-Black.ttf /usr/share/fonts/google-roboto/Roboto-Black.ttf
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/matplotlib/example5_mpl.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/gtk/fits2pdf.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/pg/example2_pg.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/tk/example1_tk.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/qt/example1_qt.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/gw/example1_video.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/matplotlib/example2_mpl.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/gw/example2.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/matplotlib/example1_mpl.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/matplotlib/example4_mpl.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/gtk3/example2.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/gw/shared_canvas.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/matplotlib/example3_mpl.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/gtk/example2_gtk.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/tk/example2_tk.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/gtk/example1_gtk.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/qt/example2_qt.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/gtk3/example1.py /usr/bin/python2
python3-ginga.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy
python3-ginga.noarch: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
python3-ginga.noarch: W: spelling-error %description -l en_US fwhm -> whom
python3-ginga.noarch: W: dangling-symlink /usr/lib/python3.5/site-packages/ginga/fonts/Roboto/Roboto-Light.ttf /usr/share/fonts/google-roboto/Roboto-Light.ttf
python3-ginga.noarch: W: dangling-symlink /usr/lib/python3.5/site-packages/ginga/fonts/Roboto/Roboto-Regular.ttf /usr/share/fonts/google-roboto/Roboto-Regular.ttf
python3-ginga.noarch: W: dangling-symlink /usr/lib/python3.5/site-packages/ginga/fonts/Roboto/Roboto-Bold.ttf /usr/share/fonts/google-roboto/Roboto-Bold.ttf
python3-ginga.noarch: W: dangling-symlink /usr/lib/python3.5/site-packages/ginga/fonts/Roboto/Roboto-Thin.ttf /usr/share/fonts/google-roboto/Roboto-Thin.ttf
python3-ginga.noarch: W: dangling-symlink /usr/lib/python3.5/site-packages/ginga/fonts/Roboto/Roboto-Black.ttf /usr/share/fonts/google-roboto/Roboto-Black.ttf
python3-ginga.noarch: W: dangling-symlink /usr/lib/python3.5/site-packages/ginga/fonts/Roboto/Roboto-Medium.ttf /usr/share/fonts/google-roboto/Roboto-Medium.ttf
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/matplotlib/example2_mpl.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/gw/example2.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/matplotlib/example5_mpl.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/pg/example2_pg.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/gtk/fits2pdf.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/gtk/example1_gtk.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/gtk3/example2.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/qt/example2_qt.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/gtk/example2_gtk.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/matplotlib/example3_mpl.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/matplotlib/example4_mpl.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/tk/example2_tk.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/gw/example1_video.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/qt/example1_qt.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/gw/shared_canvas.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/tk/example1_tk.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/gtk3/example1.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/matplotlib/example1_mpl.py /usr/bin/python3
ginga.src: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy
ginga.src: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
ginga.src: W: spelling-error %description -l en_US fwhm -> whom
6 packages and 0 specfiles checked; 0 errors, 62 warnings.




Rpmlint (installed packages)
----------------------------
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/matplotlib/example4_mpl.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/gw/shared_canvas.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/matplotlib/example5_mpl.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/matplotlib/example2_mpl.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/qt/example2_qt.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/gtk3/example2.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/pg/example2_pg.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/tk/example2_tk.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/qt/example1_qt.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/gtk/example1_gtk.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/tk/example1_tk.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/gw/example1_video.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/matplotlib/example3_mpl.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/matplotlib/example1_mpl.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/gtk/example2_gtk.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/gtk/fits2pdf.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/gtk3/example1.py /usr/bin/python2
python2-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python2-ginga-examples/gw/example2.py /usr/bin/python2
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/gtk/fits2pdf.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/gw/shared_canvas.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/gtk3/example2.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/matplotlib/example5_mpl.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/gtk/example1_gtk.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/matplotlib/example4_mpl.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/matplotlib/example3_mpl.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/gtk/example2_gtk.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/gw/example1_video.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/qt/example1_qt.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/pg/example2_pg.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/gw/example2.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/matplotlib/example1_mpl.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/tk/example2_tk.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/qt/example2_qt.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/gtk3/example1.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/tk/example1_tk.py /usr/bin/python3
python3-ginga-examples.noarch: W: doc-file-dependency /usr/share/doc/python3-ginga-examples/matplotlib/example2_mpl.py /usr/bin/python3
python2-ginga.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy
python2-ginga.noarch: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
python2-ginga.noarch: W: spelling-error %description -l en_US fwhm -> whom
python2-ginga.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/ginga/fonts/Roboto/Roboto-Light.ttf /usr/share/fonts/google-roboto/Roboto-Light.ttf
python2-ginga.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/ginga/fonts/Roboto/Roboto-Medium.ttf /usr/share/fonts/google-roboto/Roboto-Medium.ttf
python2-ginga.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/ginga/fonts/Roboto/Roboto-Bold.ttf /usr/share/fonts/google-roboto/Roboto-Bold.ttf
python2-ginga.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/ginga/fonts/Roboto/Roboto-Thin.ttf /usr/share/fonts/google-roboto/Roboto-Thin.ttf
python2-ginga.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/ginga/fonts/Roboto/Roboto-Black.ttf /usr/share/fonts/google-roboto/Roboto-Black.ttf
python2-ginga.noarch: W: dangling-symlink /usr/lib/python2.7/site-packages/ginga/fonts/Roboto/Roboto-Regular.ttf /usr/share/fonts/google-roboto/Roboto-Regular.ttf
python3-ginga.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy
python3-ginga.noarch: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
python3-ginga.noarch: W: spelling-error %description -l en_US fwhm -> whom
python3-ginga.noarch: W: dangling-symlink /usr/lib/python3.5/site-packages/ginga/fonts/Roboto/Roboto-Medium.ttf /usr/share/fonts/google-roboto/Roboto-Medium.ttf
python3-ginga.noarch: W: dangling-symlink /usr/lib/python3.5/site-packages/ginga/fonts/Roboto/Roboto-Regular.ttf /usr/share/fonts/google-roboto/Roboto-Regular.ttf
python3-ginga.noarch: W: dangling-symlink /usr/lib/python3.5/site-packages/ginga/fonts/Roboto/Roboto-Bold.ttf /usr/share/fonts/google-roboto/Roboto-Bold.ttf
python3-ginga.noarch: W: dangling-symlink /usr/lib/python3.5/site-packages/ginga/fonts/Roboto/Roboto-Black.ttf /usr/share/fonts/google-roboto/Roboto-Black.ttf
python3-ginga.noarch: W: dangling-symlink /usr/lib/python3.5/site-packages/ginga/fonts/Roboto/Roboto-Thin.ttf /usr/share/fonts/google-roboto/Roboto-Thin.ttf
python3-ginga.noarch: W: dangling-symlink /usr/lib/python3.5/site-packages/ginga/fonts/Roboto/Roboto-Light.ttf /usr/share/fonts/google-roboto/Roboto-Light.ttf
ginga.noarch: W: spelling-error %description -l en_US numpy -> bumpy, lumpy, dumpy
ginga.noarch: W: spelling-error %description -l en_US scalable -> salable, callable, calculable
ginga.noarch: W: spelling-error %description -l en_US fwhm -> whom
ginga.noarch: W: no-manual-page-for-binary ginga
ginga.noarch: W: no-manual-page-for-binary ggrc
5 packages and 0 specfiles checked; 0 errors, 59 warnings.

---> You should filter-out the auto-req from the -examples package.
     Please double-check the symlinks to the fonts.
     I suggest generating man-pages for the scripts in %{_bindir},
     using help2man.  Just export PYTHONPATH to point to the python-dirs
     in %{buildroot}.


Requires
--------
python2-ginga-examples (rpmlib, GLIBC filtered):
    /usr/bin/python2
    python2-ginga

python3-ginga-examples (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python3-ginga

python2-ginga (rpmlib, GLIBC filtered):
    /usr/bin/python2
    google-roboto-fonts
    python(abi)
    python2-astropy
    python2-matplotlib-qt5
    python2-qt5
    python2-scipy

python3-ginga (rpmlib, GLIBC filtered):
    /usr/bin/python3
    google-roboto-fonts
    python(abi)
    python3-astropy
    python3-matplotlib-qt5
    python3-qt5
    python3-scipy

ginga (rpmlib, GLIBC filtered):
    /bin/sh
    /usr/bin/python3
    python3-ginga



Provides
--------
python2-ginga-examples:
    python-ginga-examples
    python2-ginga-examples

python3-ginga-examples:
    python3-ginga-examples

python2-ginga:
    python-ginga
    python2-ginga
    python2.7dist(ginga)
    python2dist(ginga)

python3-ginga:
    python3-ginga
    python3.5dist(ginga)
    python3dist(ginga)

ginga:
    application()
    application(ginga.desktop)
    ginga
    mimehandler(image/x-fits)



Source checksums
----------------
https://files.pythonhosted.org/packages/source/g/ginga/ginga-2.5.20161005204600.tar.gz :
  CHECKSUM(SHA256) this package     : 895460f695004fa116acf60b1074ff5ff24c7b9506d9287e472309a6541a4258
  CHECKSUM(SHA256) upstream package : 895460f695004fa116acf60b1074ff5ff24c7b9506d9287e472309a6541a4258


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1381741
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6


===== Solution =====

Package APPROVED!!!  Please consider my recommendations about testsuite and rpmlint-output during import.

Comment 7 Gwyn Ciesla 2016-10-24 12:48:43 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/ginga

Comment 8 Fedora Update System 2016-10-25 02:21:34 UTC
ginga-2.5.20161005204600-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b68460ba1a

Comment 9 Fedora Update System 2016-10-25 04:21:35 UTC
ginga-2.5.20161005204600-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b5aa723f15

Comment 10 Fedora Update System 2016-10-31 07:35:54 UTC
ginga-2.5.20161005204600-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2016-11-03 23:54:04 UTC
ginga-2.5.20161005204600-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.