Bug 1381765 - (filezilla) "Rename" gui issues when GTK_OVERLAY_SCROLLING=0 and there are scrollbars in the pane
Summary: (filezilla) "Rename" gui issues when GTK_OVERLAY_SCROLLING=0 and there are sc...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: wxGTK3
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Scott Talbert
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-04 23:21 UTC by utwubie
Modified: 2016-11-21 02:23 UTC (History)
2 users (show)

Fixed In Version: wxGTK3-3.0.2-29.fc25 wxGTK3-3.0.2-29.fc24
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-19 21:18:52 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description utwubie 2016-10-04 23:21:40 UTC
GTK3 has a new "overlay scrolling" feature which makes it so that scrollbars aren't visible until you put the mouse over the pane. This feature can be turned off by setting the environmental variable GTK_OVERLAY_SCROLLING=0. I have turned the overlay scrolling off in this way. It is also disabled by default by the Mate Desktop.

in FileZilla, if GTK_OVERLAY_SCROLLING=0 and the pane has a scrollbar, the "Rename" function usually (if you try more than once, you will likely see the problem) does not produce the inline input box GUI (instead the file just remains highlighted). in reality, you can still rename the file by using the backspace button and typing characters, but you do so blindly as you can't see any of this is working (e.g. you can't see the characters you type) until you press enter and the filename is in fact changed.

filezilla developer "codesquid" states:
"This is due to a known bug in wxWidgets. Please update your copy of wxWidgets to the latest commit from the WX_3_0_BRANCH branch of wx' git repository."
(https://trac.filezilla-project.org/ticket/11000)

the wxWidgets team notes the following about the latest release:
'Please notice that while 3.1.0 is officially a "development" version because it is not fully compatible with 3.0.x, the list of backwards incompatible changes is very short, so you shouldn't have any problems updating to this version from 3.0.x in practice, and you're encouraged to try this version out and use it in production in spite of its odd version number.'
(https://www.wxwidgets.org/news/2016/02/wxwidgets-3.1.0-released/)

Jeremy Newton worries that updating wxwidgets may cause regressions and suggests backporting fixes.
(https://bugzilla.redhat.com/show_bug.cgi?id=1381583)

Comment 1 Scott Talbert 2016-10-05 02:36:10 UTC
OK, I can reproduce this.  I'll see if I can bisect and find the commit that fixed it.

Comment 2 Scott Talbert 2016-10-11 03:03:42 UTC
OK, I found the commit that fixed this.  Bisecting it was challenging because it actually required two commits to fix, one of which we already had, and git kept pointing me to the one already had, which threw me through a loop for a while.  It turns out we also need 8d7e0d045250fa78a7e7d5a25cecee43bb75db3a.

Comment 3 utwubie 2016-10-11 12:44:02 UTC
Thanks for the hard work! :-)

Comment 4 Scott Talbert 2016-10-11 13:04:50 UTC
(In reply to utwubie from comment #3)
> Thanks for the hard work! :-)

You are welcome.  This is fixed in Rawhide now.  We'll get an update out for the stable releases eventually.

Comment 5 Fedora Update System 2016-11-14 03:58:51 UTC
wxGTK3-3.0.2-29.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b372d67ade

Comment 6 Fedora Update System 2016-11-14 03:59:24 UTC
wxGTK3-3.0.2-29.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-da57f5c618

Comment 7 Fedora Update System 2016-11-15 02:30:03 UTC
wxGTK3-3.0.2-29.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-da57f5c618

Comment 8 Fedora Update System 2016-11-15 13:26:48 UTC
wxGTK3-3.0.2-29.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b372d67ade

Comment 9 Fedora Update System 2016-11-19 21:18:52 UTC
wxGTK3-3.0.2-29.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2016-11-21 02:23:00 UTC
wxGTK3-3.0.2-29.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.