Bug 1381807 - Adding direct LUN fails with an NPE @ DiskVmElementValidator.isVirtioScsiControllerAttached(DiskVmElementValidator.java:71)
Summary: Adding direct LUN fails with an NPE @ DiskVmElementValidator.isVirtioScsiCont...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.1.0
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ovirt-4.1.0-alpha
: 4.1.0.2
Assignee: Tal Nisan
QA Contact: Aharon Canan
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-05 06:09 UTC by Yaniv Kaul
Modified: 2017-01-23 13:39 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-26 11:46:48 UTC
oVirt Team: Storage
Embargoed:
ykaul: ovirt-4.1+
ykaul: blocker+
ykaul: ci_coverage_complete+
rule-engine: planning_ack+
tnisan: devel_ack+
rule-engine: testing_ack?

Attachments (Terms of Use)
engine.log (302.04 KB, application/x-gzip)
2016-10-05 06:09 UTC, Yaniv Kaul 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 65120 0 master MERGED core: Fix NPE when adding a VIRTIO-ISCSI disk to a VM 2016-10-05 13:25:25 UTC

Description Yaniv Kaul 2016-10-05 06:09:09 UTC 
Created attachment 1207454 [details]
engine.log

Description of problem:
Running ovirt-system-tests on master. It failed on Direct LUN test 2016-10-04 15:05:42,270 INFO  [org.ovirt.engine.core.bll.storage.disk.AddDiskCommand] (default task-28) [2ece6589] Lock Acquired to object 'EngineLock:{exclusiveLocks='null', sharedLocks='[a76d74d0-03b9-4f08-944
3-84466a8ee7ed=<VM, ACTION_TYPE_FAILED_OBJECT_LOCKED>]'}'
2016-10-04 15:05:42,280 ERROR [org.ovirt.engine.core.bll.storage.disk.AddDiskCommand] (default task-28) [2ece6589] Error during ValidateFailure.: java.lang.NullPointerException
        at org.ovirt.engine.core.bll.validator.storage.DiskVmElementValidator.isVirtioScsiControllerAttached(DiskVmElementValidator.java:71) [bll.jar:]
        at org.ovirt.engine.core.bll.validator.storage.DiskVmElementValidator.isVirtIoScsiValid(DiskVmElementValidator.java:57) [bll.jar:]
        at org.ovirt.engine.core.bll.storage.disk.AddDiskCommand.checkIfLunDiskCanBeAdded(AddDiskCommand.java:213) [bll.jar:]
        at org.ovirt.engine.core.bll.storage.disk.AddDiskCommand.validate(AddDiskCommand.java:164) [bll.jar:]
        at org.ovirt.engine.core.bll.CommandBase.internalValidate(CommandBase.java:830) [bll.jar:]
        at org.ovirt.engine.core.bll.CommandBase.executeAction(CommandBase.java:391) [bll.jar:]
        at org.ovirt.engine.core.bll.executor.DefaultBackendActionExecutor.execute(DefaultBackendActionExecutor.java:13) [bll.jar:]
        at org.ovirt.engine.core.bll.Backend.runAction(Backend.java:512) [bll.jar:]
        at org.ovirt.engine.core.bll.Backend.runActionImpl(Backend.java:494) [bll.jar:]
        at org.ovirt.engine.core.bll.Backend.runAction(Backend.java:447) [bll.jar:]
        at sun.reflect.GeneratedMethodAccessor197.invoke(Unknown Source) [:1.8.0_102]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [rt.jar:1.8.0_102]
        at java.lang.reflect.Method.invoke(Method.java:498) [rt.jar:1.8.0_102]


Version-Release number of selected component (if applicable):
ovirt-engine-4.1.0-0.0.master.20161003211313.git2653cbc.el7.centos.noarch


I'm quite sure this has nothing to do with the test, but with
Comment 1 Tal Nisan 2016-10-05 11:53:43 UTC 
As for the steps to reproduce, this only happens when adding a disk with VIRTIO-ISCSI interface
Comment 2 Yaniv Kaul 2016-10-26 11:46:48 UTC 
Verified it works well upstream with ovirt-system-tests.
Note You need to log in before you can comment on or make changes to this bug.