Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1381807

Summary: Adding direct LUN fails with an NPE @ DiskVmElementValidator.isVirtioScsiControllerAttached(DiskVmElementValidator.java:71)
Product: [oVirt] ovirt-engine Reporter: Yaniv Kaul <ykaul>
Component: BLL.StorageAssignee: Tal Nisan <tnisan>
Status: CLOSED NEXTRELEASE QA Contact: Aharon Canan <acanan>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 4.1.0CC: bugs, ishaby
Target Milestone: ovirt-4.1.0-alphaKeywords: AutomationBlocker, Regression, TestBlocker
Target Release: 4.1.0.2Flags: ykaul: ovirt-4.1+
ykaul: blocker+
ykaul: ci_coverage_complete+
rule-engine: planning_ack+
tnisan: devel_ack+
rule-engine: testing_ack?
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-10-26 11:46:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine.log none

Description Yaniv Kaul 2016-10-05 06:09:09 UTC
Created attachment 1207454 [details]
engine.log

Description of problem:
Running ovirt-system-tests on master. It failed on Direct LUN test 2016-10-04 15:05:42,270 INFO  [org.ovirt.engine.core.bll.storage.disk.AddDiskCommand] (default task-28) [2ece6589] Lock Acquired to object 'EngineLock:{exclusiveLocks='null', sharedLocks='[a76d74d0-03b9-4f08-944
3-84466a8ee7ed=<VM, ACTION_TYPE_FAILED_OBJECT_LOCKED>]'}'
2016-10-04 15:05:42,280 ERROR [org.ovirt.engine.core.bll.storage.disk.AddDiskCommand] (default task-28) [2ece6589] Error during ValidateFailure.: java.lang.NullPointerException
        at org.ovirt.engine.core.bll.validator.storage.DiskVmElementValidator.isVirtioScsiControllerAttached(DiskVmElementValidator.java:71) [bll.jar:]
        at org.ovirt.engine.core.bll.validator.storage.DiskVmElementValidator.isVirtIoScsiValid(DiskVmElementValidator.java:57) [bll.jar:]
        at org.ovirt.engine.core.bll.storage.disk.AddDiskCommand.checkIfLunDiskCanBeAdded(AddDiskCommand.java:213) [bll.jar:]
        at org.ovirt.engine.core.bll.storage.disk.AddDiskCommand.validate(AddDiskCommand.java:164) [bll.jar:]
        at org.ovirt.engine.core.bll.CommandBase.internalValidate(CommandBase.java:830) [bll.jar:]
        at org.ovirt.engine.core.bll.CommandBase.executeAction(CommandBase.java:391) [bll.jar:]
        at org.ovirt.engine.core.bll.executor.DefaultBackendActionExecutor.execute(DefaultBackendActionExecutor.java:13) [bll.jar:]
        at org.ovirt.engine.core.bll.Backend.runAction(Backend.java:512) [bll.jar:]
        at org.ovirt.engine.core.bll.Backend.runActionImpl(Backend.java:494) [bll.jar:]
        at org.ovirt.engine.core.bll.Backend.runAction(Backend.java:447) [bll.jar:]
        at sun.reflect.GeneratedMethodAccessor197.invoke(Unknown Source) [:1.8.0_102]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [rt.jar:1.8.0_102]
        at java.lang.reflect.Method.invoke(Method.java:498) [rt.jar:1.8.0_102]


Version-Release number of selected component (if applicable):
ovirt-engine-4.1.0-0.0.master.20161003211313.git2653cbc.el7.centos.noarch


I'm quite sure this has nothing to do with the test, but with

Comment 1 Tal Nisan 2016-10-05 11:53:43 UTC
As for the steps to reproduce, this only happens when adding a disk with VIRTIO-ISCSI interface

Comment 2 Yaniv Kaul 2016-10-26 11:46:48 UTC
Verified it works well upstream with ovirt-system-tests.