Created attachment 1207590 [details] Screenshot of the bug Description of problem: There is no "Trap Number" string in the alert details screen. Version-Release number of selected component (if applicable): 5.7.0.3.20160927165516_075d0f3 How reproducible: Always Steps to Reproduce: 1. Navigate to Control->Explorer. 2. Expand Alerts accordion. 3. Create an alert with SNMP v1 trap notification. 4. Save the alert. Actual results: There is no "Trap Number" string in the alert details screen. "true" string is shown. Expected results: "Trap Number" string should be shown.
Brian, Can you look into this one, looks like trap_text is being incorrectly set here: https://github.com/ManageIQ/manageiq/blob/master/app/views/miq_policy/_alert_details.html.haml#L206 Let me know if you have questions. Thanks, ~Harpreet
Dmitry, is this also in 5.6.2?
Yes, this issue also is in 5.6.2.
https://github.com/ManageIQ/manageiq/pull/12008
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/0faeba8b5a75734973502a7e99512b5b0617e37d commit 0faeba8b5a75734973502a7e99512b5b0617e37d Author: Brian McLaughlin <bmclaugh> AuthorDate: Mon Oct 17 21:21:49 2016 -0400 Commit: Brian McLaughlin <bmclaugh> CommitDate: Tue Oct 18 09:18:51 2016 -0400 Correct logic to display Trap Number https://bugzilla.redhat.com/show_bug.cgi?id=1381969 app/views/miq_policy/_alert_details.html.haml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/50073d6bd725b8cbeea87b6aa02a5e550a48e320 commit 50073d6bd725b8cbeea87b6aa02a5e550a48e320 Author: Brian McLaughlin <bmclaugh> AuthorDate: Mon Oct 17 21:23:26 2016 -0400 Commit: Brian McLaughlin <bmclaugh> CommitDate: Tue Oct 18 09:18:51 2016 -0400 Test for displaying Trap Number https://bugzilla.redhat.com/show_bug.cgi?id=1381969 spec/views/miq_policy/_alert_details.html.haml_spec.rb | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 spec/views/miq_policy/_alert_details.html.haml_spec.rb
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/0163a3760c7e2d05e6e6717d9e090d82dcb9c33a commit 0163a3760c7e2d05e6e6717d9e090d82dcb9c33a Author: Brian McLaughlin <bmclaugh> AuthorDate: Tue Oct 18 10:39:54 2016 -0400 Commit: Brian McLaughlin <bmclaugh> CommitDate: Tue Oct 18 10:42:35 2016 -0400 DRY code slightly for readability https://bugzilla.redhat.com/show_bug.cgi?id=1381969 app/views/miq_policy/_alert_details.html.haml | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
New commit detected on ManageIQ/manageiq/euwe: https://github.com/ManageIQ/manageiq/commit/6f49c146854b78d7c9c493c020401f14ce307af4 commit 6f49c146854b78d7c9c493c020401f14ce307af4 Author: Harpreet Kataria <hkataria> AuthorDate: Tue Oct 18 15:49:55 2016 -0400 Commit: Oleg Barenboim <chessbyte> CommitDate: Tue Oct 18 23:20:59 2016 -0500 Merge pull request #12008 from bmclaughlin/display-trap-number Display trap number as expected (cherry picked from commit 77018d1a22f2a480211cbcd417718220a69a3072) https://bugzilla.redhat.com/show_bug.cgi?id=1381969 app/views/miq_policy/_alert_details.html.haml | 7 +++---- spec/views/miq_policy/_alert_details.html.haml_spec.rb | 15 +++++++++++++++ 2 files changed, 18 insertions(+), 4 deletions(-) create mode 100644 spec/views/miq_policy/_alert_details.html.haml_spec.rb
Verified in 5.8.0.3.20170301174324_1e2e0c4, trap number is presented in Alert details screen.