Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1382644

Summary:	Examples are not packaged in the RPM (but are mentioned in the README file)
Product:	[oVirt] ovirt-engine-sdk-python	Reporter:	Yaniv Kaul <ykaul>
Component:	Packaging.rpm	Assignee:	Ondra Machacek <omachace>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Pavol Brilla <pbrilla>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.1.0a	CC:	bugs, juan.hernandez, lsvaty, mgoldboi, omachace, ykaul
Target Milestone:	ovirt-4.0.6	Flags:	rule-engine: ovirt-4.0.z+ mgoldboi: planning_ack+ juan.hernandez: devel_ack+ lsvaty: testing_ack+
Target Release:	4.0.4
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-ovirt-engine-sdk4-4.0.4	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1398351 (view as bug list)		Environment:
Last Closed:	2017-01-18 07:26:45 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1398351

Description Yaniv Kaul 2016-10-07 09:49:32 UTC

Description of problem:
The examples directory is not packaged in the Python SDK - but in the README, it says:
"You will find more usage examples in the `examples` directory."

Version-Release number of selected component (if applicable):
python-ovirt-engine-sdk4-4.1.0-0.0.20161003git056315d.fc24.x86_64

Comment 1 Red Hat Bugzilla Rules Engine 2016-10-07 11:00:04 UTC

Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 2 Juan Hernández 2016-10-07 11:01:49 UTC

With the proposed patch the examples will be added to the RPM package, same as the README.adoc file:

  $ rpm --query --docfiles python-ovirt-engine-sdk4
  /usr/share/doc/python-ovirt-engine-sdk4/README.adoc
  /usr/share/doc/python-ovirt-engine-sdk4/examples/add_cluster.py
  /usr/share/doc/python-ovirt-engine-sdk4/examples/add_data_center.py
  /usr/share/doc/python-ovirt-engine-sdk4/examples/add_group.py
  ...

Comment 8 Pavol Brilla 2016-11-24 10:57:02 UTC

# rpm -q rhevm python-ovirt-engine-sdk4
rhevm-4.0.6-0.1.el7ev.noarch
python-ovirt-engine-sdk4-4.0.4-1.el7ev.x86_64

# rpm --query --docfiles python-ovirt-engine-sdk4
/usr/share/doc/python-ovirt-engine-sdk4-4.0.4/README.adoc

# ls -l /usr/share/doc/python-ovirt-engine-sdk4-4.0.4/
total 4
-rw-r--r--. 1 root root 2158 Nov 15 17:17 README.adoc

Comment 9 Red Hat Bugzilla Rules Engine 2016-11-24 10:57:07 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 10 Pavol Brilla 2016-11-24 19:08:25 UTC

check on upstream: 

# yum repolist
repo id                                  repo name                                        status
...
ovirt-4.0-pre/7                          oVirt 4.0 Pre-Release                               199
...

# rpm -q python-ovirt-engine-sdk4.x86_64
python-ovirt-engine-sdk4-4.0.4-1.el7.centos.x86_64


# rpm -qd python-ovirt-engine-sdk4.x86_64
/usr/share/doc/python-ovirt-engine-sdk4-4.0.4/README.adoc
/usr/share/doc/python-ovirt-engine-sdk4-4.0.4/examples/add_cluster.py
/usr/share/doc/python-ovirt-engine-sdk4-4.0.4/examples/add_data_center.py
/usr/share/doc/python-ovirt-engine-sdk4-4.0.4/examples/add_floating_disk.py
...