Bug 1382644 - Examples are not packaged in the RPM (but are mentioned in the README file)
Summary: Examples are not packaged in the RPM (but are mentioned in the README file)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-sdk-python
Classification: oVirt
Component: Packaging.rpm
Version: 4.1.0a
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.0.6
: 4.0.4
Assignee: Ondra Machacek
QA Contact: Pavol Brilla
URL:
Whiteboard:
Depends On:
Blocks: 1398351
TreeView+ depends on / blocked
 
Reported: 2016-10-07 09:49 UTC by Yaniv Kaul
Modified: 2017-01-18 07:26 UTC (History)
6 users (show)

Fixed In Version: python-ovirt-engine-sdk4-4.0.4
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1398351 (view as bug list)
Environment:
Last Closed: 2017-01-18 07:26:45 UTC
oVirt Team: Infra
Embargoed:
rule-engine: ovirt-4.0.z+
mgoldboi: planning_ack+
juan.hernandez: devel_ack+
lsvaty: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 65220 0 master MERGED Add examples to the RPM packages 2016-10-07 11:43:12 UTC
oVirt gerrit 65221 0 sdk_4.0 MERGED Add examples to the RPM packages 2016-10-07 12:55:55 UTC

Description Yaniv Kaul 2016-10-07 09:49:32 UTC
Description of problem:
The examples directory is not packaged in the Python SDK - but in the README, it says:
"You will find more usage examples in the `examples` directory."

Version-Release number of selected component (if applicable):
python-ovirt-engine-sdk4-4.1.0-0.0.20161003git056315d.fc24.x86_64

Comment 1 Red Hat Bugzilla Rules Engine 2016-10-07 11:00:04 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 2 Juan Hernández 2016-10-07 11:01:49 UTC
With the proposed patch the examples will be added to the RPM package, same as the README.adoc file:

  $ rpm --query --docfiles python-ovirt-engine-sdk4
  /usr/share/doc/python-ovirt-engine-sdk4/README.adoc
  /usr/share/doc/python-ovirt-engine-sdk4/examples/add_cluster.py
  /usr/share/doc/python-ovirt-engine-sdk4/examples/add_data_center.py
  /usr/share/doc/python-ovirt-engine-sdk4/examples/add_group.py
  ...

Comment 8 Pavol Brilla 2016-11-24 10:57:02 UTC
# rpm -q rhevm python-ovirt-engine-sdk4
rhevm-4.0.6-0.1.el7ev.noarch
python-ovirt-engine-sdk4-4.0.4-1.el7ev.x86_64

# rpm --query --docfiles python-ovirt-engine-sdk4
/usr/share/doc/python-ovirt-engine-sdk4-4.0.4/README.adoc

# ls -l /usr/share/doc/python-ovirt-engine-sdk4-4.0.4/
total 4
-rw-r--r--. 1 root root 2158 Nov 15 17:17 README.adoc

Comment 9 Red Hat Bugzilla Rules Engine 2016-11-24 10:57:07 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 10 Pavol Brilla 2016-11-24 19:08:25 UTC
check on upstream: 

# yum repolist
repo id                                  repo name                                        status
...
ovirt-4.0-pre/7                          oVirt 4.0 Pre-Release                               199
...

# rpm -q python-ovirt-engine-sdk4.x86_64
python-ovirt-engine-sdk4-4.0.4-1.el7.centos.x86_64


# rpm -qd python-ovirt-engine-sdk4.x86_64
/usr/share/doc/python-ovirt-engine-sdk4-4.0.4/README.adoc
/usr/share/doc/python-ovirt-engine-sdk4-4.0.4/examples/add_cluster.py
/usr/share/doc/python-ovirt-engine-sdk4-4.0.4/examples/add_data_center.py
/usr/share/doc/python-ovirt-engine-sdk4-4.0.4/examples/add_floating_disk.py
...


Note You need to log in before you can comment on or make changes to this bug.