Description: This applet integrates the Ubuntu Application Menu (Global Menu) support into the Cinnamon Desktop. It uses the same idea as the Gnome Shell extension made by rgcjonas. This is a third-party applet, not official. Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15987258 Issues: No known packaging issues, but false positives from rpmlint. FAS-User: besser82 Urls: Spec URL: https://besser82.fedorapeople.org/review/cinnamon-applet-globalappmenu.spec SRPM URL: https://besser82.fedorapeople.org/review/cinnamon-applet-globalappmenu-0.6-0.1.git20160913.5b55d2d.fc26.src.rpm Additional information: Blocking bugs are runtime dependencies; not needed for building the package. Thanks for review in advance!
Taken
APPROVED! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GPL (v3 or later)", "GPL (v2 or later)", "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/review/1382810-cinnamon-applet- globalappmenu/licensecheck.txt ===> It is clearly GPLv3+, upstream should just update some license headers... [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. ==> is noarch [-]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cinnamon-applet-globalappmenu-0.6-0.1.git20160913.5b55d2d.fc26.noarch.rpm cinnamon-applet-globalappmenu-0.6-0.1.git20160913.5b55d2d.fc26.src.rpm cinnamon-applet-globalappmenu.noarch: W: spelling-error %description -l en_US rgcjonas -> Jonas cinnamon-applet-globalappmenu.src: W: spelling-error %description -l en_US rgcjonas -> Jonas 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- cinnamon-applet-globalappmenu.noarch: W: spelling-error %description -l en_US rgcjonas -> Jonas 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- cinnamon-applet-globalappmenu (rpmlib, GLIBC filtered): appmenu-qt appmenu-qt5 cinnamon unity-gtk2-module unity-gtk3-module Provides -------- cinnamon-applet-globalappmenu: cinnamon-applet-globalappmenu Source checksums ---------------- https://github.com/lestcape/Global-AppMenu/archive/5b55d2d031285f46aceea469802fd63d4e78a528.tar.gz#/cinnamon-applet-globalappmenu-0.6-git20160913-5b55d2d.tar.gz : CHECKSUM(SHA256) this package : f15dad213c93b269f26b813d58a36f832cd1ade2374b974f845f60084e00df52 CHECKSUM(SHA256) upstream package : f15dad213c93b269f26b813d58a36f832cd1ade2374b974f845f60084e00df52 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -v -L rpm_deps/ -m fedora-rawhide-x86_64 -b 1382810 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Built with local dependencies: /home/review/rpm_deps/unity-gtk3-module-0.0.0+16.10.20160913-0.1.fc26.x86_64.rpm /home/review/rpm_deps/appmenu-qt5-profile.d-0.3.0+16.10.20160628.1-0.1.fc26.noarch.rpm /home/review/rpm_deps/libunity-gtk3-parser-devel-0.0.0+16.10.20160913-0.1.fc26.x86_64.rpm /home/review/rpm_deps/unity-gtk-module-debuginfo-0.0.0+16.10.20160913-0.1.fc26.x86_64.rpm /home/review/rpm_deps/appmenu-qt5-0.3.0+16.10.20160628.1-0.1.fc26.x86_64.rpm /home/review/rpm_deps/libunity-gtk-parser-devel-0.0.0+16.10.20160913-0.1.fc26.noarch.rpm /home/review/rpm_deps/appmenu-qt5-debuginfo-0.3.0+16.10.20160628.1-0.1.fc26.x86_64.rpm /home/review/rpm_deps/unity-gtk-module-common-0.0.0+16.10.20160913-0.1.fc26.noarch.rpm /home/review/rpm_deps/libunity-gtk2-parser-devel-0.0.0+16.10.20160913-0.1.fc26.x86_64.rpm /home/review/rpm_deps/libunity-gtk3-parser-0.0.0+16.10.20160913-0.1.fc26.x86_64.rpm /home/review/rpm_deps/libunity-gtk2-parser-0.0.0+16.10.20160913-0.1.fc26.x86_64.rpm /home/review/rpm_deps/unity-gtk2-module-0.0.0+16.10.20160913-0.1.fc26.x86_64.rpm
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/cinnamon-applet-globalappmenu
appmenu-qt5-0.3.0+16.10.20160628.1-1.fc24, cinnamon-applet-globalappmenu-0.6-1.git20160913.5b55d2d.fc24, unity-gtk-module-0.0.0+16.10.20160913-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-aa3eace46c
appmenu-qt5-0.3.0+16.10.20160628.1-1.fc25, cinnamon-applet-globalappmenu-0.6-1.git20160913.5b55d2d.fc25, unity-gtk-module-0.0.0+16.10.20160913-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-cda26e7897
appmenu-qt5-0.3.0+16.10.20160628.1-1.fc25, cinnamon-applet-globalappmenu-0.6-1.git20160913.5b55d2d.fc25, unity-gtk-module-0.0.0+16.10.20160913-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
appmenu-qt5-0.3.0+16.10.20160628.1-1.fc24, cinnamon-applet-globalappmenu-0.6-1.git20160913.5b55d2d.fc24, unity-gtk-module-0.0.0+16.10.20160913-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.