Bug 1382937 - Review Request: python-dominate - Dominate is a Python library for HTML documents
Summary: Review Request: python-dominate - Dominate is a Python library for HTML docum...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Lumír Balhar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-08 15:07 UTC by David Hannequin
Modified: 2017-11-11 03:03 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-11-03 13:29:30 UTC
Type: ---
Embargoed:
lbalhar: fedora-review+


Attachments (Terms of Use)

Description David Hannequin 2016-10-08 15:07:36 UTC
Spec URL: https://hvad.fedorapeople.org/fedora/python-dominate/python-dominate.spec
SRPM URL: https://hvad.fedorapeople.org/fedora/python-dominate/python-dominate-2.2.1-1.fc24.src.rpm

Description: Dominate is a Python library for creating and manipulating HTML documents using an elegant DOM API. It allows you to write HTML pages in pure Python very concisely, which eliminates the need to learn another template language, and lets you take advantage of the more powerful features of Python.


Fedora Account System Username: hvad

Comment 1 Dominika Krejčí 2016-10-14 10:44:09 UTC
Hello David, I have some comments:

* It is better to be more specific and use `python2-setuptools` instead of `python-setuptools`.

* It is good to indicate in the subpackage description whether it is Python 2 or Python3.

* Tests are packaged but the %check section is not present.

Comment 2 David Hannequin 2016-10-15 12:49:59 UTC
Hello,

* It is better to be more specific and use `python2-setuptools` instead of `python-setuptools`.

I fix this.

* It is good to indicate in the subpackage description whether it is Python 2 or Python3.

I fix this too.

* Tests are packaged but the %check section is not present.

I add %check but work only with python 2 because pyhon 3 test failed. I'll report to upstream. 

Could pass anyway for review ? 

Thanks

Comment 3 Dominika Krejčí 2016-10-18 08:32:26 UTC
Hi David,
here is the formal review. Just to more things. The rest seems fine. ;)

Issues
======
[!]: Changelog in prescribed format. Please change it to this:
* Wed Oct 05 2016 David Hannequin <david.hannequin> - 2.2.1-1
- Initial package.

pythonX-dominate.noarch: E: description-line-too-long C Dominate is a Python X library for creating and manipulating HTML documents using
Put a word "using" on the next line and it will be fine. One line should not be longer then 80 characters.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python2-dominate , python3-dominate
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
     Note: Tests for Python 3 fails. Packager should report it to upstream.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-dominate-2.2.1-1.fc26.noarch.rpm
          python3-dominate-2.2.1-1.fc26.noarch.rpm
          python-dominate-2.2.1-1.fc26.src.rpm
python2-dominate.noarch: E: description-line-too-long C Dominate is a Python 2 library for creating and manipulating HTML documents using
python3-dominate.noarch: E: description-line-too-long C Dominate is a Python 3 library for creating and manipulating HTML documents using
3 packages and 0 specfiles checked; 2 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
python3-dominate.noarch: E: description-line-too-long C Dominate is a Python 3 library for creating and manipulating HTML documents using
python2-dominate.noarch: E: description-line-too-long C Dominate is a Python 2 library for creating and manipulating HTML documents using
2 packages and 0 specfiles checked; 2 errors, 0 warnings.



Requires
--------
python3-dominate (rpmlib, GLIBC filtered):
    python(abi)

python2-dominate (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
python3-dominate:
    python3-dominate
    python3.5dist(dominate)
    python3dist(dominate)

python2-dominate:
    python-dominate
    python2-dominate
    python2.7dist(dominate)
    python2dist(dominate)



Source checksums
----------------
https://files.pythonhosted.org/packages/source/d/dominate/dominate-2.2.1.zip :
  CHECKSUM(SHA256) this package     : 4aa6a2f458461541f9ceeb58b49da9b42320f80aa2a6f692baea2817431d9953
  CHECKSUM(SHA256) upstream package : 4aa6a2f458461541f9ceeb58b49da9b42320f80aa2a6f692baea2817431d9953


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1382937
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 4 David Hannequin 2016-10-25 16:46:59 UTC
Hi Dominika,

I'fix issues. 

Thank's for your review

Comment 5 Dominika Krejčí 2016-10-26 14:22:25 UTC
Hi David,
I noticed you do not run any test `Ran 0 tests in 0.000s`. You will probably need to add pytest to BuildRequires and use another command in the check section.

Comment 6 David Hannequin 2016-12-25 17:10:54 UTC
Hi,

I think lib test don't work. Can pass anyway ?

Thanks

Comment 7 David Hannequin 2016-12-28 19:18:47 UTC
Hi,

New spec file and SRPM :

Spec URL: https://hvad.fedorapeople.org/fedora/python-dominate/python-dominate.spec
SRPM URL: https://hvad.fedorapeople.org/fedora/python-dominate/python-dominate-2.2.1-1.fc25.src.rpm

I test with pytest but same way :-(. I think test don't work on this lib. 

Can you anyway accept this lib ?

Thanks

Comment 8 David Hannequin 2017-06-18 16:58:40 UTC
Any news ?

Comment 9 Dominika Krejčí 2017-06-21 07:13:24 UTC
[!]: Latest version is packaged.

Could you please package the latest version? 2.3.1 is available.

Comment 11 Elliott Sales de Andrade 2017-09-04 04:45:41 UTC
Upstream runs tests on TravisCI, so I'm pretty sure you should be able to get them working here.

Comment 12 Lumír Balhar 2017-10-05 20:52:10 UTC
Hello David.

Sorry for the delay. If you still want to package dominate to Fedora, I can help you and speed up this process.

Dominika and Elliott were right, you should run tests during the build of RPM. For your package you need to add python2-pytest and python3-pytest as BuildRequires and change the %check section to `%{__python2} -m pytest tests` and `%{__python3} -m pytest tests`. And then you will see running tests under both Pythons.

AFAIK tests were the last issue with this package so after fixing them we can approve it hopefully.

Have a nice day.

Comment 13 David Hannequin 2017-10-08 12:56:14 UTC
Hi,

I packaged latest version and fix tests : 

Spec URL: https://hvad.fedorapeople.org/fedora/python-dominate/python-dominate.spec
SRPM URL: https://hvad.fedorapeople.org/fedora/python-dominate/python-dominate-2.3.1-1.fc26.src.rpm

Thanks Lumir 

Best regard

Comment 14 Lumír Balhar 2017-10-10 09:19:15 UTC
Hello.

Thank you. Package looks good to me.

Package approved

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "*No copyright* LGPL (v3 or later)", "GPL (v3)", "Unknown or
     generated". 10 files have unknown license. Detailed output of
     licensecheck in /home/lbalhar/Review/1382937-python-
     dominate/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[-]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python2-dominate , python3-dominate
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-dominate-2.3.1-1.fc28.noarch.rpm
          python3-dominate-2.3.1-1.fc28.noarch.rpm
          python-dominate-2.3.1-1.fc28.src.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
python3-dominate.noarch: W: invalid-url URL: http://github.com/Knio/dominate/ <urlopen error [Errno -2] Name or service not known>
python2-dominate.noarch: W: invalid-url URL: http://github.com/Knio/dominate/ <urlopen error [Errno -2] Name or service not known>
2 packages and 0 specfiles checked; 0 errors, 2 warnings.



Requires
--------
python3-dominate (rpmlib, GLIBC filtered):
    python(abi)

python2-dominate (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
python3-dominate:
    python3-dominate
    python3.6dist(dominate)
    python3dist(dominate)

python2-dominate:
    python-dominate
    python2-dominate
    python2.7dist(dominate)
    python2dist(dominate)



Source checksums
----------------
https://files.pythonhosted.org/packages/source/d/dominate/dominate-2.3.1.tar.gz :
  CHECKSUM(SHA256) this package     : 4b8ce6f33633c9dd9175b228d21c00c801b6bd0327747cd5e17fc2da934c3a69
  CHECKSUM(SHA256) upstream package : 4b8ce6f33633c9dd9175b228d21c00c801b6bd0327747cd5e17fc2da934c3a69

Comment 15 Gwyn Ciesla 2017-10-23 12:29:43 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-dominate

Comment 16 Fedora Update System 2017-10-23 21:33:32 UTC
python-dominate-2.3.1-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ff90f7c038

Comment 17 Fedora Update System 2017-10-23 21:39:31 UTC
python-dominate-2.3.1-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-0c2c0a4de8

Comment 18 Fedora Update System 2017-10-25 15:23:32 UTC
python-dominate-2.3.1-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ff90f7c038

Comment 19 Fedora Update System 2017-10-26 01:31:26 UTC
python-dominate-2.3.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-0c2c0a4de8

Comment 20 Fedora Update System 2017-11-03 13:29:30 UTC
python-dominate-2.3.1-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 21 Fedora Update System 2017-11-11 03:03:17 UTC
python-dominate-2.3.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.