Bug 1383264 - [v4 REST-API only] diskattachments link missing from /api/storagedomains/{export-domain:id}/vms/{vm:id}
Summary: [v4 REST-API only] diskattachments link missing from /api/storagedomains/{exp...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: RestAPI
Version: 4.0.5.1
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.0.6
: 4.0.6.2
Assignee: Juan Hernández
QA Contact: Raz Tamir
URL:
Whiteboard:
Depends On: 1371024
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-10 10:11 UTC by Carlos Mestre González
Modified: 2017-01-18 07:29 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-01-18 07:29:25 UTC
oVirt Team: Storage
Embargoed:
amureini: ovirt-4.0.z?
rule-engine: planning_ack?
rule-engine: devel_ack+
rule-engine: testing_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 65343 0 ovirt-engine-4.0 MERGED restapi: Add 'diskattachments' link to storage domain VM 2016-10-13 12:03:22 UTC
oVirt gerrit 67421 0 ovirt-engine-4.0 MERGED restapi: Fix typo in disk attachments link 2016-11-28 13:37:59 UTC
oVirt gerrit 67431 0 ovirt-engine-4.0.6 MERGED restapi: Fix typo in disk attachments link 2016-11-28 14:49:45 UTC

Description Carlos Mestre González 2016-10-10 10:11:05 UTC 
Description of problem:
In BZ1371024 a diskattachments collection was added to the export domain vms, but there's no link on the vms element:
 /api/storagedomains/{export-domain:id}/vms/{vm:id}

Version-Release number of selected component (if applicable):
rhevm-4.0.5-0.1.el7ev.noarch


Steps to Reproduce:
1. check /api/storagedomains/{export-domain:id}/vms/{vm:id}


Expected results:
<vm>
  [...]
   <link href= "/ovirt-engine/api/v4/storagedomains/6c493f95-daeb-42aa-bab7-93b36d28ee83/vms/1f25080a-7ad9-4baf-aa62-2f7dadb20eff/diskattachments" rel="diskattachments"/>
   [...]
</vm>
Comment 1 Juan Hernández 2016-10-11 10:22:55 UTC 
The proposed patch fixes the issue, adding the "diskattachments" link explicitly to the storage domain VMs collection. Note that this must only be done in the 4.0 branch, as in the 4.1 branch these links are automatically added, based on the information included in the model.
Comment 2 Raz Tamir 2016-11-21 17:13:55 UTC 
Verification failed - The link is for 'disk**s**attachments' and should be 'diskattachments'
Comment 3 Red Hat Bugzilla Rules Engine 2016-11-21 17:13:59 UTC 
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Comment 4 Tal Nisan 2016-11-28 10:16:06 UTC 
Juan, can we change this at this point?
Comment 5 Juan Hernández 2016-11-28 10:21:57 UTC 
Yes, I think we can change it.
Comment 6 Raz Tamir 2016-12-11 16:10:55 UTC 
Verified on 4.0.6.3-0.1.el7ev
Note You need to log in before you can comment on or make changes to this bug.