Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1383264

Summary:	[v4 REST-API only] diskattachments link missing from /api/storagedomains/{export-domain:id}/vms/{vm:id}
Product:	[oVirt] ovirt-engine	Reporter:	Carlos Mestre González <cmestreg>
Component:	RestAPI	Assignee:	Juan Hernández <juan.hernandez>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Raz Tamir <ratamir>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.0.5.1	CC:	acanan, amureini, bugs, gklein, juan.hernandez, ratamir
Target Milestone:	ovirt-4.0.6	Flags:	amureini: ovirt-4.0.z? rule-engine: planning_ack? rule-engine: devel_ack+ rule-engine: testing_ack+
Target Release:	4.0.6.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-01-18 07:29:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1371024
Bug Blocks:

Description Carlos Mestre González 2016-10-10 10:11:05 UTC

Description of problem:
In BZ1371024 a diskattachments collection was added to the export domain vms, but there's no link on the vms element:
 /api/storagedomains/{export-domain:id}/vms/{vm:id}

Version-Release number of selected component (if applicable):
rhevm-4.0.5-0.1.el7ev.noarch


Steps to Reproduce:
1. check /api/storagedomains/{export-domain:id}/vms/{vm:id}


Expected results:
<vm>
  [...]
   <link href= "/ovirt-engine/api/v4/storagedomains/6c493f95-daeb-42aa-bab7-93b36d28ee83/vms/1f25080a-7ad9-4baf-aa62-2f7dadb20eff/diskattachments" rel="diskattachments"/>
   [...]
</vm>

Comment 1 Juan Hernández 2016-10-11 10:22:55 UTC

The proposed patch fixes the issue, adding the "diskattachments" link explicitly to the storage domain VMs collection. Note that this must only be done in the 4.0 branch, as in the 4.1 branch these links are automatically added, based on the information included in the model.

Comment 2 Raz Tamir 2016-11-21 17:13:55 UTC

Verification failed - The link is for 'disk**s**attachments' and should be 'diskattachments'

Comment 3 Red Hat Bugzilla Rules Engine 2016-11-21 17:13:59 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 4 Tal Nisan 2016-11-28 10:16:06 UTC

Juan, can we change this at this point?

Comment 5 Juan Hernández 2016-11-28 10:21:57 UTC

Yes, I think we can change it.

Comment 6 Raz Tamir 2016-12-11 16:10:55 UTC

Verified on 4.0.6.3-0.1.el7ev