New commit detected on ManageIQ/manageiq/euwe: https://github.com/ManageIQ/manageiq/commit/a1cbffbbed0a09da20480e4f3b40a006a9312d28 commit a1cbffbbed0a09da20480e4f3b40a006a9312d28 Author: Oleg Barenboim <chessbyte> AuthorDate: Tue Oct 25 19:57:16 2016 +0200 Commit: Oleg Barenboim <chessbyte> CommitDate: Tue Oct 25 19:57:58 2016 +0200 Merge pull request #11974 from moolitayer/handle_nil_argument Handle nil container state (cherry picked from commit 8a5e0ce131114721b79c50c710c345bb332dbb4a) https://bugzilla.redhat.com/show_bug.cgi?id=1383498 .../providers/kubernetes/container_manager/refresh_parser.rb | 4 ++-- .../providers/kubernetes/container_manager/refresh_parser_spec.rb | 7 +++++++ 2 files changed, 9 insertions(+), 2 deletions(-)
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/58578628b1cadc001c747a653e08df4ad1365672 commit 58578628b1cadc001c747a653e08df4ad1365672 Author: Mooli Tayer <mtayer> AuthorDate: Sun Oct 16 01:10:35 2016 +0300 Commit: Mooli Tayer <mtayer> CommitDate: Tue Oct 25 12:09:45 2016 +0300 Handle nil container state https://bugzilla.redhat.com/show_bug.cgi?id=1383498 .../providers/kubernetes/container_manager/refresh_parser.rb | 4 ++-- .../providers/kubernetes/container_manager/refresh_parser_spec.rb | 7 +++++++ 2 files changed, 9 insertions(+), 2 deletions(-)
Created attachment 1218428 [details] Proposed Patch (hot fix) The gzipped tar archive has a single file app/models/manageiq/providers/kubernetes/container_manager/refresh_parser.rb On a Test appliance please make a backup of the existing file app/models/manageiq/providers/kubernetes/container_manager/refresh_parser.rb and replace it with the enclosed file.
Created attachment 1218430 [details] Proposed Patch (hot fix) The gzipped tar archive has a single file app/models/manageiq/providers/kubernetes/container_manager/refresh_parser.rb On a Test appliance please make a backup of the existing file app/models/manageiq/providers/kubernetes/container_manager/refresh_parser.rb and replace it with the enclosed file.
Created attachment 1218431 [details] Proposed Patch (hot fix) The gzipped tar archive has a single file app/models/manageiq/providers/kubernetes/container_manager/refresh_parser.rb On a Test appliance please make a backup of the existing file app/models/manageiq/providers/kubernetes/container_manager/refresh_parser.rb and replace it with the enclosed file.
Mooli, Yaacov, this BZ has a long history. Can you please provide details on how to reproduce? Einat
It would be best if we had a way to mock kubernetes data. for now you can verify this by following: https://gist.github.com/moolitayer/e5e7d0cf910a05fa5a7f400f0a115f2f
Mooli, What's the expected result for the above? I ran the queries and the final query returned: {:type=>"ManageIQ::Providers::Kubernetes::ContainerManager::Container", :ems_ref=>"0_registry_openshift/origin-docker-registry:v1.4.0-alpha.1", :name=>"registry", :restart_count=>2, :backing_ref=>"docker://77fe0206d0f9b651cc501ddc0318816189d6aca7d8013066446130b18bf8cb69", :container_image=>{:name=>"openshift/origin-docker-registry", :tag=>"v1.4.0-alpha.1", :digest=>nil, :image_ref=>"docker://sha256:c9e453bd2e055aad9283f2fd6d51e309ef871fc6c27bc6060e366bf066b33bed", :registered_on=>2017-04-24 17:46:24 UTC, :container_image_registry=>nil}, :last_state=>:terminated, :last_reason=>nil, :last_started_at=>nil, :last_finished_at=>nil, :last_exit_code=>nil, :last_signal=>nil, :last_message=>nil} Is this the expected result?
Yes, When run without the fix it raises an exception
Verified. Ran script as explained in comment 26.