Description of problem: When legacy migration is selected, autoconverge and compression migration settings as set by the user for the cluster or the particular VM are ignored and their values sent to Vdsm are always false. Version-Release number of selected component (if applicable): Current master. How reproducible: Always. Steps to Reproduce: 1. Open Edit Cluster dialog. 2. Select "Legacy" migration policy. 3. Select "Auto Converge" and "Compress" in Additional Properties. 4. Migrate a VM in the cluster. 5. Check Vdsm log (DEBUG level needed) for the migration parameters. Actual results: "autoConverge" and "compress" parameter values are "false". Expected results: "autoConverge" and "compress" parameter values are "true" as requested for the cluster. Additional info:
did not get into build, moving back to post
all merged
I still wonder how this hook works but it should check the build creation/tag time and not when the build is finished, otherwise bugs like this - modified during those 1-2 days when the build is ongoing - are changed incorrectly
Verify with: Engine:Red Hat Virtualization Manager Version: 4.0.5.2-0.2.el7ev Host: OS Version:RHEL - 7.3 - 6.el7 OS Description:Red Hat Enterprise Linux Server 7.3 Beta (Maipo) Kernel Version:3.10.0 - 510.el7.x86_64 KVM Version:2.6.0 - 27.el7 LIBVIRT Version:libvirt-2.0.0-10.el7 VDSM Version:vdsm-4.18.13-1.el7ev SPICE Version:0.12.4 - 19.el7 Steps to Reproduce: 1. Open Edit Cluster dialog. 2. Select "Legacy" migration policy. 3. Select "Auto Converge" and "Compress" in Additional Properties. (On vm those options are inherit from cluster) 4. Migrate a VM in the cluster. 5. Check Vdsm log (DEBUG level needed) for the migration parameters. Results: both "Auto Converge" and "Compress" are enabled. From the log: jsonrpc.Executor/3::DEBUG::2016-10-26 09:56:40,040::__init__::530::jsonrpc.JsonRpcServer::(_handle_request) Calling 'VM.migrate' in bridge with {'params': {'tunneled': 'false', 'dstqemu': '10.35.161.161', 'autoConverge': 'true', 'src': 'seal08.qa.lab.tlv.redhat.com', 'enableGuestEvents': False, 'dst': 'virt-nested-vm14.scl.lab.tlv.redhat.com:54321', 'vmId': '6adec1d9-519a-4ca7-b3b6-bae6369777a8', 'abortOnError': 'true', 'compressed': 'true', 'method': 'online'}, 'vmID': '6adec1d9-519a-4ca7-b3b6-bae6369777a8'} jsonrpc.Executor/3::DEBUG::2016-10-26 09:56:40,041::API::540::vds::(migrate) {'tunneled': 'false', 'dstqemu': '10.35.161.161', 'autoConverge': 'true', 'src': 'seal08.qa.lab.tlv.redhat.com', 'enableGuestEvents': False, 'dst': 'virt-nested-vm14.scl.lab.tlv.redhat.com:54321', 'vmId': '6adec1d9-519a-4ca7-b3b6-bae6369777a8', 'abortOnError': 'true', 'compressed': 'true', 'method': 'online'}