Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1383746

Summary:	The SDKs can't use the 'All-Content' parameter
Product:	[oVirt] ovirt-engine	Reporter:	Juan Hernández <juan.hernandez>
Component:	RestAPI	Assignee:	Juan Hernández <juan.hernandez>
Status:	CLOSED WONTFIX	QA Contact:	Pavel Stehlik <pstehlik>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.0.5	CC:	bugs, oourfali
Target Milestone:	---	Flags:	sbonazzo: ovirt-4.2-
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-09-20 15:05:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Juan Hernández 2016-10-11 16:40:40 UTC

Currently the only way to use the 'All-Content' parameter is to use an HTTP header:

  GET /ovirt-engine/api/vms/123
  All-Content: true

This can't be expressed in the specification of the API, and can't be used in the SDKs, as they only support query parameters.

The API server should be changed to accept it as a query parameter:

  GET /ovirt-engine/api/vms/123?all_content=true

This should be documented in the specification of the API, and then all the SDKs will be able to use it.

Comment 1 Juan Hernández 2016-10-21 10:39:35 UTC

Version 4 of the SDKs have been modified so that they convert the 'all_content' query parameter into the 'All-Content' header:

  Python SDK:
  https://gerrit.ovirt.org/#/q/I5f4be9028d50a1571a938956d960d7c299400515

  Java SDK:
  https://gerrit.ovirt.org/#/q/I2b7be557957456cc834e2f22468bb8e8485e54f7

  Ruby SDK:
  https://gerrit.ovirt.org/#/q/I3c15fa5cc60a2c45406d4d892c68d1b6f54d38e1

This means that the SDKs will support the 'all_content' parameter without needing to modify the engine.

Anyhow, the engine should be modified to support both the 'all_content' query parameter and the 'All-Content' header, but I am re-targeting that to 4.1, as it isn't urgent.

Comment 2 Juan Hernández 2016-12-13 14:28:34 UTC

Re-targeting to 4.2, as the SDKs are fixed and the changes for the engine aren't ready.

Comment 3 Juan Hernández 2017-09-20 15:05:38 UTC

Not worth fixing at this point, may re-open in the future.