Description of problem:
Some resource agents' metadata do not conform to the xml schema.

It might seem the bug should have been filed againts resource agents. However, pacemaker provides metadata for lsb, systemd and service agents which do not conform either. Fence agents' metadata obtained from pacemaker do not conform either. Also various metadata defined and provided by pacemaker (stonithd, cib, cmrd, pengine) do not conform. Nagios agents metadata are the only one which are ok.

When fixing the agents / pacemaker it is very likely to find out the metadata schema needs to be updated and extended to support new features already included in metadata.

For now I filed the bug againts pacemaker. It can be cloned to other components if needed once investigated.


Version-Release number of selected component (if applicable):
pacemaker-1.1.15-10.el7
resource-agents-3.9.5-81.el7
fence-agents-all-4.0.11-27.el7


How reproducible:
always, easily


Steps to Reproduce:
Output from the validator is really long, considering the number of agents, so I only put the commands here and ommit the actual output.


For resource agents (I left out valid agents from the output):
# cd /usr/share/resource-agents
# for agent in `pcs resource list ocf: --nodesc`; do echo $agent; crm_resource --show-metadata $agent | xmllint --noout --valid --dtdvalid ra-api-1.dtd -; done

Agents with not valid metadata are:
ocf:heartbeat:portblock
ocf:openstack:nova-compute-wait
ocf:openstack:NovaEvacuate
ocf:pacemaker:remote


For lsb, service and systemd agents (most likely all agents in the given standard have the same errors):
# cd /usr/share/resource-agents
# for agent in `pcs resource list lsb: --nodesc`; do echo $agent; crm_resource --show-metadata $agent | xmllint --noout --valid --dtdvalid ra-api-1.dtd -; done
# for agent in `pcs resource list systemd: --nodesc`; do echo $agent; crm_resource --show-metadata $agent | xmllint --noout --valid --dtdvalid ra-api-1.dtd -; done
# for agent in `pcs resource list service: --nodesc`; do echo $agent; crm_resource --show-metadata $agent | xmllint --noout --valid --dtdvalid ra-api-1.dtd -; done
This shows not a single agent's metadata is valid.


For fence agents:
# cd /usr/share/resource-agents
# for agent in `pcs stonith list --nodesc`; do echo $agent; crm_resource --show-metadata stonith:$agent | xmllint --noout --valid --dtdvalid ra-api-1.dtd -; done
This shows not a single agent's metadata is valid.

Fence agents package however ships its own schema, let's try it:
# for agent in `pcs stonith list --nodesc`; do echo $agent; crm_resource --show-metadata stonith:$agent | xmllint --noout --relaxng /usr/share/cluster/relaxng/metadata.rng -; done
This again shows not a single agent's metadata is valid.
fence_apc
-:194: element action: Relax-NG validity error : Invalid attribute timeout for element action
-:195: element action: Relax-NG validity error : Invalid attribute timeout for element action
- fails to validate
{snip}
fence_xvm
-:5: element parameters: Relax-NG validity error : Did not expect element parameters there
- fails to validate

Original metadata provided by agents mostly conform, though:
# for agent in `pcs stonith list --nodesc`; do echo $agent; $agent -o metadata | xmllint --noout --relaxng /usr/share/cluster/relaxng/metadata.rng -; done
fence_apc
- validates
{snip}
fence_xvm
-:4: element parameters: Relax-NG validity error : Did not expect element parameters there
- fails to validate


Metadata defined in pacemaker:
# for agent in {cib,crmd,pengine,stonithd}; do echo $agent; /usr/libexec/pacemaker/$agent metadata | xmllint --noout --valid --dtdvalid ra-api-1.dtd -; done
This shows not a single agent's metadata is valid.


Actual results:
Metadata do not conform to the schema.


Expected results:
Metadata do conform to the schema.