Bug 1384517 - Snapshot description should be a required field for RHEVM provider
Summary: Snapshot description should be a required field for RHEVM provider
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.7.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: GA
: 5.8.0
Assignee: Boriso
QA Contact: Ilanit Stein
URL:
Whiteboard: rhev:snapshot
Depends On:
Blocks: 1396207
TreeView+ depends on / blocked
 
Reported: 2016-10-13 13:02 UTC by movciari
Modified: 2017-06-12 17:12 UTC (History)
6 users (show)

Fixed In Version: 5.8.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1396207 (view as bug list)
Environment:
Last Closed: 2017-06-12 17:12:14 UTC
Category: Bug
Cloudforms Team: RHEVM
Target Upstream Version:


Attachments (Terms of Use)

Description movciari 2016-10-13 13:02:40 UTC
Description of problem:
In RHEVM, we don't have snapshot names, and description is required.
in CFME, when you're creating a snapshot for VM provided by RHEVM, it lets you submit the create snapshot form with empty description, and it says 'Create Snapshot for VM and Instance "test_vm" was started', but this will fail without showing any error to user, because RHEVM can't create a snapshot without descritpion

Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1. have a VM in RHEVM provider
2. try to create snapshot of that VM without description
3.

Actual results:
lets you submit form, then fails silently

Expected results:
shouldn't let you submit form, snapshot description should be required

Additional info:

Comment 3 CFME Bot 2016-11-17 15:11:14 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/06c8bc3d189fc6277cd4933bb274e02d654badb0

commit 06c8bc3d189fc6277cd4933bb274e02d654badb0
Author:     borod108 <bodnopoz>
AuthorDate: Tue Nov 15 14:52:46 2016 +0200
Commit:     borod108 <bodnopoz>
CommitDate: Thu Nov 17 11:09:29 2016 +0200

    Require a description when creating Snapshot
    
    When creating a snapshot on RHV one has to write a description else
    the operation will fail.
    So one should not be able to start the "create snapshot" operation
    without writing the description.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1384517

 app/controllers/vm_common.rb                       | 26 ++++++++++++++--------
 .../redhat/infra_manager/vm/operations/snapshot.rb |  4 ++++
 2 files changed, 21 insertions(+), 9 deletions(-)

Comment 5 Ilanit Stein 2017-04-04 10:12:11 UTC
Verified on CFME-5.8.0.8/RHV-4.0.7.

Indeed not possible to add snapshot, with leaving description empty.


Note You need to log in before you can comment on or make changes to this bug.