Bug 1384753 – Support openshift_builddefaults_git_no_proxy with ansible installer to enable no_proxy setting for git cloning

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1384753 - Support openshift_builddefaults_git_no_proxy with ansible installer to enable no_proxy setting for git cloning

Summary:	Support openshift_builddefaults_git_no_proxy with ansible installer to enable...

Status:	CLOSED ERRATA

Aliases:	None

Product:	OpenShift Container Platform
Classification:	Red Hat
Component:	Installer (Show other bugs)
Sub Component:
Version:	3.3.0
Hardware:	x86_64 Linux

Priority	unspecified Severity medium
Target Milestone:	---
Target Release:	---
Assigned To:	Ben Parees
QA Contact:	Gan Huang
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:	1384750
Blocks:
	Show dependency tree / graph

Reported:	2016-10-14 00:51 EDT by Kenjiro Nakayama
Modified:	2017-07-24 10 EDT (History)
CC List:	5 users (show)

See Also:
Fixed In Version:
Doc Type:	Enhancement
Doc Text:	Feature: gitNoProxy default value for builds can now be set explicitly via the installer. Reason: Previously the value was inherited from the no_proxy settings for the installer which was insufficiently configurable. Result: The build default gitNoProxy value can now be directly controlled by the openshift_builddefaults_git_no_proxy setting.
Story Points:	---
Clone Of:
Environment:
Last Closed:	2017-04-12 14:47:52 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2017:0903	normal	SHIPPED_LIVE	OpenShift Container Platform atomic-openshift-utils bug fix and enhancement	2017-04-12 18:45:42 EDT

Groups: None (edit)

Description Kenjiro Nakayama 2016-10-14 00:51:13 EDT

Description of problem:
===

  Support openshift_builddefaults_git_no_proxy with ansible installer to enable no_proxy setting for git cloning.
  ansible installer should support no_proxy setting for git clone in builder which has been implemented in https://github.com/openshift/origin/pull/10902 in the same way as openshift_builddefaults_http(s)_proxy

Version-Release number of selected component (if applicable):
===

  OCP 3.3

Comment 1 Scott Dodson 2016-10-18 11:10:15 EDT

This option only exists in 3.4 BTW.

Comment 2 Scott Dodson 2017-02-09 20:42:47 EST

This is now set to match openshift_no_proxy value or if openshift_builddefaults_git_no_proxy is defined its value is preferred.

Comment 4 Gan Huang 2017-02-10 04:33:43 EST

Verified with openshift-ansible-3.5.6-1.git.0.5e6099d.el7.noarch.rpm

1. openshift_builddefaults_git_https_proxy is not defined, the value of gitNoProxy inherits openshift_no_proxy value

2. gitNoProxy is set correctly if openshift_builddefaults_git_https_proxy is defined.

Comment 5 Ben Parees 2017-02-10 10:28:25 EST

I assume by "openshift_builddefaults_git_https_proxy" you meant "openshift_builddefaults_git_no_proxy", correct?

Comment 6 Gan Huang 2017-02-11 09:13:17 EST

(In reply to Ben Parees from comment #5)
> I assume by "openshift_builddefaults_git_https_proxy" you meant
> "openshift_builddefaults_git_no_proxy", correct?

Yes, my bad. Thanks for pointing it out. :)

Comment 8 errata-xmlrpc 2017-04-12 14:47:52 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:0903

Note You need to log in before you can comment on or make changes to this bug.