Description of problem: === - Installer doesn't support to update template to point to non redhat registry. - Configuration "oreg_url" + "openshift_examples_modify_imagestreams" will modify imageStream, but registry-console or other template images are not covered them. Version-Release number of selected component (if applicable): === - OCP 3.3 installer How reproducible: === Steps to Reproduce: 1. Set "oreg_url" and "openshift_examples_modify_imagestreams". 2. Run installer Actual results: === - Some images like registry-console still try to be imported from registry.access.redhat.com Expected results: === - They should cover all image imort during the installation to change the registry address.
Proposed fix: https://github.com/openshift/openshift-ansible/pull/2573
Verify this bug with openshift-ansible-3.4.13-1.git.0.ff1d588.el7.noarch.rpm With oreg_url=x.com/openshift3/ose-${component}:${version} and openshift_examples_modify_imagestreams=true setting in ansible inventory file, openshift-ansible will update logging-deployer.yaml, registry-console.yaml and metrics-deployer.yaml as expected: TASK [openshift_hosted_templates : Modify registry paths if registry_url is not registry.access.redhat.com] *** Friday 28 October 2016 03:20:59 +0000 (0:00:00.329) 0:08:05.601 ******** changed: [104.154.95.135] => {"changed": true, "cmd": "find /usr/share/openshift/hosted -type f | xargs -n 1 sed -i 's|registry.access.redhat.com|x.com|g'", "delta": "0:00:00.014007", "end": "2016-10-27 23:21:00.987094", "rc": 0, "start": "2016-10-27 23:21:00.973087", "stderr": "", "stdout": "", "stdout_lines": [], "warnings": []} Metrics, logging and registry-console were both deployed with IMAGE_PREFIX=x.com/openshift3/
mmm... So, "openshift_examples_modify_imagestreams" option will modify the pointer in both imageStream and template? I feel strange that "openshift_examples_*modify_imagestreams*" changes the *template*. Andrew, I know your PR has already accepted, but please let me confirm if you will change it (introduce new option name or another option for the template separately) or not. We are updating the doc https://bugzilla.redhat.com/show_bug.cgi?id=1374890 right now.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:0066
(In reply to Kenjiro Nakayama from comment #4) > mmm... So, "openshift_examples_modify_imagestreams" option will modify the > pointer in both imageStream and template? I feel strange that > "openshift_examples_*modify_imagestreams*" changes the *template*. > > Andrew, I know your PR has already accepted, but please let me confirm if > you will change it (introduce new option name or another option for the > template separately) or not. We are updating the doc > https://bugzilla.redhat.com/show_bug.cgi?id=1374890 right now. Independent of the variable name, do you think it's the right thing to modify both at the same time? We can assign a new variable and use defaults. I'd like to understand if you think it's the right thing to do to modify both image streams and templates though.
No, imageStream and template should be modified with different variables and time. The templates which have a pointer to "registry.access.redhat.com" are only infra templates like metrics, logging. Unless they use disconnected env, most of the users want to use them from registry.access.redhat.com. While, imageStreams include application images which users may often want to customize and point to their own repository rather than registry.access.redhat.com. So, I think the variables should be separated and modify it with different time.