Spec URL: https://chandankumar.fedorapeople.org/python-pykwalify.spec SRPM URL: https://chandankumar.fedorapeople.org/python-pykwalify-1.5.1-1.fc24.src.rpm Description: It is a YAML/JSON validation library. This framework is a port with alot added functionality of the java version of the framework kwalify that can be found at: http://www.kuwata-lab.com/kwalify/ Fedora Account System Username: chandankumar Successful Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16086837
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= 1) Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ==> We have only PyYAML and not python-PyYAML, fix Requires: this for python2-pykwalify Do not write any versions for Requires: lines. Packages in that particular release should resolve dependencies. 2) Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/doc/python2-pykwalify/README.md See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles ==> Remove tests/files/README.md from both the packages, tests files are not getting installed so don't install its README.md 3) Remove egg-info in %prep end section as below to fix rpmlint errors. rm -rf *.egg-info ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "JSON MIT/X11 (BSD like)", "Unknown or generated". 110 files have unknown license. Detailed output of licensecheck in /home/parag/Downloads/1384917-python-pykwalify/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-pykwalify , python3-pykwalify [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.2.21 starting (python version = 3.5.2)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata Mock Version: 1.2.21 INFO: Mock Version: 1.2.21 Finish: chroot init INFO: installing package(s): /home/parag/Downloads/1384917-python-pykwalify/results/python2-pykwalify-1.5.1-1.fc26.noarch.rpm /home/parag/Downloads/1384917-python-pykwalify/results/python3-pykwalify-1.5.1-1.fc26.noarch.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 26 --disableplugin=local --setopt=deltarpm=false install /home/parag/Downloads/1384917-python-pykwalify/results/python2-pykwalify-1.5.1-1.fc26.noarch.rpm /home/parag/Downloads/1384917-python-pykwalify/results/python3-pykwalify-1.5.1-1.fc26.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: python2-pykwalify-1.5.1-1.fc26.noarch.rpm python3-pykwalify-1.5.1-1.fc26.noarch.rpm python-pykwalify-1.5.1-1.fc26.src.rpm python2-pykwalify.noarch: W: spelling-error Summary(en_US) cli -> cl, clii, clip python2-pykwalify.noarch: W: spelling-error %description -l en_US alot -> a lot, alto, slot python2-pykwalify.noarch: W: spelling-error %description -l en_US kwalify -> qualify python2-pykwalify.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/pykwalify-1.5.1-py2.7.egg-info/PKG-INFO python2-pykwalify.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/pykwalify-1.5.1-py2.7.egg-info/entry_points.txt python2-pykwalify.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/pykwalify-1.5.1-py2.7.egg-info/top_level.txt python2-pykwalify.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/pykwalify-1.5.1-py2.7.egg-info/requires.txt python2-pykwalify.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/pykwalify-1.5.1-py2.7.egg-info/dependency_links.txt python2-pykwalify.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/pykwalify-1.5.1-py2.7.egg-info/SOURCES.txt python2-pykwalify.noarch: W: no-manual-page-for-binary python2-pykwalify python3-pykwalify.noarch: W: spelling-error Summary(en_US) cli -> cl, clii, clip python3-pykwalify.noarch: W: spelling-error %description -l en_US alot -> a lot, alto, slot python3-pykwalify.noarch: W: spelling-error %description -l en_US kwalify -> qualify python3-pykwalify.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/pykwalify-1.5.1-py3.5.egg-info/SOURCES.txt python3-pykwalify.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/pykwalify-1.5.1-py3.5.egg-info/dependency_links.txt python3-pykwalify.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/pykwalify-1.5.1-py3.5.egg-info/PKG-INFO python3-pykwalify.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/pykwalify-1.5.1-py3.5.egg-info/entry_points.txt python3-pykwalify.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/pykwalify-1.5.1-py3.5.egg-info/top_level.txt python3-pykwalify.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/pykwalify-1.5.1-py3.5.egg-info/requires.txt python3-pykwalify.noarch: W: no-manual-page-for-binary pykwalify python3-pykwalify.noarch: W: no-manual-page-for-binary python3-pykwalify python-pykwalify.src: W: spelling-error Summary(en_US) cli -> cl, clii, clip python-pykwalify.src: W: spelling-error %description -l en_US alot -> a lot, alto, slot python-pykwalify.src: W: spelling-error %description -l en_US kwalify -> qualify 3 packages and 0 specfiles checked; 12 errors, 12 warnings. Requires -------- python2-pykwalify (rpmlib, GLIBC filtered): /usr/bin/python2 python(abi) python-PyYAML python-dateutil python-docopt python-setuptools python3-pykwalify (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3-PyYAML python3-dateutil python3-docopt python3-setuptools Provides -------- python2-pykwalify: python-pykwalify python2-pykwalify python2.7dist(pykwalify) python2dist(pykwalify) python3-pykwalify: python3-pykwalify python3.5dist(pykwalify) python3dist(pykwalify) Source checksums ---------------- https://files.pythonhosted.org/packages/source/p/pykwalify/pykwalify-1.5.1.tar.gz : CHECKSUM(SHA256) this package : 4a384b1034166107a22bd371233a20ab3dd729b5bd34f6b0d053af18cd234103 CHECKSUM(SHA256) upstream package : 4a384b1034166107a22bd371233a20ab3dd729b5bd34f6b0d053af18cd234103 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1384917 -m fedora-rawhide-x86_64
Hello Parag, Thanks for the review. Here is the updated SPEC: https://chandankumar.fedorapeople.org/python-pykwalify.spec SRPM: https://chandankumar.fedorapeople.org/python-pykwalify-1.5.1-2.fc24.src.rpm Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16104193 Thanks, Chandan Kumar
Looks good. APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pykwalify
python-pykwalify-1.5.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-82627c71d1
python-pykwalify-1.5.1-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-186d414a86
python-pykwalify-1.5.1-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-dcca303252
Let's close this. These updates are there in testing repository for more than an year now. Package maintainer should take some action on this update.
python-pykwalify-1.7.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-7dae6fb5b6
python-pykwalify-1.7.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-7dae6fb5b6
python-pykwalify-1.7.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.