Since this commit: https://github.com/rdo-packages/neutron-distgit/commit/8e094ca611519914829fcfb4bba32817126efc7c there is no availability of installing networking-vsphere through rpm package. Package python-networking-vsphere should be added to RDO project. link to a project: https://github.com/openstack/networking-vsphere I would like to contribute rpm spec to this project. Am I right, that my steps are: 1. Submit Package review ticket at bugzilla 2. Submit review request at rdoinfo project repo with adding this package to rdo.yml with "under-review" state. 3. Wait creation of rdo-project/<package>-distgit repo 4. Submit review request at <package>-distgit repo with specfile 5. Wait until merge 6. Submit review request at rdoinfo removing "under-review" and adding related openstack versions Is it okay, or there's a mistake in understanding?
You should start by packaging latest tagged release and submit spec + src.rpm in this review. You're describing the upcoming process but we don't have yet the machinery in gerrit to enable it yet.
Hi, I've prepared and tested specfile: https://github.com/odivlad/networking-vsphere-distgit/blob/rpm-master/python-networking-vsphere.spec SRPM: https://github.com/odivlad/networking-vsphere-distgit/blob/rpm-master/python-networking-vsphere-2.0.1-0.20161021101357.0bfa115.el7.centos.src.rpm?raw=true Upstream repo: https://github.com/openstack/networking-vsphere Review in info project: https://review.rdoproject.org/r/#/c/3421/
Created attachment 1218886 [details] source rpm
(In reply to Haïkel Guémar from comment #1) > You should start by packaging latest tagged release and submit spec + > src.rpm in this review. > > You're describing the upcoming process but we don't have yet the machinery > in gerrit to enable it yet. Hello Haïkel, I've updated specfile and src rpm, so could you please take a look at them and on review for addition of package?
Spec URL: https://raw.githubusercontent.com/odivlad/networking-vsphere-distgit/rpm-master/python-networking-vsphere.spec SRPM URL: https://github.com/odivlad/networking-vsphere-distgit/raw/rpm-master/python-networking-vsphere-2.0.0-1.test.el7.centos.src.rpm Description: A set of Neutron drivers and agents to manage vSphere clusters.
$ licensecheck -r . ./tools/pretty_tox_serial.sh: *No copyright* UNKNOWN ./tools/pretty_tox.sh: *No copyright* UNKNOWN ./setup.py: Apache (v2.0) GENERATED FILE ./networking_vsphere/utils/vim_util.py: Apache (v2.0) ./networking_vsphere/utils/vim_session.py: Apache (v2.0) ./networking_vsphere/utils/spec_builder.py: Apache (v2.0) ./networking_vsphere/utils/security_group_utils.py: Apache (v2.0) ./networking_vsphere/utils/rpc_translator.py: Apache (v2.0) ./networking_vsphere/utils/resource_util.py: Apache (v2.0) ./networking_vsphere/utils/ovs_bridge_util.py: Apache (v2.0) ./networking_vsphere/utils/network_util.py: Apache (v2.0) ./networking_vsphere/utils/error_util.py: Apache (v2.0) ./networking_vsphere/utils/dvs_util.py: Apache (v2.0) ./networking_vsphere/utils/db.py: Apache (v2.0) ./networking_vsphere/utils/common_util.py: Apache (v2.0) ./networking_vsphere/utils/cache.py: Apache (v2.0) ./networking_vsphere/tests/unit/utils/test_vim_util.py: Apache (v2.0) ./networking_vsphere/tests/unit/utils/test_session.py: Apache (v2.0) ./networking_vsphere/tests/unit/utils/test_security_group_utils.py: Apache (v2.0) ./networking_vsphere/tests/unit/utils/test_resource_util.py: Apache (v2.0) ./networking_vsphere/tests/unit/utils/test_ovs_bridge_util.py: Apache (v2.0) ./networking_vsphere/tests/unit/utils/test_network_util.py: Apache (v2.0) ./networking_vsphere/tests/unit/utils/test_error_util.py: Apache (v2.0) ./networking_vsphere/tests/unit/utils/test_dvs_util.py: Apache (v2.0) ./networking_vsphere/tests/unit/utils/test_cache.py: Apache (v2.0) ./networking_vsphere/tests/unit/utils/stubs.py: Apache (v2.0) ./networking_vsphere/tests/unit/utils/fake_vmware_api.py: Apache (v2.0) ./networking_vsphere/tests/unit/nova/virt/vmwareapi/test_ovsvapp_vmops.py: Apache (v2.0) ./networking_vsphere/tests/unit/nova/virt/vmwareapi/test_ovsvapp_vc_driver.py: Apache (v2.0) ./networking_vsphere/tests/unit/neutronclient/test_cli_ovsvapp_mitigated_cluster.py: Apache (v2.0) ./networking_vsphere/tests/unit/neutronclient/test_cli_ovsvapp_cluster.py: Apache (v2.0) ./networking_vsphere/tests/unit/neutronclient/test_cli20.py: *No copyright* Apache (v2.0) ./networking_vsphere/tests/unit/monitor/test_ovsvapp_monitor.py: Apache (v2.0) ./networking_vsphere/tests/unit/ml2/test_ovsvapp_rpc.py: Apache (v2.0) ./networking_vsphere/tests/unit/ml2/test_ovsvapp_mech_driver.py: Apache (v2.0) ./networking_vsphere/tests/unit/ml2/test_ovsvapp_db.py: Apache (v2.0) ./networking_vsphere/tests/unit/ml2/test_dvs_mechanism_driver.py: Apache (v2.0) ./networking_vsphere/tests/unit/extensions/test_ovsvapp_mitigated_cluster_resource.py: Apache (v2.0) ./networking_vsphere/tests/unit/extensions/test_ovsvapp_cluster_resource.py: Apache (v2.0) ./networking_vsphere/tests/unit/drivers/test_vc_driver.py: Apache (v2.0) ./networking_vsphere/tests/unit/drivers/test_ovs_firewall.py: Apache (v2.0) ./networking_vsphere/tests/unit/drivers/test_manager.py: Apache (v2.0) ./networking_vsphere/tests/unit/drivers/test_dvs_driver.py: Apache (v2.0) ./networking_vsphere/tests/unit/drivers/test_driver.py: Apache (v2.0) ./networking_vsphere/tests/unit/drivers/test_base_manager.py: Apache (v2.0) ./networking_vsphere/tests/unit/drivers/fake_manager.py: Apache (v2.0) ./networking_vsphere/tests/unit/drivers/fake_driver.py: Apache (v2.0) ./networking_vsphere/tests/unit/common/test_utils.py: Apache (v2.0) ./networking_vsphere/tests/unit/common/test_model.py: Apache (v2.0) ./networking_vsphere/tests/unit/agent/test_ovsvapp_sg_agent.py: Apache (v2.0) ./networking_vsphere/tests/unit/agent/test_ovsvapp_agent.py: Apache (v2.0) ./networking_vsphere/tests/unit/agent/test_dvs_neutron_agent.py: Apache (v2.0) ./networking_vsphere/tests/unit/agent/test_agent.py: Apache (v2.0) ./networking_vsphere/tests/unit/agent/firewalls/test_vcenter_firewall.py: Apache (v2.0) ./networking_vsphere/tests/tempest/config.py: Apache (v2.0) ./networking_vsphere/tests/scenario/test_vmotion_basic_ops_esx.py: Apache (v2.0) ./networking_vsphere/tests/scenario/test_security_groups_basic_ops_esx.py: Apache (v2.0) ./networking_vsphere/tests/scenario/test_network_basic_ops_esx.py: Apache (v2.0) ./networking_vsphere/tests/scenario/manager.py: Apache (v2.0) ./networking_vsphere/tests/scenario/admin/test_vm_shared_network.py: Apache (v2.0) ./networking_vsphere/tests/base.py: Apache (v2.0) ./networking_vsphere/services/ovsvapp_plugin.py: Apache (v2.0) ./networking_vsphere/services/__init__.py: Apache (v2.0) ./networking_vsphere/service.py: Apache (v2.0) ./networking_vsphere/nova/virt/vmwareapi/vif.py: Apache (v2.0) ./networking_vsphere/nova/virt/vmwareapi/ovsvapp_vmops.py: Apache (v2.0) ./networking_vsphere/nova/virt/vmwareapi/ovsvapp_vc_driver.py: Apache (v2.0) ./networking_vsphere/neutronclient/_ovsvapp_mitigated_cluster.py: Apache (v2.0) ./networking_vsphere/neutronclient/_ovsvapp_cluster.py: Apache (v2.0) ./networking_vsphere/monitor/ovsvapp_monitor.py: Apache (v2.0) ./networking_vsphere/monitor/ovsvapp-agent-monitor.sh: Apache (v2.0) ./networking_vsphere/monitor/monitor.py: Apache (v2.0) ./networking_vsphere/ml2/ovsvapp_rpc.py: Apache (v2.0) ./networking_vsphere/ml2/ovsvapp_mech_driver.py: Apache (v2.0) ./networking_vsphere/ml2/dvs_mechanism_driver.py: Apache (v2.0) ./networking_vsphere/extensions/ovsvapp_mitigated_cluster.py: Apache (v2.0) ./networking_vsphere/extensions/ovsvapp_cluster.py: Apache (v2.0) ./networking_vsphere/extensions/__init__.py: Apache (v2.0) ./networking_vsphere/drivers/vc_driver.py: Apache (v2.0) ./networking_vsphere/drivers/ovs_firewall.py: Apache (v2.0) ./networking_vsphere/drivers/manager.py: Apache (v2.0) ./networking_vsphere/drivers/dvs_driver.py: Apache (v2.0) ./networking_vsphere/drivers/driver.py: Apache (v2.0) ./networking_vsphere/drivers/base_manager.py: Apache (v2.0) ./networking_vsphere/db/ovsvapp_models.py: Apache (v2.0) ./networking_vsphere/db/ovsvapp_db.py: Apache (v2.0) ./networking_vsphere/db/migration/cli.py: Apache (v2.0) ./networking_vsphere/db/migration/alembic_migrations/versions/start_ovsvapp_migration.py: Apache (v2.0) ./networking_vsphere/db/migration/alembic_migrations/versions/HEAD: *No copyright* UNKNOWN ./networking_vsphere/db/migration/alembic_migrations/versions/4f77522fea53_ovsvapp_clusters.py: Apache (v2.0) ./networking_vsphere/db/migration/alembic_migrations/versions/3f77522fea53_ovsvapp_cluster_vni_allocations.py: Apache (v2.0) ./networking_vsphere/db/migration/alembic_migrations/env.py: Apache (v2.0) ./networking_vsphere/db/migration/alembic_migrations/README: *No copyright* UNKNOWN ./networking_vsphere/common/vmware_conf.py: Apache (v2.0) ./networking_vsphere/common/utils.py: Apache (v2.0) ./networking_vsphere/common/model.py: Apache (v2.0) ./networking_vsphere/common/exceptions.py: Apache (v2.0) ./networking_vsphere/common/error.py: Apache (v2.0) ./networking_vsphere/common/dvs_agent_rpc_api.py: Apache (v2.0) ./networking_vsphere/common/constants.py: Apache (v2.0) ./networking_vsphere/common/config.py: Apache (v2.0) ./networking_vsphere/agent/ovsvapp_sg_agent.py: Apache (v2.0) ./networking_vsphere/agent/ovsvapp_agent.py: Apache (v2.0) ./networking_vsphere/agent/firewalls/vcenter_firewall.py: Apache (v2.0) ./networking_vsphere/agent/firewalls/noop_firewall.py: Apache (v2.0) ./networking_vsphere/agent/firewalls/dvs_securitygroup_rpc.py: Apache (v2.0) ./networking_vsphere/agent/dvs_neutron_agent.py: Apache (v2.0) ./networking_vsphere/agent/agent.py: Apache (v2.0) ./networking_vsphere/agent/__init__.py: Apache (v2.0) ./networking_vsphere/_i18n.py: Apache (v2.0) ./networking_vsphere/__init__.py: *No copyright* Apache (v2.0) ./etc/nginx-default: *No copyright* UNKNOWN ./doc/source/conf.py: Apache (v2.0) ./devstack/settings: *No copyright* UNKNOWN ./devstack/plugin.sh: *No copyright* UNKNOWN ./bin/neutron-ovsvapp-agent-monitor: *No copyright* GENERATED FILE ./bin/neutron-ovsvapp-agent: *No copyright* GENERATED FILE ./LICENSE: *No copyright* GENERATED FILE Everything looks ok, using the Apache 2.0 License.
Can I do something else for package to be approved?
From the reviewed spec file: SPEC: https://raw.githubusercontent.com/rdo-packages/networking-vsphere-distgit/rpm-master/python-networking-vsphere.spec SRPM: http://46.231.132.68:8080/v1/AUTH_b50e80d3969f441a8b7b1fe831003e0a/rdoartifacts/10/3910/4/gate/DLRN-rpmbuild/Zf58402d3fd8143e7ae6d1255fcb5e1c8/artifacts/centos/repos/cd/7f/cd7f4ce144614464e538c5544d1277d08d55d707_dev/python-networking-vsphere-2.0.1-0.20161207192146.cd7f4ce.el7.centos.src.rpm Please note the srpm is DLRN-generated, so some minor differences with the spec are expected (version and release set, changelog removed).
Are you still working on it? If you are ping me and block RDO-PIKE tracker.
Hi, no, I don't work on it. I've done my local changes and I use self-built rpm. But I'm sure, approval for a package should be done. Just, maybe I'm not the best person to own a package.
Closing as no volunteer and interest in package and ocata released long ago for which it was targetted.