Bug 1386606 - [z-stream clone - 3.6.10] Introduce a 'force' flag for updating a storage server connection
Summary: [z-stream clone - 3.6.10] Introduce a 'force' flag for updating a storage ser...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.6.7
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-3.6.10
: ---
Assignee: Daniel Erez
QA Contact: Natalie Gavrielov
URL:
Whiteboard:
Depends On: 1379771
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-19 09:45 UTC by rhev-integ
Modified: 2017-01-17 18:04 UTC (History)
14 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
This release introduces a 'force' flag, which can be used to update a storage server connection regardless of the associated storage domain status (allowing updates even when the storage domain is not in Maintenance mode). For example: PUT /ovirt-engine/api/storageconnections/123;force=true
Clone Of: 1379771
Environment:
Last Closed: 2017-01-17 18:04:57 UTC
oVirt Team: Storage
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2017:0108 0 normal SHIPPED_LIVE Red Hat Enterprise Virtualization Manager 3.6.10 2017-01-17 22:48:34 UTC
oVirt gerrit 64531 0 None None None 2016-10-19 09:45:49 UTC

Comment 3 Natalie Gavrielov 2016-11-20 14:40:43 UTC
Moving back to assigned, seems it's not working (comment 2)

Comment 6 Raz Tamir 2016-11-30 16:52:23 UTC
Allon,
I tried to use force=true and still get the same response:
<fault>
    <reason>Operation Failed</reason>
    <detail>[Cannot edit Storage Connection. The data domains new_netapp should be in maintenance or unattached.]</detail>
</fault>

From the engine.log:

2016-11-30 18:35:27,601 WARN  [org.ovirt.engine.core.bll.storage.UpdateStorageServerConnectionCommand] (ajp-/127.0.0.1:8702-4) [38bac0c5] CanDoAction of action 'UpdateStorageServerConnection' failed for user admin@internal. Reasons: VAR__ACTION__UPDATE,VAR__TYPE__STORAGE__CONNECTION,$domainNames new_netapp,ACTION_TYPE_FAILED_UNSUPPORTED_ACTION_DOMAIN_MUST_BE_IN_MAINTENANCE_OR_UNATTACHED
2016-11-30 18:35:27,602 INFO  [org.ovirt.engine.core.bll.storage.UpdateStorageServerConnectionCommand] (ajp-/127.0.0.1:8702-4) [38bac0c5] Lock freed to object 'EngineLock:{exclusiveLocks='[10.35.110.11:/RHV_NFS/mburman/3_6_netapp_str=<STORAGE_CONNECTION, ACTION_TYPE_FAILED_OBJECT_LOCKED>, f610bebc-4fff-4b45-8dc7-7031f7615720=<STORAGE_CONNECTION, ACTION_TYPE_FAILED_OBJECT_LOCKED>, 1f9b3223-fdb3-4f5b-9cc3-b4a4f143cc10=<STORAGE, ACTION_TYPE_FAILED_OBJECT_LOCKED>]', sharedLocks='null'}'
2016-11-30 18:35:27,610 ERROR [org.ovirt.engine.api.restapi.resource.AbstractBackendResource] (ajp-/127.0.0.1:8702-4) [] Operation Failed: [Cannot edit Storage Connection. The data domains new_netapp should be in maintenance or unattached.]

I also verified this on 4.1 and it works with '?force' only without the '?force=true'

Comment 7 Daniel Erez 2016-12-06 10:29:02 UTC
(In reply to Raz Tamir from comment #6)
> Allon,
> I tried to use force=true and still get the same response:
> <fault>
>     <reason>Operation Failed</reason>
>     <detail>[Cannot edit Storage Connection. The data domains new_netapp
> should be in maintenance or unattached.]</detail>
> </fault>
> 
> From the engine.log:
> 
> 2016-11-30 18:35:27,601 WARN 
> [org.ovirt.engine.core.bll.storage.UpdateStorageServerConnectionCommand]
> (ajp-/127.0.0.1:8702-4) [38bac0c5] CanDoAction of action
> 'UpdateStorageServerConnection' failed for user admin@internal. Reasons:
> VAR__ACTION__UPDATE,VAR__TYPE__STORAGE__CONNECTION,$domainNames
> new_netapp,
> ACTION_TYPE_FAILED_UNSUPPORTED_ACTION_DOMAIN_MUST_BE_IN_MAINTENANCE_OR_UNATTA
> CHED
> 2016-11-30 18:35:27,602 INFO 
> [org.ovirt.engine.core.bll.storage.UpdateStorageServerConnectionCommand]
> (ajp-/127.0.0.1:8702-4) [38bac0c5] Lock freed to object
> 'EngineLock:{exclusiveLocks='[10.35.110.11:/RHV_NFS/mburman/
> 3_6_netapp_str=<STORAGE_CONNECTION, ACTION_TYPE_FAILED_OBJECT_LOCKED>,
> f610bebc-4fff-4b45-8dc7-7031f7615720=<STORAGE_CONNECTION,
> ACTION_TYPE_FAILED_OBJECT_LOCKED>,
> 1f9b3223-fdb3-4f5b-9cc3-b4a4f143cc10=<STORAGE,
> ACTION_TYPE_FAILED_OBJECT_LOCKED>]', sharedLocks='null'}'
> 2016-11-30 18:35:27,610 ERROR
> [org.ovirt.engine.api.restapi.resource.AbstractBackendResource]
> (ajp-/127.0.0.1:8702-4) [] Operation Failed: [Cannot edit Storage
> Connection. The data domains new_netapp should be in maintenance or
> unattached.]
> 
> I also verified this on 4.1 and it works with '?force' only without the
> '?force=true'

In 3.6 we've used matrix parameters rather than query parameters. I.e. you should test the request by adding ';force=true'

Comment 8 Raz Tamir 2016-12-07 13:40:23 UTC
Verified on 3.6.10-0.1.el6

Comment 10 errata-xmlrpc 2017-01-17 18:04:57 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2017-0108.html


Note You need to log in before you can comment on or make changes to this bug.