Bug 1386610 - [z-stream clone - 4.0.6] Introduce a 'force' flag for updating a storage server connection
Summary: [z-stream clone - 4.0.6] Introduce a 'force' flag for updating a storage serv...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.6.7
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.0.7
: ---
Assignee: Daniel Erez
QA Contact: Natalie Gavrielov
URL:
Whiteboard:
Depends On: 1379771
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-19 09:50 UTC by rhev-integ
Modified: 2017-03-16 15:29 UTC (History)
14 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
This release introduces a 'force' flag, which can be used to update a storage server connection regardless of the associated storage domain status (allowing updates even when the storage domain is not in Maintenance mode). For example: PUT /ovirt-engine/api/storageconnections/123;force=true
Clone Of: 1379771
Environment:
Last Closed: 2017-03-16 15:29:22 UTC
oVirt Team: Storage
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:0542 0 normal SHIPPED_LIVE Red Hat Virtualization Manager 4.0.7 2017-03-16 19:25:04 UTC
oVirt gerrit 64892 0 None None None 2016-11-07 10:03:06 UTC

Comment 1 Allon Mureinik 2016-11-07 10:03:06 UTC 
Daniel - the engine patch in the 4.0 branch seems to be merged. Is there a pending API patch, or can this be moved to MODIFIED?
Comment 2 Daniel Erez 2016-11-07 10:14:11 UTC 
(In reply to Allon Mureinik from comment #1)
> Daniel - the engine patch in the 4.0 branch seems to be merged. Is there a
> pending API patch, or can this be moved to MODIFIED?

Can be moved.
Comment 7 Raz Tamir 2016-11-30 17:03:43 UTC 
Allon,
I tried to use ?force=true and still get the same response:
<fault>
    <detail>[]</detail>
    <reason>Operation Failed</reason>
</fault>

From the engine.log:

2016-11-30 19:02:10,030 INFO  [org.ovirt.engine.core.bll.storage.connection.UpdateStorageServerConnectionCommand] (default task-25) [2700eb37] Lock Acquired to object 'EngineLock:{exclusiveLocks='[64025f2c-8e50-4b1d-97cc-d2fd01cd804c=<STORAGE, ACTION_TYPE_FAILED_OBJECT_LOCKED>, 10.35.110.11:/Storage_NFS/storage_local_ge3_nfs_1=<STORAGE_CONNECTION, ACTION_TYPE_FAILED_OBJECT_LOCKED>, b8cb70fb-e3b1-4593-b4c1-80552ee1718b=<STORAGE_CONNECTION, ACTION_TYPE_FAILED_OBJECT_LOCKED>]', sharedLocks='null'}'
2016-11-30 19:02:10,039 WARN  [org.ovirt.engine.core.bll.storage.connection.UpdateStorageServerConnectionCommand] (default task-25) [2700eb37] Validation of action 'UpdateStorageServerConnection' failed for user admin@internal-authz. Reasons: VAR__ACTION__UPDATE,VAR__TYPE__STORAGE__CONNECTION
2016-11-30 19:02:10,039 INFO  [org.ovirt.engine.core.bll.storage.connection.UpdateStorageServerConnectionCommand] (default task-25) [2700eb37] Lock freed to object 'EngineLock:{exclusiveLocks='[64025f2c-8e50-4b1d-97cc-d2fd01cd804c=<STORAGE, ACTION_TYPE_FAILED_OBJECT_LOCKED>, 10.35.110.11:/Storage_NFS/storage_local_ge3_nfs_1=<STORAGE_CONNECTION, ACTION_TYPE_FAILED_OBJECT_LOCKED>, b8cb70fb-e3b1-4593-b4c1-80552ee1718b=<STORAGE_CONNECTION, ACTION_TYPE_FAILED_OBJECT_LOCKED>]', sharedLocks='null'}'
2016-11-30 19:02:10,049 ERROR [org.ovirt.engine.api.restapi.resource.AbstractBackendResource] (default task-25) [] Operation Failed: []
Comment 8 Daniel Erez 2016-12-08 09:06:20 UTC 
After investigating with the QE: working as expected on block domains, the failure is only on file domains in 4.0.x. Fixed by: https://gerrit.ovirt.org/#/c/67971/
Comment 9 Natalie Gavrielov 2017-02-07 18:35:26 UTC 
Performed scenario described in comment 3 along with the change in comment 4: ?force=true
Also made sure that information displayed in the UI changes accordingly (shows NFS version V4)   

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<storage_connection href="/ovirt-engine/api/storageconnections/a9e2a311-998a-4eb8-a29b-6dec88473802" id="a9e2a311-998a-4eb8-a29b-6dec88473802">
    <address>10.35.110.11</address>
    <nfs_version>v4</nfs_version>
    <path>/Storage_NFS/storage_jenkins_ge4_nfs_0</path>
    <type>nfs</type>
</storage_connection>


Verified using:
ovirt-engine-4.0.7-0.1.el7ev.noarch
ovirt-imageio-common-0.3.0-0.el7ev.noarch
ovirt-imageio-proxy-0.4.0-0.el7ev.noarch
vdsm-4.18.22-1.el7ev.x86_64
ovirt-imageio-daemon-0.4.0-0.el7ev.noarch
Comment 11 errata-xmlrpc 2017-03-16 15:29:22 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0542.html
Note You need to log in before you can comment on or make changes to this bug.