Bug 1386610 – [z-stream clone - 4.0.6] Introduce a 'force' flag for updating a storage server connection

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1386610 - [z-stream clone - 4.0.6] Introduce a 'force' flag for updating a storage server connection

Summary:	[z-stream clone - 4.0.6] Introduce a 'force' flag for updating a storage serv...

Status:	CLOSED ERRATA

Aliases:	None

Product:	Red Hat Enterprise Virtualization Manager
Classification:	Red Hat
Component:	ovirt-engine (Show other bugs)
Sub Component:
Version:	3.6.7
Hardware:	Unspecified Unspecified

Priority	unspecified Severity medium
Target Milestone:	ovirt-4.0.7
Target Release:	---
Assigned To:	Daniel Erez
QA Contact:	Natalie Gavrielov
Docs Contact:

URL:
Whiteboard:
Keywords:	Improvement, ZStream

Depends On:	1379771
Blocks:
	Show dependency tree / graph

Reported:	2016-10-19 05:50 EDT by rhev-integ
Modified:	2017-03-16 11:29 EDT (History)
CC List:	14 users (show)

See Also:
Fixed In Version:
Doc Type:	Enhancement
Doc Text:	This release introduces a 'force' flag, which can be used to update a storage server connection regardless of the associated storage domain status (allowing updates even when the storage domain is not in Maintenance mode). For example: PUT /ovirt-engine/api/storageconnections/123;force=true
Story Points:	---
Clone Of:	1379771
Environment:
Last Closed:	2017-03-16 11:29:22 EDT
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	Storage
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
oVirt gerrit	64892	None	None	None	2016-11-07 05:03 EST
Red Hat Product Errata	RHBA-2017:0542	normal	SHIPPED_LIVE	Red Hat Virtualization Manager 4.0.7	2017-03-16 15:25:04 EDT

Groups: None (edit)

Comment 1 Allon Mureinik 2016-11-07 05:03:06 EST

Daniel - the engine patch in the 4.0 branch seems to be merged. Is there a pending API patch, or can this be moved to MODIFIED?

Comment 2 Daniel Erez 2016-11-07 05:14:11 EST

(In reply to Allon Mureinik from comment #1)
> Daniel - the engine patch in the 4.0 branch seems to be merged. Is there a
> pending API patch, or can this be moved to MODIFIED?

Can be moved.

Comment 7 Raz Tamir 2016-11-30 12:03:43 EST

Allon,
I tried to use ?force=true and still get the same response:
<fault>
    <detail>[]</detail>
    <reason>Operation Failed</reason>
</fault>

From the engine.log:

2016-11-30 19:02:10,030 INFO  [org.ovirt.engine.core.bll.storage.connection.UpdateStorageServerConnectionCommand] (default task-25) [2700eb37] Lock Acquired to object 'EngineLock:{exclusiveLocks='[64025f2c-8e50-4b1d-97cc-d2fd01cd804c=<STORAGE, ACTION_TYPE_FAILED_OBJECT_LOCKED>, 10.35.110.11:/Storage_NFS/storage_local_ge3_nfs_1=<STORAGE_CONNECTION, ACTION_TYPE_FAILED_OBJECT_LOCKED>, b8cb70fb-e3b1-4593-b4c1-80552ee1718b=<STORAGE_CONNECTION, ACTION_TYPE_FAILED_OBJECT_LOCKED>]', sharedLocks='null'}'
2016-11-30 19:02:10,039 WARN  [org.ovirt.engine.core.bll.storage.connection.UpdateStorageServerConnectionCommand] (default task-25) [2700eb37] Validation of action 'UpdateStorageServerConnection' failed for user admin@internal-authz. Reasons: VAR__ACTION__UPDATE,VAR__TYPE__STORAGE__CONNECTION
2016-11-30 19:02:10,039 INFO  [org.ovirt.engine.core.bll.storage.connection.UpdateStorageServerConnectionCommand] (default task-25) [2700eb37] Lock freed to object 'EngineLock:{exclusiveLocks='[64025f2c-8e50-4b1d-97cc-d2fd01cd804c=<STORAGE, ACTION_TYPE_FAILED_OBJECT_LOCKED>, 10.35.110.11:/Storage_NFS/storage_local_ge3_nfs_1=<STORAGE_CONNECTION, ACTION_TYPE_FAILED_OBJECT_LOCKED>, b8cb70fb-e3b1-4593-b4c1-80552ee1718b=<STORAGE_CONNECTION, ACTION_TYPE_FAILED_OBJECT_LOCKED>]', sharedLocks='null'}'
2016-11-30 19:02:10,049 ERROR [org.ovirt.engine.api.restapi.resource.AbstractBackendResource] (default task-25) [] Operation Failed: []

Comment 8 Daniel Erez 2016-12-08 04:06:20 EST

After investigating with the QE: working as expected on block domains, the failure is only on file domains in 4.0.x. Fixed by: https://gerrit.ovirt.org/#/c/67971/

Comment 9 Natalie Gavrielov 2017-02-07 13:35:26 EST

Performed scenario described in comment 3 along with the change in comment 4: ?force=true
Also made sure that information displayed in the UI changes accordingly (shows NFS version V4)   

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<storage_connection href="/ovirt-engine/api/storageconnections/a9e2a311-998a-4eb8-a29b-6dec88473802" id="a9e2a311-998a-4eb8-a29b-6dec88473802">
    <address>10.35.110.11</address>
    <nfs_version>v4</nfs_version>
    <path>/Storage_NFS/storage_jenkins_ge4_nfs_0</path>
    <type>nfs</type>
</storage_connection>


Verified using:
ovirt-engine-4.0.7-0.1.el7ev.noarch
ovirt-imageio-common-0.3.0-0.el7ev.noarch
ovirt-imageio-proxy-0.4.0-0.el7ev.noarch
vdsm-4.18.22-1.el7ev.x86_64
ovirt-imageio-daemon-0.4.0-0.el7ev.noarch

Comment 11 errata-xmlrpc 2017-03-16 11:29:22 EDT

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0542.html

Note You need to log in before you can comment on or make changes to this bug.