Bug 1386774 (kf5-libktorrent) - Review Request: kf5-libktorrent - Library providing torrent downloading code
Summary: Review Request: kf5-libktorrent - Library providing torrent downloading code
Keywords:
Status: CLOSED ERRATA
Alias: kf5-libktorrent
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Randy Barlow
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2016-10-19 15:24 UTC by Rex Dieter
Modified: 2017-01-01 23:18 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-01-01 21:51:12 UTC
Type: ---
Embargoed:
randy: fedora-review+


Attachments (Terms of Use)

Description Rex Dieter 2016-10-19 15:24:55 UTC
Spec URL: https://rdieter.fedorapeople.org/rpms/ktorrent/kf5-libktorrent.spec
SRPM URL: https://rdieter.fedorapeople.org/rpms/ktorrent/kf5-libktorrent-2.0.1-3.fc24.src.rpm
Description: Library providing torrent downloading code
Fedora Account System Username: rdieter

Comment 1 Rex Dieter 2016-10-19 16:19:15 UTC
Spec URL: https://rdieter.fedorapeople.org/rpms/ktorrent/kf5-libktorrent.spec
SRPM URL: https://rdieter.fedorapeople.org/rpms/ktorrent/kf5-libktorrent-2.0.1-4.fc24.src.rpm

%changelog
* Wed Oct 19 2016 Rex Dieter <rdieter> - 2.0.1-4
- use upstreamable gmp fix/workaround

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16125181

Comment 2 Rex Dieter 2016-10-19 17:22:57 UTC
Better scratch:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16125503

(need patch_fuzz for rawhide apparently... even though all the patches used are directly from upstream git)

Comment 3 Randy Barlow 2016-11-16 20:20:45 UTC
There are a few things in the MUST section that we will need to fix. I've added "randy: " comments to expand on the !'s a bit.

All of my comments outside of the MUST section are just recommendations, so you can feel free to ignore those if you disagree.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.                                                                       
[x]: Package contains no static executables.                                                                        
[x]: Header files in -devel subpackage, if present.                                                                 
[x]: ldconfig called in %post and %postun if required.                                                              
[x]: Package does not contain any libtool archives (.la)                                                            
[x]: Rpath absent or only used for internal libs.                                                                   
[x]: Development (unversioned) .so files in -devel subpackage, if present.                                          
                                                                                                                    
Generic:                                                                                                            
[x]: Package is licensed with an open-source compatible license and meets                                           
     other legal requirements as defined in the legal section of Packaging                                          
     Guidelines.                                                                                                    
[!]: If (and only if) the source package includes the text of the                                                   
     license(s) in its own file, then that file, containing the text of the                                         
     license(s) for the package is included in %license.                                                            
     randy: It looks like the %license macro is commented out in the %files                                         
            section. It could/should also be added to the devel subpackage.                                         
[!]: License field in the package spec file matches the actual license.                                             
     Note: Checking patched sources after %prep for licenses. Licenses                                              
     found: "BSD (3 clause)", "*No copyright* BSD (3 clause)", "MIT/X11                                             
     (BSD like)", "GPL (v2 or later)", "Unknown or generated". 105 files                                            
     have unknown license. Detailed output of licensecheck in                                                       
     /home/rbarlow/reviews/1386774-kf5-libktorrent/licensecheck.txt                                                 
     randy: It sounds like we should set the license field to                                                       
            "BSD, MIT, and GPLv2+"                                                                                  
[!]: License file installed when any subpackage combination is installed.                                           
     randy: Same as above, let's add the %license macro to both                                                     
            subpackages.
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/locale/hne,
     /usr/share/locale/hne/LC_MESSAGES
     randy: I'm not sure what to do on this one. It seems that filesystem
     owns the other directories. Perhaps we should file a ticket against
     that package to request this hne locale be added?
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/include/KF5,
     /usr/share/locale/hne/LC_MESSAGES, /usr/share/locale/hne
     randy: I think adding Requires: kf5-filesystem will fix this one.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[!]: Requires correct, justified where necessary.
     randy: I think we just need a Requires: kf5-filesystem
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

randy:
[!]: The URL field didn't seem to work for me. I recommend using
     https://cgit.kde.org/libktorrent.git/ instead.

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kf5
     -libktorrent-debuginfo
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
     randy: I recommend adding comments above the patches with links
            and/or explanations.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

randy:
[!]: You've got two patches that start with 0001-.

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: kf5-libktorrent-2.0.1-4.fc26.x86_64.rpm
          kf5-libktorrent-devel-2.0.1-4.fc26.x86_64.rpm
          kf5-libktorrent-debuginfo-2.0.1-4.fc26.x86_64.rpm
          kf5-libktorrent-2.0.1-4.fc26.src.rpm
kf5-libktorrent.x86_64: W: no-documentation
kf5-libktorrent-devel.x86_64: W: only-non-binary-in-usr-lib
kf5-libktorrent-devel.x86_64: W: no-documentation
kf5-libktorrent.src: W: patch-fuzz-is-changed
4 packages and 0 specfiles checked; 0 errors, 4 warnings.




Rpmlint (debuginfo)
-------------------
Checking: kf5-libktorrent-debuginfo-2.0.1-4.fc26.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
kf5-libktorrent-devel.x86_64: W: only-non-binary-in-usr-lib
kf5-libktorrent-devel.x86_64: W: no-documentation
kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5Crash.so.5
kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5Solid.so.5
kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5Service.so.5
kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5JobWidgets.so.5
kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5Completion.so.5
kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5WidgetsAddons.so.5
kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libQt5Widgets.so.5
kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libQt5Gui.so.5
kf5-libktorrent.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 11 warnings.



Requires
--------
kf5-libktorrent-devel (rpmlib, GLIBC filtered):
    boost-devel
    cmake(KF5Archive)
    cmake(KF5Config)
    cmake(KF5KIO)
    cmake(Qt5Network)
    gmp-devel(x86-64)
    kf5-libktorrent(x86-64)
    libKF5Torrent.so.6()(64bit)
    libgcrypt-devel

kf5-libktorrent (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libKF5Archive.so.5()(64bit)
    libKF5Completion.so.5()(64bit)
    libKF5ConfigCore.so.5()(64bit)
    libKF5CoreAddons.so.5()(64bit)
    libKF5Crash.so.5()(64bit)
    libKF5I18n.so.5()(64bit)
    libKF5JobWidgets.so.5()(64bit)
    libKF5KIOCore.so.5()(64bit)
    libKF5KIOWidgets.so.5()(64bit)
    libKF5Service.so.5()(64bit)
    libKF5Solid.so.5()(64bit)
    libKF5WidgetsAddons.so.5()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.7)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Network.so.5()(64bit)
    libQt5Network.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Xml.so.5()(64bit)
    libQt5Xml.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcrypt.so.20()(64bit)
    libgcrypt.so.20(GCRYPT_1.6)(64bit)
    libgmp.so.10()(64bit)
    libm.so.6()(64bit)
    libqca-qt5.so.2()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.1)(64bit)
    rtld(GNU_HASH)

kf5-libktorrent-debuginfo (rpmlib, GLIBC filtered):



Provides
--------
kf5-libktorrent-devel:
    cmake(KF5Torrent)
    kf5-libktorrent-devel
    kf5-libktorrent-devel(x86-64)

kf5-libktorrent:
    kf5-libktorrent
    kf5-libktorrent(x86-64)
    libKF5Torrent.so.6()(64bit)

kf5-libktorrent-debuginfo:
    kf5-libktorrent-debuginfo
    kf5-libktorrent-debuginfo(x86-64)



Source checksums
----------------
http://download.kde.org/stable/ktorrent/5.0/libktorrent-2.0.1.tar.xz :
  CHECKSUM(SHA256) this package     : c70d9ee11a1ac95145284e2ab9aec689df21b7462f389389b8d54f892a273f42
  CHECKSUM(SHA256) upstream package : c70d9ee11a1ac95145284e2ab9aec689df21b7462f389389b8d54f892a273f42


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1386774
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 4 Rex Dieter 2016-12-12 15:22:11 UTC
Spec URL: https://rdieter.fedorapeople.org/rpms/ktorrent/kf5-libktorrent.spec
SRPM URL: https://rdieter.fedorapeople.org/rpms/ktorrent/kf5-libktorrent-2.0.1-5.fc24.src.rpm

%changelog
* Mon Dec 12 2016 Rex Dieter <rdieter> - 2.0.1-5
- Requires: kf5-filesystem
- update URL
- %%license COPYING

License: GPLv2+ is the "effective" license (and unchanged), this is what "BSD and MITand GPLv2+" combines to,
https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#What_is_.22effective_license.22_and_do_I_need_to_know_that_for_the_License:_tag.3F

Comment 5 Rex Dieter 2016-12-21 12:22:06 UTC
ping, it's been over a week (sorry for my previous delay in responding myself).

was hoping to get this resolved before the end of the year

Comment 6 Randy Barlow 2016-12-22 16:08:36 UTC
Hello Rex! I apologize for the delay. One more change - can you also add the %license macro to the devel subpackage?

Comment 7 Rex Dieter 2016-12-22 16:18:47 UTC
Why?  -devel requires the main pkg already.

Comment 8 Rex Dieter 2016-12-23 16:35:31 UTC
In particular,
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Subpackage_Licensing

"If a subpackage is dependent (either implicitly or explicitly) upon a base package (where a base package is defined as a resulting binary package from the same source RPM which contains the appropriate license texts as %license), it is not necessary for that subpackage to also include those license texts as %license."

Comment 9 Randy Barlow 2016-12-23 17:05:17 UTC
Fair enough. I think I had been misinterpreting the fedora-review output to mean that the %license file should be installed in all subpackages, but now I don't know why I had read it that way. Apologies for the confusion!


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD
     like)", "*No copyright* BSD (3 clause)", "BSD (3 clause)", "MPL GPL
     (v2 or later)". 105 files have unknown license. Detailed output of
     licensecheck in
     /home/rbarlow/reviews/1386774-kf5-libktorrent/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/locale/hne,
     /usr/share/locale/hne/LC_MESSAGES
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/include/KF5,
     /usr/share/locale/hne/LC_MESSAGES, /usr/share/locale/hne
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kf5
     -libktorrent-debuginfo
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: kf5-libktorrent-2.0.1-5.fc26.x86_64.rpm
          kf5-libktorrent-devel-2.0.1-5.fc26.x86_64.rpm
          kf5-libktorrent-debuginfo-2.0.1-5.fc26.x86_64.rpm
          kf5-libktorrent-2.0.1-5.fc26.src.rpm
kf5-libktorrent-devel.x86_64: W: only-non-binary-in-usr-lib
kf5-libktorrent-devel.x86_64: W: no-documentation
kf5-libktorrent.src: W: patch-fuzz-is-changed
4 packages and 0 specfiles checked; 0 errors, 3 warnings.




Rpmlint (debuginfo)
-------------------
Checking: kf5-libktorrent-debuginfo-2.0.1-5.fc26.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
kf5-libktorrent-devel.x86_64: W: only-non-binary-in-usr-lib
kf5-libktorrent-devel.x86_64: W: no-documentation
kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5Crash.so.5
kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5Solid.so.5
kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5Service.so.5
kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5JobWidgets.so.5
kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5Completion.so.5
kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libKF5WidgetsAddons.so.5
kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libQt5Widgets.so.5
kf5-libktorrent.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKF5Torrent.so.6.0.0 /lib64/libQt5Gui.so.5
3 packages and 0 specfiles checked; 0 errors, 10 warnings.



Requires
--------
kf5-libktorrent-devel (rpmlib, GLIBC filtered):
    boost-devel
    cmake(KF5Archive)
    cmake(KF5Config)
    cmake(KF5KIO)
    cmake(Qt5Network)
    gmp-devel(x86-64)
    kf5-libktorrent(x86-64)
    libKF5Torrent.so.6()(64bit)
    libgcrypt-devel

kf5-libktorrent (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    kf5-filesystem
    libKF5Archive.so.5()(64bit)
    libKF5Completion.so.5()(64bit)
    libKF5ConfigCore.so.5()(64bit)
    libKF5CoreAddons.so.5()(64bit)
    libKF5Crash.so.5()(64bit)
    libKF5I18n.so.5()(64bit)
    libKF5JobWidgets.so.5()(64bit)
    libKF5KIOCore.so.5()(64bit)
    libKF5KIOWidgets.so.5()(64bit)
    libKF5Service.so.5()(64bit)
    libKF5Solid.so.5()(64bit)
    libKF5WidgetsAddons.so.5()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.7)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Network.so.5()(64bit)
    libQt5Network.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Xml.so.5()(64bit)
    libQt5Xml.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcrypt.so.20()(64bit)
    libgcrypt.so.20(GCRYPT_1.6)(64bit)
    libgmp.so.10()(64bit)
    libm.so.6()(64bit)
    libqca-qt5.so.2()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.1)(64bit)
    rtld(GNU_HASH)

kf5-libktorrent-debuginfo (rpmlib, GLIBC filtered):



Provides
--------
kf5-libktorrent-devel:
    cmake(KF5Torrent)
    kf5-libktorrent-devel
    kf5-libktorrent-devel(x86-64)

kf5-libktorrent:
    kf5-libktorrent
    kf5-libktorrent(x86-64)
    libKF5Torrent.so.6()(64bit)

kf5-libktorrent-debuginfo:
    kf5-libktorrent-debuginfo
    kf5-libktorrent-debuginfo(x86-64)



Source checksums
----------------
http://download.kde.org/stable/ktorrent/5.0/libktorrent-2.0.1.tar.xz :
  CHECKSUM(SHA256) this package     : c70d9ee11a1ac95145284e2ab9aec689df21b7462f389389b8d54f892a273f42
  CHECKSUM(SHA256) upstream package : c70d9ee11a1ac95145284e2ab9aec689df21b7462f389389b8d54f892a273f42


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1386774
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 10 Gwyn Ciesla 2016-12-23 17:57:15 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-libktorrent

Comment 11 Fedora Update System 2016-12-23 21:37:43 UTC
kf5-libktorrent-2.0.1-5.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab746d8a0

Comment 12 Fedora Update System 2016-12-23 21:38:41 UTC
kf5-libktorrent-2.0.1-5.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-1d2a0ef47f

Comment 13 Fedora Update System 2016-12-25 04:22:06 UTC
kf5-libktorrent-2.0.1-5.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-cab746d8a0

Comment 14 Fedora Update System 2016-12-25 04:51:49 UTC
kf5-libktorrent-2.0.1-5.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-1d2a0ef47f

Comment 15 Fedora Update System 2017-01-01 21:51:12 UTC
kf5-libktorrent-2.0.1-5.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2017-01-01 23:18:22 UTC
kf5-libktorrent-2.0.1-5.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.