Bug 1386809 - re-exec'ed make runs recipes with maximum RLIMIT_STACK, please apply upstream fix
Summary: re-exec'ed make runs recipes with maximum RLIMIT_STACK, please apply upstream...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: make
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Patsy Griffin
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-19 16:25 UTC by Stephan Bergmann
Modified: 2017-04-13 23:50 UTC (History)
2 users (show)

Fixed In Version: make-4.1-6.fc25
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-13 23:50:38 UTC
Type: Bug

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Stephan Bergmann 2016-10-19 16:25:40 UTC 
> $ ulimit -Ss
> 8192
> 
> $ ulimit -Hs
> unlimited
> 
> $ cat Makefile
> .PHONY: all restart
> 
> all:
> 	ulimit -s
> 
> ifeq ($(MAKE_RESTARTS),)
> Makefile: restart
> 	touch $@
> endif
> 
> $ make
> touch Makefile
> ulimit -s
> unlimited

(This plagues me in LibreOffice development, where make routinely restarts that way, some recipe calls gdb to generate a core backtrace, and gdb runs into infinite recursion on main thread due to <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61460#c1> "Demangler crash (GDB PR 17043)", causing its stack to grow beyond limit and the machine to crawl to a halt.)

There is a fix upstream, <http://git.savannah.gnu.org/cgit/make.git/commit/?id=a3d8c086d54c112fecfa2b9026a32a14f741f5f5> "* main.c (main): [SV 48009] Reset stack limit for make re-exec.", would be great if that could be backported to F24.
Comment 1 Fedora Update System 2017-02-17 02:35:42 UTC 
make-4.1-6.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-25dba3501a
Comment 2 Fedora Update System 2017-04-13 23:50:38 UTC 
make-4.1-6.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.