Description of problem: Log message shows error code as success even when rpc fails to connect [2016-10-20 14:27:14.474001] E [MSGID: 104024] [glfs-mgmt.c:735:mgmt_rpc_notify] 0-glfs-mgmt: failed to connect with remote-host: 10.70.46.212 (Success) Version-Release number of selected component (if applicable): samba-client-4.4.6-2.el7rhgs.x86_64 glusterfs-client-xlators-3.8.4-2.el7rhgs.x86_64 Windows10 How reproducible: Always Steps to Reproduce: 1.Create a 4 node gluster cluster with ctdb 2.Enable volfile setup in smb.conf with unix+ socket (unix+/var/run/glusterd.socket tcp+<valid hostname>) 3.reload the smb config file (smbcontrol smbd reload-config) 4.kill glusterd in one of the server node 5.mount in windows using "net use" provide the ip of the server where glusterd is stopped Actual results: Success message on failure Expected results: No success message should come when error message is there Additional info:
This is a simple fix, just a change in gf_msg() call. errno should not be used in the log message, we should use a set error code to describe this error.
mainline patch: https://review.gluster.org/16730 moving to POST
downstream patch : https://code.engineering.redhat.com/gerrit/#/c/101325/
Issue is fixed as did not find [E]rror code for the same.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:2774