Bug 1387792 - VM Explorer: When VMs in the tree are hidden some of the Datacenter folders are not displayed in tree
Summary: VM Explorer: When VMs in the tree are hidden some of the Datacenter folders a...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.7.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.8.0
Assignee: Keenan Brock
QA Contact: Nandini Chandra
URL:
Whiteboard:
Depends On:
Blocks: 1395314
TreeView+ depends on / blocked
 
Reported: 2016-10-21 22:17 UTC by Harpreet Kataria
Modified: 2017-09-13 19:21 UTC (History)
8 users (show)

Fixed In Version: 5.8.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1395314 (view as bug list)
Environment:
Last Closed: 2017-06-12 17:21:07 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
When VMs are visible in tree (33.27 KB, image/png)
2016-10-21 22:17 UTC, Harpreet Kataria
no flags Details
When VMs are hidden in tree (20.14 KB, image/png)
2016-10-21 22:17 UTC, Harpreet Kataria
no flags Details

Description Harpreet Kataria 2016-10-21 22:17:09 UTC
Created attachment 1212964 [details]
When VMs are visible in tree

Description of problem: VM Explorer: When VMs in the tree are hidden some of the Datacenter folders are not displayed in tree


Version-Release number of selected component (if applicable):
5.7.0

How reproducible:


Steps to Reproduce:
1. Go To Infrastructure VMs explorer
2. When options to show VMs is selected in default view settings for a user, Datacenter folders such as Default folder under RHEV-M and SCVMM folder under SCVMM provider are visible and shows VMs under those, but when option to not display VMs under explorer trees is set for a user, Datacenter folders in question are not visible in the tree(see attached screenshots for reference)
3.

Actual results: Some of the Datacenter folders are missing from tree when VMs are not visible in tree


Expected results: All Datacenter folders should be visible in tree regardless of whether VMs are shown/hidden in the explorer tree.


Additional info:

Comment 2 Harpreet Kataria 2016-10-21 22:17:42 UTC
Created attachment 1212965 [details]
When VMs are hidden in tree

Comment 3 Harpreet Kataria 2016-10-21 22:19:04 UTC
Keenan,

I am not sure at this point if this is a UI issue or somehow back-end is not returning back the datacenter folders in questions.

Can you take a look into this as well.

Thanks,
~Harpreet

Comment 4 Keenan Brock 2016-10-25 01:55:18 UTC
https://github.com/ManageIQ/manageiq/pull/12152

waiting backport before marking this PR as complete

Comment 5 CFME Bot 2016-10-25 12:56:21 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/793daf8057c8109b3d20de2a87413ef4fbdc4e38

commit 793daf8057c8109b3d20de2a87413ef4fbdc4e38
Author:     Keenan Brock <kbrock>
AuthorDate: Mon Oct 24 21:28:23 2016 -0400
Commit:     Keenan Brock <kbrock>
CommitDate: Mon Oct 24 21:28:23 2016 -0400

    Properly prune vms and template trees
    
    before:
    Trees were collapsed before pruning rbac.
    Prune rbac was not finding the tree nodes in the whitelist and
    improperly removing valid nodes.
    
    after:
    Prune rbac first, so nodes can be properly pruned
    Tree nodes can then be collapsed
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1387792

 app/presenters/tree_builder_vms_and_templates.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 6 CFME Bot 2016-10-25 13:05:58 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/8598e396558f2358421a660916c74fd4ca980d69

commit 8598e396558f2358421a660916c74fd4ca980d69
Author:     Oleg Barenboim <chessbyte>
AuthorDate: Tue Oct 25 14:51:10 2016 +0200
Commit:     Oleg Barenboim <chessbyte>
CommitDate: Tue Oct 25 15:03:47 2016 +0200

    Merge pull request #12152 from kbrock/bz_1387792
    
    Vm Tree builder pruning folders
    (cherry picked from commit 5c340c2e8c0a7c1eeeb60dda149afcfedc2b6fb6)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1387792

 app/presenters/tree_builder_vms_and_templates.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 8 Nandini Chandra 2017-05-11 19:29:49 UTC
Verified in 5.8.0.12


Note You need to log in before you can comment on or make changes to this bug.