Spec URL: https://lupinix.fedorapeople.org/review/python-fitsio.spec SRPM URL: https://lupinix.fedorapeople.org/review/python-fitsio-0.9.10-1.fc25.src.rpm Description: A full featured python library to read from and write to FITS files Fedora Account System Username: lupinix Note that licensecheck will mention zlib license in addition to GPLv2+, this is a result of bundled cfitsio. I force to build against system cfitsio, so these bits are not touched and not installed. Thank you very much for review in advance :)
Koji scratch build (rawhide): http://koji.fedoraproject.org/koji/taskinfo?taskID=16171010
Taken! =)
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ---> Guidelines have changed, but it is not reflected by f-r, yet. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. ---> Fine for C-compiled Python modules. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "zlib/libpng". 296 files have unknown license. Detailed output of licensecheck in /home/besser82/shared/fedora/review/1387876 -python-fitsio/licensecheck.txt ---> Please document the license-breakdown and adjust License-tag accordingly. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. ---> Please remove those cfitsio*patch/-dirs during %%prep, to make sure they are not used during build. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81920 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-fitsio , python3-fitsio , python-fitsio-debuginfo ---> pythonX- packages are stand-alone. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. ---> I recommend to run the tests during %%check, probably using nosetests. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-fitsio-0.9.10-1.fc26.x86_64.rpm python3-fitsio-0.9.10-1.fc26.x86_64.rpm python-fitsio-debuginfo-0.9.10-1.fc26.x86_64.rpm python-fitsio-0.9.10-1.fc26.src.rpm 4 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (debuginfo) ------------------- Checking: python-fitsio-debuginfo-0.9.10-1.fc26.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- python-fitsio-debuginfo (rpmlib, GLIBC filtered): python2-fitsio (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcfitsio.so.2()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) python(abi) python2-numpy rtld(GNU_HASH) python3-fitsio (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcfitsio.so.2()(64bit) libpthread.so.0()(64bit) libpython3.5m.so.1.0()(64bit) python(abi) python3-numpy rtld(GNU_HASH) Provides -------- python-fitsio-debuginfo: python-fitsio-debuginfo python-fitsio-debuginfo(x86-64) python2-fitsio: python-fitsio python-fitsio(x86-64) python2-fitsio python2-fitsio(x86-64) python2.7dist(fitsio) python2dist(fitsio) python3-fitsio: python3-fitsio python3-fitsio(x86-64) python3.5dist(fitsio) python3dist(fitsio) Unversioned so-files -------------------- python2-fitsio: /usr/lib64/python2.7/site-packages/fitsio/_fitsio_wrap.so python3-fitsio: /usr/lib64/python3.5/site-packages/fitsio/_fitsio_wrap.cpython-35m-x86_64-linux-gnu.so Source checksums ---------------- https://files.pythonhosted.org/packages/source/f/fitsio/fitsio-0.9.10.tar.gz : CHECKSUM(SHA256) this package : 97c4d5f1f6c1f824d0f4c79463d707a720b84df356ca9c50d2efd2edf5b27b28 CHECKSUM(SHA256) upstream package : 97c4d5f1f6c1f824d0f4c79463d707a720b84df356ca9c50d2efd2edf5b27b28 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1387876 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 ===== EXTRA items ===== Package APPROVED!!! Please consider my recommendations about removing those bundle-code dirs and testsuite during import.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-fitsio
python-fitsio-0.9.10-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b6f8a460f3
python-fitsio-0.9.10-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-5172557b27
python-fitsio-0.9.10-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
python-fitsio-0.9.10-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.