Bug 1388016 – [3.3] The insecure-registry address was removed during upgrade

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1388016 - [3.3] The insecure-registry address was removed during upgrade

Summary:	[3.3] The insecure-registry address was removed during upgrade

Status:	CLOSED ERRATA

Aliases:	None

Product:	OpenShift Container Platform
Classification:	Red Hat
Component:	Upgrade (Show other bugs)
Sub Component:
Version:	3.3.1
Hardware:	Unspecified Unspecified

Priority	medium Severity medium
Target Milestone:	---
Target Release:	3.3.1
Assigned To:	Andrew Butcher
QA Contact:	Anping Li
Docs Contact:

URL:
Whiteboard:
Keywords:	Regression, Reopened

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2016-10-24 04:44 EDT by Anping Li
Modified:	2017-03-06 11:37 EST (History)
CC List:	5 users (show)

See Also:
Fixed In Version:	openshift-ansible-3.3.41-1.git.0.a1a327b.el7
Doc Type:	Bug Fix
Doc Text:	Previously, when upgrading to OCP 3.3 if the internal registry were not secured the --insecure-registry flag was improperly removed from /etc/sysconfig/docker resulting in failed pushes and pulls from the integrated registry. Now the upgrade playbooks have been updated to preserve that flag during an upgrade ensuring that insecure registries continue to work properly after upgrade.
Story Points:	---
Clone Of:
Environment:
Last Closed:	2017-03-06 11:37:05 EST
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
ansible logs (858.80 KB, text/plain) 2016-10-24 04:44 EDT, Anping Li	no flags	Details
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2017:0448	normal	SHIPPED_LIVE	Important: ansible and openshift-ansible security and bug fix update	2017-03-06 16:36:25 EST

Groups: None (edit)

Description Anping Li 2016-10-24 04:44:49 EDT

Created attachment 1213376 [details]
ansible logs

Description of problem:
During upgrade, "--insecure-registry=172.30.0.0/16" was removed during upgrade.

Version-Release number of selected component (if applicable):
ansible-2.2.0.0-0.62.rc1.el7.noarch
openshift-ansible-3.3.38-1.git.0.2637ed5.el7.noarch

How reproducible:
always

Steps to Reproduce:
1. install OCP-3.2 
2. upgrade node to OCP-3.3
3. trigger sti-build

Actual results:
3. docker push failed due to '--insecure-registry=172.30.0.0/16' was removed during upgrade.


Expected results:


Additional info:

Comment 1 Anping Li 2016-10-25 03:46:56 EDT

To avoid this issue, We can add one line "openshift_docker_insecure_registries=registryservice:ip" in inventory.

Comment 2 openshift-github-bot 2016-10-26 16:49:16 EDT

Commit pushed to master at https://github.com/openshift/openshift-ansible

https://github.com/openshift/openshift-ansible/commit/cab68138cd264b9a4cb5dad9801a42ee50e1bc9b
Merge pull request #2670 from abutcher/hosted-registry-insecure

Bug 1388016 - The insecure-registry address was removed during upgrade

Comment 6 Anping Li 2016-10-26 23:48:33 EDT

Before upgrade: 
OPTIONS=' --selinux-enabled --insecure-registry=172.30.0.0/16 --log-driver=json-file --log-opt max-size=50m'

After upgrade:
OPTIONS=' --selinux-enabled --log-driver=json-file --log-opt max-size=50m'

Comment 7 Anping Li 2016-10-27 01:45:34 EDT

The issue is on Containerized installation, the rpm installation works.

Comment 8 Andrew Butcher 2016-10-27 11:55:07 EDT

Testing with containerized (on RHEL) upgrade from 3.2->3.3 and I can't reproduce the issue.

Before uprade:
OPTIONS=' --selinux-enabled --insecure-registry=172.30.0.0/16 --log-driver=json-file --log-opt max-size=50m'

After upgrade:
OPTIONS=' --selinux-enabled --insecure-registry=172.30.0.0/16 --log-driver=json-file --log-opt max-size=50m'

I will try a few more tests with specific versions.

Comment 9 Scott Dodson 2016-11-08 11:14:39 EST

Moving back to ON_QA since we can't reproduce this any longer.

Comment 11 errata-xmlrpc 2017-03-06 11:37:05 EST

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:0448

Note You need to log in before you can comment on or make changes to this bug.