Red Hat Bugzilla – Bug 1388043
[userinterface_public_502] Escape characters in error message look messy when editing membership
Last modified: 2017-03-08 13:43 EST
Description of problem: Escape characters in error message look messy when editing membership Version-Release number of selected component (if applicable): v3.4.0.14 How reproducible: Always Steps to Reproduce: 1. Login with admin user 2. Go to "Resources" -> "Membership", click "Edit Membership" 3. Add role to user: input invalid user name "user/abc", select role "view", then click "Add" 4. Add cluster-admin to user: select the option "Show hidden roles ", input user name "bob", select "cluster-admin", click "Add" Actual results: Step 3 and 4, the error message includes escape characters like '"': 3. The role "view" was not given to "user/abc".Reason: "RoleBinding "view" is invalid: [subjects[1].name: Invalid value: "user/1": name may not contain "/", subjects[2].name: Invalid value: "xxia-proj/bob*abc": must match the regex [a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)* (e.g. 'example.com'), subjects[3].name: Invalid value: "user/abc": name may not contain "/"]" 4. The role "cluster-admin" was not given to "xxia12345678901234567890123456789012345678901234567890".Reason: "rolebinding "cluster-admin" is forbidden: user "xxia" cannot grant extra privileges: {Verbs:["*"], APIGroups:["*"], Resources:["*"]} {Verbs:["*"], NonResourceURLs:["*"]}" Expected results: 3 and 4 should look well in error message. Additional info:
There may be many similar situations that are not known until encountered. E.g. here is another situation: Leave user name input empty, select role "view", click 'Add' (gray!), the error message also includes escape characters: The role "view" was not given to "".Reason: "RoleBinding "view" is invalid: subjects[1].name: Required value"
In comment 1, the gray button 'Add' can be clicked (thus produces the error message). It should not be clicked, this is another problem. Will use a new bug to report it
PR open for this: https://github.com/openshift/origin-web-console/pull/718
Commit pushed to master at https://github.com/openshift/origin-web-console https://github.com/openshift/origin-web-console/commit/7e09995b9ce6d7e0f2db6d2717d8575789c78468 Fix bug 1388043
This has been merged into ose and is in OSE v3.4.0.19 or newer.
Verified on latest origin openshift v1.4.0-alpha.0+90d8c62-1000-dirty Follow original test steps and it's not reproduced. The special characters will not be treated as invalid name, it'll be the part of user name.