Bug 1388117 - Hide tracebacks in engine.log when host is not responsive
Summary: Hide tracebacks in engine.log when host is not responsive
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Backend.Core
Version: 4.0.5.3
Hardware: All
OS: All
unspecified
medium
Target Milestone: ovirt-4.1.0-alpha
: 4.1.0
Assignee: Oved Ourfali
QA Contact: Lucie Leistnerova
URL:
Whiteboard:
Depends On:
Blocks: 1390192
TreeView+ depends on / blocked
 
Reported: 2016-10-24 14:12 UTC by Lukas Svaty
Modified: 2017-02-01 14:53 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-01 14:53:53 UTC
oVirt Team: Infra
Embargoed:
rule-engine: ovirt-4.1+
rule-engine: planning_ack+
mperina: devel_ack+
pstehlik: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 66654 0 None None None 2016-11-14 11:39:35 UTC

Description Lukas Svaty 2016-10-24 14:12:09 UTC
Description of problem:
When host is not responsive few tracebacks are displayed, these should be caught and properly logged. Im ok with showing the error message of the exception that was raised, but user should not need to search through the java tracebacks... (maybe in DEBUG mode, but I doubt its necessary)

examples:
2016-10-24 16:07:38,779 ERROR [org.ovirt.engine.core.vdsbroker.irsbroker.IrsBrokerCommand] (DefaultQuartzScheduler3) [] Exception: org.ovirt.engine.core.vdsbroker.xmlrpc.XmlRpcRunTimeException: Connection issues during send request
	at org.ovirt.engine.core.vdsbroker.jsonrpc.FutureMap.<init>(FutureMap.java:73) [vdsbroker.jar:]
	at org.ovirt.engine.core.vdsbroker.jsonrpc.JsonRpcIIrsServer.getStoragePoolInfo(JsonRpcIIrsServer.java:342) [vdsbroker.jar:]
...

another one:
2016-10-24 16:04:26,673 ERROR [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (or
g.ovirt.thread.pool-6-thread-27) [] Correlation ID: null, Call Stack: org.ovirt.engine.core.vdsbroker.vd
sbroker.VDSNetworkException: org.ovirt.vdsm.jsonrpc.client.ClientConnectionException: Connection failed
        at org.ovirt.engine.core.vdsbroker.vdsbroker.VdsBrokerCommand.createNetworkException(VdsBrokerCo
mmand.java:157)
        at org.ovirt.engine.core.vdsbroker.vdsbroker.VdsBrokerCommand.executeVDSCommand(VdsBrokerCommand
.java:120)
...

Comment 1 Martin Perina 2016-10-25 22:36:21 UTC
Some of those stack traces was already removed as a part of BZ1377310, could please verify that you can still see those stack traces in latest 4.0.5 build?

Comment 2 Lukas Svaty 2016-10-26 07:55:42 UTC
This was tested after that bug was verified, to continue this effort to have a tracebackless logs.

Comment 3 Lucie Leistnerova 2016-11-04 11:55:08 UTC
I got also other tracebacks
in ovirt-engine-4.0.5.2-0.2.el7ev.noarch

2016-11-04 10:22:54,375 ERROR [org.ovirt.engine.core.bll.host.HostUpgradeManager] (DefaultQuartzScheduler10) [236e6485] Exception: javax.naming.AuthenticationException: SSH authentication to 'root.XX.XX' failed. Please verify provided credentials. Make sure key is authorized at host
	at org.ovirt.engine.core.uutils.ssh.SSHClient.authenticate(SSHClient.java:370) [uutils.jar:]
...


2016-11-04 10:22:54,371 ERROR [org.ovirt.engine.core.bll.hostdeploy.VdsDeployBase] (DefaultQuartzScheduler10) [236e6485] Error during host XX.XX.XX.XX install: javax.naming.AuthenticationException: SSH authentication to 'root.XX.XX' failed. Please verify provided credentials. Make sure key is authorized at host
	at org.ovirt.engine.core.uutils.ssh.SSHClient.authenticate(SSHClient.java:370) [uutils.jar:]
....

Comment 4 Lucie Leistnerova 2016-11-04 13:35:05 UTC
I'm sorry I mentioned rpm from wrong machine, the right one is ovirt-engine-4.0.5.5-0.1.el7ev.noarch

Comment 5 Lukas Svaty 2016-11-07 15:28:48 UTC
FYI: https://bugzilla.redhat.com/show_bug.cgi?id=1392009 might be good to fix this as well somewhere in the future :)

Comment 6 Sandro Bonazzola 2016-12-12 13:58:21 UTC
The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified.

Comment 7 Lucie Leistnerova 2017-01-19 11:34:07 UTC
traceback for non responsive host is hidden

verified in ovirt-engine-4.1.0-0.4.master.20170118090304.git86ab9ea.el7.centos.noarch


Note You need to log in before you can comment on or make changes to this bug.