Bug 1388861 - build: python on Debian-based dists use .../lib/python2.7/dist-packages instead of .../site-packages
Summary: build: python on Debian-based dists use .../lib/python2.7/dist-packages inste...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: build
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kaleb KEITHLEY
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1389740 1389781
TreeView+ depends on / blocked
 
Reported: 2016-10-26 10:26 UTC by Kaleb KEITHLEY
Modified: 2017-03-06 17:31 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.10.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1389740 (view as bug list)
Environment:
Last Closed: 2017-03-06 17:31:48 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Kaleb KEITHLEY 2016-10-26 10:26:27 UTC
Description of problem:

configure(.ac) doesn't correctly get the location for the gluster and glupy python packages.

It turns out that the python pkgconfig bits for python has already figured it out correctly.

Version-Release number of selected component (if applicable):


How reproducible:

build and install on Debian. Observe that the python __init__.py files are installed in /usr/lib/python2.7/site-packages/... instead of /usr/lib/python2.7/dist-packages.


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2016-10-26 13:23:09 UTC
REVIEW: http://review.gluster.org/15733 (build: python site-packages vs. dist-packages) posted (#1) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 2 Worker Ant 2016-10-28 12:17:34 UTC
REVIEW: http://review.gluster.org/15733 (build: python site-packages vs. dist-packages) posted (#2) for review on master by Kaleb KEITHLEY (kkeithle)

Comment 3 Worker Ant 2016-12-11 12:43:25 UTC
COMMIT: http://review.gluster.org/15733 committed in master by Niels de Vos (ndevos) 
------
commit 6c6c9cd284f7aaf9c07c000abc60d71013862afd
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Wed Oct 26 08:56:51 2016 -0400

    build: python site-packages vs. dist-packages
    
    Unlike Fedora and RHEL/CentOS, where python has
    /usr/{lib,lib64}/python2.7/site-packages/...,  Debian-based
    distributions have /usr/lib/python2.7/dist-packages/...
    
    On Debian our python scriptlet to determine this is broken and
    incorrectly returns .../site-packages, not .../dist-packages.
    Furthermore, the automake/autoconf/pkgconfig bits ahead of our
    own scriptlet have already determined the correct location -- all
    we need to do is use it.
    
    This change also slightly reworks the BUILD_PYTHON_INC scriptlet
    to bring it in line with the style/pattern of the other python
    scriptlets provided by autoconf/pkgconfig.
    
    (I do wonder though, why we have two sets of {C,CPP}FLAGS and
    LD_FLAGS - PYTHONDEV_CPPFLAGS and BUILD_PYTHON_INC, and
    PYTHONDEV_LDFLAGS and BUILD_PYTHON_LIB.
    
    They both have very similar values, but, e.g. BUILD_PYTHON_INC
    misses /usr/lib/x86_64-linux-gnu/python2.7 on Debian; even if that
    ommission doesn't seem to be hurting us.)
    
    Change-Id: I309a5c781a1d9aee4d7be2867223781bd2ae18fa
    BUG: 1388861
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/15733
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Milind Changire <mchangir>
    Reviewed-by: Niels de Vos <ndevos>

Comment 4 Shyamsundar 2017-03-06 17:31:48 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report.

glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.