Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1388884

Summary: [userinterface_public_691] On the page of Create From Image, need not image secrets (push/pull for BC, pull for DC)
Product: OpenShift Container Platform Reporter: Xingxing Xia <xxia>
Component: Management ConsoleAssignee: Jakub Hadvig <jhadvig>
Status: CLOSED ERRATA QA Contact: Yadan Pei <yapei>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.4.0CC: aos-bugs, jforrest, jokerman, mmccomas, spadgett, tdawson
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: Selecting "Push Secret" and "Pull Secret" on the DC editor page and on Create From Image page Consequence: "Push Secret" and "Pull Secret" is a waste on the DC editor page and on Create From Image page cause they are using integrated registry Fix: Remove "Push Secret" and "Pull Secret" selectboxes from DC editor page and on Create From Image page. Result: User cant select "Push Secret" and "Pull Secret" on the DC editor page and on Create From Image page.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2017-01-18 12:46:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Xingxing Xia 2016-10-26 11:07:18 UTC 
Description of problem:
On the page of Create From Image, should let user has choice to specify DockerImage for BC's output.kind and DC's spec.containers.image. Otherwise, it does not make sense to add push secret for BC and pull secret for DC. See below results in step 7 and 8.

Version-Release number of selected component (if applicable):
openshift v3.4.0.15

How reproducible:
Always

Steps to Reproduce:
1. Create project, create secret:
$ oc secrets new-dockercfg dockerhub --docker-server=private.registry.com --docker-username=any --docker-password=12345678 --docker-email=any

2. Login to openshift web console, on the page of Create From Image:
select one image like php,
input app name "myphpapp",
click "Try it",
click "Show advanced routing, build, deployment and source options"

3. In the "Build Configuration" part, check if there is choice to specify BC's output's kind to be DockerImage
4. In the "Deployment Configuration" part, check if there is choice to specify DC's spec.containers.image

5. Now that there is no choice in previous steps,
under BC's "Push Secret" part, pick above secret dockerhub.
under DC's "Pull Secret" part, pick above secret dockerhub.

6. Click Create.

7. Check build and DC app

8. Repeat above steps again, but don't use "Push Secret" and "Pull Secret", then check build and DC app

Actual results:
3 and 4: there is not that choice.
7. Build fail and DC app will not be deployed.
Check build logs, will see:
$ oc logs build/myphpapp-1
Cloning "https://github.com/openshift/cakephp-ex.git" ...
....
Pushing image 172.30.213.171:5000/xxia-proj/myphpapp:latest ...
Pushed 0/9 layers, 0% complete
error: build error: Failed to push image: unauthorized: authentication required

8. Because they use integrated registry, Build will complete and DC app will be deployed without the use of "Push Secret" and "Pull Secret". Thus the function of "Push Secret" and "Pull Secret" is a waste.

Expected results:
3 and 4 should have that choice to specify image registry, only then the function of "Push Secret" and "Pull Secret" will make sense.

Additional info:
Comment 1 Samuel Padgett 2016-10-31 18:29:23 UTC 
Jakub, I confirmed with Ben Parees that we should **not** need to specify a push or pull image secret in this flow. We only need the source secret.

Note that this bug is referring to picking a builder image from the catalog tab. It is not talking about the deploy image scenario where you might need a pull secret.
Comment 2 openshift-github-bot 2016-11-01 12:37:53 UTC 
Commit pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/7bb97dda7db84edad89bb130742ab3017d74a212
Bug 1388884 - Specify only 'Source secret' only Create From Image page
Comment 3 Samuel Padgett 2016-11-01 13:28:01 UTC 
The fix we made was to remove the unnecessary secrets inputs from the create from image page. You should not need to specify image push or pull secrets on this page. (The build config source secret is still there.)
Comment 4 Troy Dawson 2016-11-04 19:32:29 UTC 
This has been merged into ose and is in OSE v3.4.0.22 or newer.
Comment 6 Xingxing Xia 2016-11-07 09:34:24 UTC 
Checked with openshift v3.4.0.22+5c56720. Fixed. No image secrets any longer on the page of Create From Image. Thank you!
Comment 8 errata-xmlrpc 2017-01-18 12:46:28 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:0066