Hide Forgot
Description of problem: Conduct code review to find possible points for performance improvement. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
virtio-win-prewhql-0.1-128 includes implementation of these improvements
Hi, yan I have two concerns before I verify this bug: - If build 128 is the first version including the code ? yes, I check it with build 127 and 128. - which guest will be influenced ? I plan to pick up one or two guests for checking. Thanks, wenli
1. All Windows guests are affected (except of 2003/XP). 2. These changes were first introduced in 128
(In reply to Quan Wenli from comment #3) > Hi, yan > > I have two concerns before I verify this bug: > > - If build 128 is the first version including the code ? yes, I check it > with build 127 and 128. > - which guest will be influenced ? I plan to pick up one or two guests for > checking. > > Thanks, wenli Hi, I am not sure about 127. Better use 126 - it was RHEL7.3 release build and it didn't have those changes at all. Also we are sure that 126 is a stable build. If you want to minimise guest matrix - I suggest to use Windows 2012R2 and Windows 2008 as test cases. Best regards, Yan.
I checked the value of Recv Segment Coalescing is enabled with build 128. Yuri, do you know the about setup setting about Yan mentioned ?
Hi, Yuri Yan suggest us to test Windows 2012R2 and Windows 2008 in comment#5, but it looks like the RSC is not working on Windows 2008. Follows are the part of output `ethtook -k tap0` for both Windows 2008 and 2012R2. Need us test Windows 2008 as well ? build-126/win2008-64.qcow2 tx-checksumming: on tx-checksum-ipv4: off [fixed] tx-checksum-ip-generic: on tx-checksum-ipv6: off [fixed] tx-checksum-fcoe-crc: off [fixed] tx-checksum-sctp: off [fixed] scatter-gather: on tx-scatter-gather: on tx-scatter-gather-fraglist: on tcp-segmentation-offload: off tx-tcp-segmentation: off [requested on] tx-tcp-ecn-segmentation: off [requested on] tx-tcp6-segmentation: off [requested on] build-128/win2008-64.qcow2 tx-checksumming: on tx-checksum-ipv4: off [fixed] tx-checksum-ip-generic: on tx-checksum-ipv6: off [fixed] tx-checksum-fcoe-crc: off [fixed] tx-checksum-sctp: off [fixed] scatter-gather: on tx-scatter-gather: on tx-scatter-gather-fraglist: on tcp-segmentation-offload: off tx-tcp-segmentation: off [requested on] tx-tcp-ecn-segmentation: off [requested on] tx-tcp6-segmentation: off [requested on] build-126/win2012r2-64.qcow2 tx-checksumming: on tx-checksum-ipv4: off [fixed] tx-checksum-ip-generic: on tx-checksum-ipv6: off [fixed] tx-checksum-fcoe-crc: off [fixed] tx-checksum-sctp: off [fixed] scatter-gather: on tx-scatter-gather: on tx-scatter-gather-fraglist: on tcp-segmentation-offload: on tx-tcp-segmentation: on tx-tcp-ecn-segmentation: off [requested on] tx-tcp6-segmentation: on 128/win2012r2-64.qcow2 tx-checksumming: on tx-checksum-ipv4: off [fixed] tx-checksum-ip-generic: on tx-checksum-ipv6: off [fixed] tx-checksum-fcoe-crc: off [fixed] tx-checksum-sctp: off [fixed] scatter-gather: on tx-scatter-gather: on tx-scatter-gather-fraglist: on tcp-segmentation-offload: on tx-tcp-segmentation: on tx-tcp-ecn-segmentation: off [requested on] tx-tcp6-segmentation: on
(In reply to Quan Wenli from comment #13) > Hi, Yuri > > Yan suggest us to test Windows 2012R2 and Windows 2008 in comment#5, but it > looks like the RSC is not working on Windows 2008. Follows are the part of > output `ethtook -k tap0` for both Windows 2008 and 2012R2. Need us test > Windows 2008 as well ? > > build-126/win2008-64.qcow2 > > tx-checksumming: on > tx-checksum-ipv4: off [fixed] > tx-checksum-ip-generic: on > tx-checksum-ipv6: off [fixed] > tx-checksum-fcoe-crc: off [fixed] > tx-checksum-sctp: off [fixed] > scatter-gather: on > tx-scatter-gather: on > tx-scatter-gather-fraglist: on > tcp-segmentation-offload: off > tx-tcp-segmentation: off [requested on] > tx-tcp-ecn-segmentation: off [requested on] > tx-tcp6-segmentation: off [requested on] > > build-128/win2008-64.qcow2 > > tx-checksumming: on > tx-checksum-ipv4: off [fixed] > tx-checksum-ip-generic: on > tx-checksum-ipv6: off [fixed] > tx-checksum-fcoe-crc: off [fixed] > tx-checksum-sctp: off [fixed] > scatter-gather: on > tx-scatter-gather: on > tx-scatter-gather-fraglist: on > tcp-segmentation-offload: off > tx-tcp-segmentation: off [requested on] > tx-tcp-ecn-segmentation: off [requested on] > tx-tcp6-segmentation: off [requested on] > > build-126/win2012r2-64.qcow2 > tx-checksumming: on > tx-checksum-ipv4: off [fixed] > tx-checksum-ip-generic: on > tx-checksum-ipv6: off [fixed] > tx-checksum-fcoe-crc: off [fixed] > tx-checksum-sctp: off [fixed] > scatter-gather: on > tx-scatter-gather: on > tx-scatter-gather-fraglist: on > tcp-segmentation-offload: on > tx-tcp-segmentation: on > tx-tcp-ecn-segmentation: off [requested on] > tx-tcp6-segmentation: on > > 128/win2012r2-64.qcow2 > > tx-checksumming: on > tx-checksum-ipv4: off [fixed] > tx-checksum-ip-generic: on > tx-checksum-ipv6: off [fixed] > tx-checksum-fcoe-crc: off [fixed] > tx-checksum-sctp: off [fixed] > scatter-gather: on > tx-scatter-gather: on > tx-scatter-gather-fraglist: on > tcp-segmentation-offload: on > tx-tcp-segmentation: on > tx-tcp-ecn-segmentation: off [requested on] > tx-tcp6-segmentation: on You're right, RSC is not active on 2008 on both 126 and 128, so they will be compared without RSC on 2008 and with RSC on 2012R2.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:2341