1388920 – [NetKVM] review additional possible performance improvements

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1388920 - [NetKVM] review additional possible performance improvements

Summary: [NetKVM] review additional possible performance improvements

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 7
Classification:	Red Hat
Component:	virtio-win
Sub Component:
Version:	7.4
Hardware:	Unspecified
OS:	Windows
Priority:	medium
Severity:	medium
Target Milestone:	rc
Target Release:	7.4
Assignee:	ybendito
QA Contact:	Virtualization Bugs
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	1395265
TreeView+	depends on / blocked

Reported:	2016-10-26 13:07 UTC by Yvugenfi@redhat.com
Modified:	2017-08-01 12:53 UTC (History)
CC List:	12 users (show)
Fixed In Version:
Doc Type:	Enhancement
Doc Text:	The performance of the NetKVM driver (virtio-net) has been significantly improved.
Clone Of:
Environment:
Last Closed:	2017-08-01 12:53:08 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2017:2341	0	normal	SHIPPED_LIVE	virtio-win bug fix and enhancement update	2017-08-01 16:52:38 UTC

Description Yvugenfi@redhat.com 2016-10-26 13:07:39 UTC

Description of problem:

Conduct code review to find possible points for performance improvement.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 ybendito 2016-11-22 09:12:11 UTC

virtio-win-prewhql-0.1-128 includes implementation of these improvements

Comment 3 Quan Wenli 2016-11-23 03:13:32 UTC

Hi, yan 

I have two concerns before I verify this bug:

 - If build 128 is the first version including the code ? yes, I check it with build 127 and 128. 
 - which guest will be influenced ? I plan to pick up one or two guests for checking. 

Thanks, wenli

Comment 4 ybendito 2016-11-23 08:16:48 UTC

1. All Windows guests are affected (except of 2003/XP).
2. These changes were first introduced in 128

Comment 5 Yvugenfi@redhat.com 2016-11-24 08:56:07 UTC

(In reply to Quan Wenli from comment #3)
> Hi, yan 
> 
> I have two concerns before I verify this bug:
> 
>  - If build 128 is the first version including the code ? yes, I check it
> with build 127 and 128. 
>  - which guest will be influenced ? I plan to pick up one or two guests for
> checking. 
> 
> Thanks, wenli

Hi,

I am not sure about 127. Better use 126 - it was RHEL7.3 release build and it didn't have those changes at all. Also we are sure that 126 is a stable build.


If you want to minimise guest matrix - I suggest to use Windows 2012R2 and Windows 2008 as test cases. 

Best regards,
Yan.

Comment 8 Quan Wenli 2016-11-30 08:47:16 UTC

I checked the value of Recv Segment Coalescing is enabled with build 128. 

Yuri, do you know the about setup setting about Yan mentioned ?

Comment 13 Quan Wenli 2016-12-14 07:35:36 UTC

Hi, Yuri

Yan suggest us to test Windows 2012R2 and Windows 2008 in comment#5, but it looks like the RSC is not working on Windows 2008. Follows are the part of output `ethtook -k tap0` for both Windows 2008 and 2012R2. Need us test Windows 2008 as well ?

build-126/win2008-64.qcow2

tx-checksumming: on
	tx-checksum-ipv4: off [fixed]
	tx-checksum-ip-generic: on
	tx-checksum-ipv6: off [fixed]
	tx-checksum-fcoe-crc: off [fixed]
	tx-checksum-sctp: off [fixed]
scatter-gather: on
	tx-scatter-gather: on
	tx-scatter-gather-fraglist: on
tcp-segmentation-offload: off
	tx-tcp-segmentation: off [requested on]
	tx-tcp-ecn-segmentation: off [requested on]
	tx-tcp6-segmentation: off [requested on]

build-128/win2008-64.qcow2

tx-checksumming: on
	tx-checksum-ipv4: off [fixed]
	tx-checksum-ip-generic: on
	tx-checksum-ipv6: off [fixed]
	tx-checksum-fcoe-crc: off [fixed]
	tx-checksum-sctp: off [fixed]
scatter-gather: on
	tx-scatter-gather: on
	tx-scatter-gather-fraglist: on
tcp-segmentation-offload: off
	tx-tcp-segmentation: off [requested on]
	tx-tcp-ecn-segmentation: off [requested on]
	tx-tcp6-segmentation: off [requested on]

build-126/win2012r2-64.qcow2
tx-checksumming: on
	tx-checksum-ipv4: off [fixed]
	tx-checksum-ip-generic: on
	tx-checksum-ipv6: off [fixed]
	tx-checksum-fcoe-crc: off [fixed]
	tx-checksum-sctp: off [fixed]
scatter-gather: on
	tx-scatter-gather: on
	tx-scatter-gather-fraglist: on
tcp-segmentation-offload: on
	tx-tcp-segmentation: on
	tx-tcp-ecn-segmentation: off [requested on]
	tx-tcp6-segmentation: on

128/win2012r2-64.qcow2

tx-checksumming: on
	tx-checksum-ipv4: off [fixed]
	tx-checksum-ip-generic: on
	tx-checksum-ipv6: off [fixed]
	tx-checksum-fcoe-crc: off [fixed]
	tx-checksum-sctp: off [fixed]
scatter-gather: on
	tx-scatter-gather: on
	tx-scatter-gather-fraglist: on
tcp-segmentation-offload: on
	tx-tcp-segmentation: on
	tx-tcp-ecn-segmentation: off [requested on]
	tx-tcp6-segmentation: on

Comment 14 ybendito 2016-12-14 12:32:18 UTC

(In reply to Quan Wenli from comment #13)
> Hi, Yuri
> 
> Yan suggest us to test Windows 2012R2 and Windows 2008 in comment#5, but it
> looks like the RSC is not working on Windows 2008. Follows are the part of
> output `ethtook -k tap0` for both Windows 2008 and 2012R2. Need us test
> Windows 2008 as well ?
> 
> build-126/win2008-64.qcow2
> 
> tx-checksumming: on
> 	tx-checksum-ipv4: off [fixed]
> 	tx-checksum-ip-generic: on
> 	tx-checksum-ipv6: off [fixed]
> 	tx-checksum-fcoe-crc: off [fixed]
> 	tx-checksum-sctp: off [fixed]
> scatter-gather: on
> 	tx-scatter-gather: on
> 	tx-scatter-gather-fraglist: on
> tcp-segmentation-offload: off
> 	tx-tcp-segmentation: off [requested on]
> 	tx-tcp-ecn-segmentation: off [requested on]
> 	tx-tcp6-segmentation: off [requested on]
> 
> build-128/win2008-64.qcow2
> 
> tx-checksumming: on
> 	tx-checksum-ipv4: off [fixed]
> 	tx-checksum-ip-generic: on
> 	tx-checksum-ipv6: off [fixed]
> 	tx-checksum-fcoe-crc: off [fixed]
> 	tx-checksum-sctp: off [fixed]
> scatter-gather: on
> 	tx-scatter-gather: on
> 	tx-scatter-gather-fraglist: on
> tcp-segmentation-offload: off
> 	tx-tcp-segmentation: off [requested on]
> 	tx-tcp-ecn-segmentation: off [requested on]
> 	tx-tcp6-segmentation: off [requested on]
> 
> build-126/win2012r2-64.qcow2
> tx-checksumming: on
> 	tx-checksum-ipv4: off [fixed]
> 	tx-checksum-ip-generic: on
> 	tx-checksum-ipv6: off [fixed]
> 	tx-checksum-fcoe-crc: off [fixed]
> 	tx-checksum-sctp: off [fixed]
> scatter-gather: on
> 	tx-scatter-gather: on
> 	tx-scatter-gather-fraglist: on
> tcp-segmentation-offload: on
> 	tx-tcp-segmentation: on
> 	tx-tcp-ecn-segmentation: off [requested on]
> 	tx-tcp6-segmentation: on
> 
> 128/win2012r2-64.qcow2
> 
> tx-checksumming: on
> 	tx-checksum-ipv4: off [fixed]
> 	tx-checksum-ip-generic: on
> 	tx-checksum-ipv6: off [fixed]
> 	tx-checksum-fcoe-crc: off [fixed]
> 	tx-checksum-sctp: off [fixed]
> scatter-gather: on
> 	tx-scatter-gather: on
> 	tx-scatter-gather-fraglist: on
> tcp-segmentation-offload: on
> 	tx-tcp-segmentation: on
> 	tx-tcp-ecn-segmentation: off [requested on]
> 	tx-tcp6-segmentation: on

You're right, RSC is not active on 2008 on both 126 and 128, so they will be compared without RSC on 2008 and with RSC on 2012R2.

Comment 24 errata-xmlrpc 2017-08-01 12:53:08 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2341

Note You need to log in before you can comment on or make changes to this bug.