In relation to recent GWT UI infra changes focused primarily on dialog resource cleanup [1], each dialog's PopupView should call: driver.cleanup(); within its cleanup() method. This will ensure the corresponding model(s) and UI widgets are cleaned up, making all dialog-related objects eligible for garbage collection. [1] https://gerrit.ovirt.org/#/c/63708/ https://gerrit.ovirt.org/#/c/65733/ In general, once a dialog has been closed, any dialog-related objects should not be referenced or needed anymore. Please revisit [2], I'd suggest moving the upload logic outside UploadImageModel: - UploadImageModel should only contain data/logic needed to display/update contents of the dialog - once user clicks a dialog button (UICommand), upload operation can be initiated - upload logic can be called/managed by the owner (list) model that triggers the dialog [2] https://gerrit.ovirt.org/#/c/64459/
There is no posted patch yet for this bug
Is this bug a regression?
No, it is a part of the UX team effort to improve performance. Most of the webadmin dialogs were changed in order to achieve it, and in the upload dialog there's a bit more work which is what described in this bug.
Daniel - is there anything for QA to verify here, or just make sure there are no regressions?
(In reply to Allon Mureinik from comment #4) > Daniel - is there anything for QA to verify here, or just make sure there > are no regressions? Indeed, it's just a codechange, no new behaviour. So just regressions check.
CodeChange, thus nothing for QE.
Verified based on comment #4 + #5 and no regression in ipload image
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017. Since the problem described in this bug report should be resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.