Description of problem: When provisioning VM, User received 2 Notifications: - request was approved - Virtual Machine [xxx] has been provisioned but if you look at the Service>Request, the request is not completed yet, and state machine is still running and then we have "Provisioned Successfully" message. This is confusing... Final messages should be in sync Version-Release number of selected component (if applicable): 5.7.0.7-beta1.20161025153249_9376fbd
Created attachment 1214585 [details] Screenshot
This is currently working as designed as the notifications are being driven off of the events. The vm_provisioned event is raised once the VM is created on the provider but before post-provisioning is complete. Tina is looking into possible changes to notifications to improve the messaging.
My concern here is: if something breaks in post-provision.. the provisioning with fails but the notification will give the impression it worked ok.
https://github.com/ManageIQ/manageiq/pull/12424
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/89ddb9ca803916a4d99d9562eaebc9a730735a92 commit 89ddb9ca803916a4d99d9562eaebc9a730735a92 Author: Tina Fitzgerald <tfitzger> AuthorDate: Thu Nov 3 15:37:38 2016 -0400 Commit: Tina Fitzgerald <tfitzger> CommitDate: Fri Nov 18 15:47:42 2016 -0500 Renamed vm_provisioned and service_provisioned notification_types to prevent them from being used for events. Add notification in task_finished common method. https://bugzilla.redhat.com/show_bug.cgi?id=1389312 .../StateMachineMethods.class/__methods__/task_finished.rb | 2 ++ db/fixtures/notification_types.yml | 4 ++-- spec/automation/unit/method_validation/task_finished_spec.rb | 10 ++++++++-- spec/lib/miq_automation_engine/miq_ae_service_spec.rb | 4 ++-- spec/models/notification_spec.rb | 2 +- 5 files changed, 15 insertions(+), 7 deletions(-)
Correct order is shown in 5.8.0.10-beta1.20170411212748_e47d319. Request approved , VM provisioned, Service Provisioned.