Bug 1389359 - [beta1] ldap group lookup not populating the group description
Summary: [beta1] ldap group lookup not populating the group description
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.7.0
Hardware: All
OS: All
high
high
Target Milestone: GA
: 5.8.0
Assignee: Aparna Karve
QA Contact: Matt Pusateri
URL:
Whiteboard: auth
Depends On:
Blocks: 1397160
TreeView+ depends on / blocked
 
Reported: 2016-10-27 13:37 UTC by Kevin Morey
Modified: 2017-09-12 15:19 UTC (History)
11 users (show)

Fixed In Version: 5.8.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1397160 (view as bug list)
Environment:
Last Closed: 2017-06-12 16:53:07 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
ldap-group-pics (108.62 KB, image/png)
2016-10-27 13:37 UTC, Kevin Morey
no flags Details
Group description as it appears in AD (61.72 KB, image/png)
2017-04-24 20:14 UTC, Matt Pusateri
no flags Details
Group name appearing as decription in CFME (155.89 KB, image/png)
2017-04-24 20:15 UTC, Matt Pusateri
no flags Details

Description Kevin Morey 2016-10-27 13:37:12 UTC
Created attachment 1214615 [details]
ldap-group-pics

Description of problem:
ldap group lookout not populating the group description. In cfme

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. attempt to create a group using 'lookup ldap group'
2.
3.

Actual results:
groups are retreived successully but the description is not populated

Expected results:
Forcing the user to manually type in the group name

Additional info:

Comment 3 Joe Vlcek 2016-11-17 14:11:28 UTC
Why is this a blocker? Because there is a simple work around of having the user manually type in the group name from the retrieved list perhaps this should not be considered a blocker.

Comment 4 Dave Johnson 2016-11-17 16:01:23 UTC
I believe the concern is that there is potential for serious customer impact depending on how many groups they have here and better to fix.  In addition, this is something that SAs go through during POCs.

Comment 5 Joe Vlcek 2016-11-17 19:30:48 UTC
I've tested this and I think it is a UI bug because the backend is correctly
populating the dropdown with available groups. However when the administrator
selects the desired group from the dropdown the Description field on the form
is not being populated with the group name.

Moving to “Web UI"

Let me know if I can pair up with a UI person to show them the issue.

JoeV

Comment 8 CFME Bot 2016-11-18 14:51:19 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/4de20df2ab825d05be303bb82cfdc490f16381bc

commit 4de20df2ab825d05be303bb82cfdc490f16381bc
Author:     Aparna Karve <akarve>
AuthorDate: Thu Nov 17 16:39:41 2016 -0800
Commit:     Aparna Karve <akarve>
CommitDate: Thu Nov 17 16:39:41 2016 -0800

    Set the description with value in @edit[:new][:ldap_groups_user]
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1389359

 app/controllers/ops_controller/ops_rbac.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 9 CFME Bot 2016-11-20 14:01:00 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/8b2610800716f096aaa7b163d1730054cf062be1

commit 8b2610800716f096aaa7b163d1730054cf062be1
Author:     Dan Clarizio <dclarizi>
AuthorDate: Fri Nov 18 06:49:38 2016 -0800
Commit:     Oleg Barenboim <chessbyte>
CommitDate: Sun Nov 20 08:58:38 2016 -0500

    Merge pull request #12734 from AparnaKarve/bz1389359_populate_desc_with_group
    
    Populate the description field when the LDAP group for a user is selected
    (cherry picked from commit 735f29b2ba6c712300128b306990eef474b065e4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1389359

 app/controllers/ops_controller/ops_rbac.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 17 Matt Pusateri 2017-04-24 20:14:41 UTC
Created attachment 1273693 [details]
Group description as it appears in AD

Comment 18 Matt Pusateri 2017-04-24 20:15:20 UTC
Created attachment 1273694 [details]
Group name appearing as decription in CFME

Comment 19 Matt Pusateri 2017-04-24 20:19:03 UTC
Kevin,

Please look at the two screenshots I just uploaded.  When you say the description is not showing up, are you expecting to see the description as it appears in the LDAP(AD in the screenshot case) description field? Right now this fix just takes the group name and set's it as the description.  My personal opinion is that there is no reason to set the description to group name and as we see that group name already listed several places. And that the administrator would expect the description to match what is in the directory server for description.

Can you please weigh in on what the expectation when opening the bug is/was?

Thank you,

Matt P.

Comment 20 Joe Vlcek 2017-04-24 20:23:22 UTC
It looks as if you have proved the ldap group lookup is now populating the group description. In cfme

Perhaps some evaluation or maybe an RFE for CFME using the term `Description` when it might be better worded so as not to be confused with any possible AD `Group Descriptions` should be done in the future.

Thanks Matt!

JoeV

Comment 21 Matt Pusateri 2017-04-24 20:27:33 UTC
It's not just AD that has a description field. Really the question is what is expected by the users.

Comment 22 Joe Vlcek 2017-04-24 20:50:53 UTC
(In reply to Matt Pusateri from comment #21)
> It's not just AD that has a description field. Really the question is what
> is expected by the users.

The fix for this issue listed in Comment 8 returns the functionality to what the users were used to prior to an inadvertent change preventing the `Description` field from auto populating once a choice was selected from the pull down.

Comment 24 Matt Pusateri 2017-05-16 20:10:00 UTC
tested MIQLDAP FreeIPA(5.8.0.12-rc1) AD(5.8.0.11-beta2) Openldap(5.8.0.11-beta2) External Auth FreeIPA(5.8.0.12-rc1) AD(5.8.0.14-rc3) Openldap(5.8.0.14-rc3)


Note You need to log in before you can comment on or make changes to this bug.