Bug 1389658 - Certificate content in Routes warning message should be wrapped
Summary: Certificate content in Routes warning message should be wrapped
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 3.4.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Robb Hamilton
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-28 06:26 UTC by Yadan Pei
Modified: 2017-03-08 18:43 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: Routes popover warning messages are being truncated at the end of the string. Consequence: The relevant portion of the warning message is being truncated because the inclusion of the very long certificate content results in the warning message being truncated before the relevant portion of the warning message can be displayed. Fix: Change the truncation of the warning message from truncating at the end of the string to truncating in the middle of the string. Result: The relevant portion of the warning message is now visible.
Clone Of:
Environment:
Last Closed: 2017-01-18 12:47:16 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
MessageOverflow (100.12 KB, image/png)
2016-10-28 06:27 UTC, Yadan Pei
no flags Details
PartialContent (179.03 KB, image/png)
2016-11-01 06:50 UTC, Yadan Pei
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2017:0066 0 normal SHIPPED_LIVE Red Hat OpenShift Container Platform 3.4 RPM Release Advisory 2017-01-18 17:23:26 UTC

Description Yadan Pei 2016-10-28 06:26:37 UTC
Description of problem:
When create secure routes with invalid certificates,it will give warning message, in the warning info certificate content is shown but not wrapped

Version-Release number of selected component (if applicable):
v3.4.0.16

How reproducible:
Always

Steps to Reproduce:
1.Create Pod and Service
#oc create -f https://raw.githubusercontent.com/openshift-qe/v3-testfiles/master/routing/caddy-docker.json
#oc create -f https://raw.githubusercontent.com/openshift-qe/v3-testfiles/master/routing/edge/service_unsecure.json
2.Download certificate and key, route_edge-www.edge.com.crt is signed with unknown authority 
# curl -k -O https://raw.githubusercontent.com/openshift-qe/v3-testfiles/master/routing/edge/route_edge-www.edge.com.crt
# curl -k -O https://raw.githubusercontent.com/openshift-qe/v3-testfiles/master/routing/edge/route_edge-www.edge.com.key
3.Go to Routes page -> Create Route -> check "Secure route" -> Edge -> upload cert and key -> Create
4.Check route on Routes page

Actual results:
4.Routes will not be established successfully, hover the warning icon, certificate content will be shown but not wrapped, see attachment

Expected results:
4.Content in warning info should be displayed in correct format, it should wrap into lines when content length extends the boarder

Additional info:

Comment 1 Yadan Pei 2016-10-28 06:27:46 UTC
Created attachment 1214851 [details]
MessageOverflow

Comment 2 Jessica Forrester 2016-10-28 14:24:45 UTC
Steve I think this is just a general problem with our bootstrap popovers if they have long unbroken strings in them.

Comment 3 Robb Hamilton 2016-10-28 21:08:49 UTC
PR to resolve:  https://github.com/openshift/origin-web-console/pull/761

Comment 4 Troy Dawson 2016-10-31 18:21:29 UTC
This has been merged into ose and is in OSE v3.4.0.18 or newer.

Comment 6 Yadan Pei 2016-11-01 06:50:12 UTC
Checked against v3.4.0.18+ada983f

Now the long strings wraps into multiple lines, but for very long strings we couldn't see all its content even we scroll down, the popover content disappears when we scroll down.

Please check attachment

Comment 7 Yadan Pei 2016-11-01 06:50:49 UTC
Created attachment 1215991 [details]
PartialContent

Comment 8 Jessica Forrester 2016-11-01 13:02:14 UTC
We probably need to look into truncating these errors in the middle when they go beyond a certain length.  And then on the page for the route show the warnings in a warning alert instead of in the tooltip so that the user has a way to see the full message.

Comment 9 Jessica Forrester 2016-11-01 15:50:04 UTC
FYI routes shouldn't be failing validation on self-signed certs at all and there is a bug open for that https://bugzilla.redhat.com/show_bug.cgi?id=1389165

But there are still cases where the route will be rejected with very long messages so we still need to handle truncating these warnings.

Comment 10 Robb Hamilton 2016-11-02 17:43:47 UTC
PR to middle truncate  https://github.com/openshift/origin-web-console/pull/794

Comment 11 Jessica Forrester 2016-11-02 19:59:00 UTC
We are now truncating the message in the middle to hopefully catch the most relevant parts of the error messages.

Comment 12 Troy Dawson 2016-11-04 18:58:51 UTC
This has been merged into ose and is in OSE v3.4.0.22 or newer.
Moving on to QE since it's already on the errata.

Comment 13 Yadan Pei 2016-11-07 03:46:22 UTC
Checked against v3.4.0.22+5c56720

Now warning message are truncated to cover the most relevant parts of the error message, and we could see the full message


Move to VERIFIED

Comment 15 errata-xmlrpc 2017-01-18 12:47:16 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:0066


Note You need to log in before you can comment on or make changes to this bug.