Hide Forgot
Description of problem: A Automate model Git repository can be built without the parent domain directory. The Git import fails if the top level domain directory is not present. The __domain__.yaml file has all the properties needed to reconstitute the domain. Version-Release number of selected component (if applicable): How reproducible: 100% Steps to Reproduce: 1. Create a Git Repository with the contents of a domain directory without including the domain directory. 2. 3. Actual results: Import fails Expected results: Import should work with or without the top level domain directory. Additional info:
https://github.com/ManageIQ/manageiq/pull/12282
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/f3dc1dffb2cf1f4be42d0038983336a5ad30059c commit f3dc1dffb2cf1f4be42d0038983336a5ad30059c Author: Madhu Kanoor <mkanoor> AuthorDate: Fri Oct 28 14:53:08 2016 -0400 Commit: Madhu Kanoor <mkanoor> CommitDate: Fri Oct 28 16:19:32 2016 -0400 Support automate git repositories without domain directory https://bugzilla.redhat.com/show_bug.cgi?id=1389823 As long as we have a valid __domain__.yaml file we should be able to build the domain information. .../models/miq_ae_yaml_import.rb | 6 +- .../models/miq_ae_yaml_import_gitfs.rb | 13 +- .../models/miq_ae_yaml_import_gitfs_spec.rb | 186 ++++++++++++--------- 3 files changed, 126 insertions(+), 79 deletions(-)
New commit detected on ManageIQ/manageiq/euwe: https://github.com/ManageIQ/manageiq/commit/c8afb5a5f5f49750bf23feef0b2a0be999754dc2 commit c8afb5a5f5f49750bf23feef0b2a0be999754dc2 Author: Jason Frey <fryguy9> AuthorDate: Wed Nov 9 14:55:30 2016 -0500 Commit: Oleg Barenboim <chessbyte> CommitDate: Fri Nov 11 13:41:01 2016 -0500 Merge pull request #12282 from mkanoor/use_domain_name_from_yaml Support automate model git repositories without domain directory (cherry picked from commit d373743a9e9c91a52c2078a5287ccaddce658f0c) https://bugzilla.redhat.com/show_bug.cgi?id=1389823 .../models/miq_ae_yaml_import.rb | 6 +- .../models/miq_ae_yaml_import_gitfs.rb | 13 +- .../models/miq_ae_yaml_import_gitfs_spec.rb | 186 ++++++++++++--------- 3 files changed, 126 insertions(+), 79 deletions(-)
Verified in 5.8.0.3.20170301174324_1e2e0c4. Import from git without the parent domain directory works fine.