Bug 1389955 - Review Request: gnome-shell-extension-no-topleft-hot-corner - Disable the "hot corner" in GNOME Shell
Summary: Review Request: gnome-shell-extension-no-topleft-hot-corner - Disable the "ho...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-29 21:41 UTC by Audrey Yeena Toskin
Modified: 2017-04-05 23:18 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-03-30 00:21:52 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Audrey Yeena Toskin 2016-10-29 21:41:45 UTC
Spec URL: https://gitlab.com/terrycloth/gnome-shell-extension-rpms/blob/master/gnome-shell-extension-no-top-left-hot-corner.spec

SRPM URL: https://andrew.tosk.in/tmp/gnome-shell-extension-no-top-left-hot-corner-14.0-1.fc24.src.rpm

Description: No Topleft Hot Corner disables the hot corner in GNOME Shell, so that you don't accidentally trigger the Activities Overview anymore.

Fedora Account System Username: terrycloth

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-10-29 22:11:22 UTC
Spec URL: https://gitlab.com/terrycloth/gnome-shell-extension-rpms/raw/master/gnome-shell-extension-no-top-left-hot-corner.spec
SRPM URL: https://andrew.tosk.in/tmp/gnome-shell-extension-no-top-left-hot-corner-14.0-1.fc24.src.rpm

(The spec file link should be to the raw spec file, so tools like fedora-review work.)

Comment 2 Zbigniew Jędrzejewski-Szmek 2016-10-29 22:41:57 UTC
"Bugs specific to this RPM package can be filed on my GitLab page:
<https://gitlab.com/terrycloth/gnome-shell-extension-rpms>"
Please remove this part. Since this is to become an official fedora package, Fedora bugzilla should be used to track bugs.

+ latest version
+ package name is OK
+ builds and installs OK
+ provides/requires look correct
+ license is acceptable (GPLv2)
+ license is specified correctly
+ no scriptlets necessary

Package is APPROVED.

Comment 3 Audrey Yeena Toskin 2016-11-01 00:12:38 UTC
Spec URL: https://gitlab.com/terrycloth/packaging-gnome-shell-extension-no-top-left-hot-corner/raw/master/gnome-shell-extension-no-top-left-hot-corner.spec
SRPM URL: https://andrew.tosk.in/tmp/gnome-shell-extension-no-top-left-hot-corner-14.0-1.fc24.src.rpm

I've updated the spec and SRPM.

Note also that I renamed the GitLab repository; I didn't know that 1 package = 1 repo, so I changed the name to be more specific to the No Topleft Hot Corner extension.

Comment 4 Audrey Yeena Toskin 2016-11-14 05:02:54 UTC
Spec URL: https://gitlab.com/terrycloth/packaging-gnome-shell-extension-no-topleft-hot-corner/raw/master/gnome-shell-extension-no-topleft-hot-corner.spec
SRPM URL: https://andrew.tosk.in/tmp/gnome-shell-extension-no-topleft-hot-corner-14.0-1.fc24.src.rpm


I renamed the package and repository again. I'd originally spelled the package name with "top-left," because that's  how you normally spell these two separate words when used together. But  the extension "brands" itself as No Topleft Hot Corner, so it would be  better if I preserved the "Topleft" name.

Comment 6 Zbigniew Jędrzejewski-Szmek 2017-03-16 04:24:40 UTC
Ah, I set the fedora-review+ flag, but forgot to update other metadata. The review stands, please builds the package.

Comment 7 Gwyn Ciesla 2017-03-16 13:19:27 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gnome-shell-extension-no-topleft-hot-corner

Comment 8 Audrey Yeena Toskin 2017-03-18 00:20:05 UTC
I'd thought I would also build for EPEL -- No Topleft Hot Corner is apparently compatible with versions of GNOME Shell as old as 3.8, which means it should work with CentOS/RHEL 7, which I believe are on GNOME 3.14.

However, EPEL 7 builds apparently don't support the Recommends spec tag?

  https://kojipkgs.fedoraproject.org//work/tasks/3437/18443437/build.log

And other incompatibilities seem likely. So I'm thinking of maybe removing the EPEL 7 branch...

Comment 9 Fedora Update System 2017-03-18 00:28:44 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e5a2ee917e

Comment 10 Fedora Update System 2017-03-18 00:28:51 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6700283bd3

Comment 11 Fedora Update System 2017-03-18 00:28:55 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6ed2ac0da9

Comment 12 Zbigniew Jędrzejewski-Szmek 2017-03-18 02:50:36 UTC
You can just wrap the Recommends in %if 0%{?fedora} ... %endif.

Comment 13 Fedora Update System 2017-03-19 01:48:26 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6ed2ac0da9

Comment 14 Fedora Update System 2017-03-19 02:22:34 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e5a2ee917e

Comment 15 Fedora Update System 2017-03-19 14:22:17 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6700283bd3

Comment 16 Fedora Update System 2017-03-21 03:26:02 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3f803eecff

Comment 17 Fedora Update System 2017-03-21 03:26:09 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-dc9a888e36

Comment 18 Fedora Update System 2017-03-21 03:26:14 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2cf84e0e7d

Comment 19 Fedora Update System 2017-03-21 03:26:19 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-c340eeff19

Comment 20 Fedora Update System 2017-03-21 14:26:20 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2cf84e0e7d

Comment 21 Fedora Update System 2017-03-21 17:17:40 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-c340eeff19

Comment 22 Fedora Update System 2017-03-21 17:53:11 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-dc9a888e36

Comment 23 Fedora Update System 2017-03-21 17:54:59 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3f803eecff

Comment 24 Fedora Update System 2017-03-30 00:21:52 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 25 Fedora Update System 2017-03-30 01:20:21 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 26 Fedora Update System 2017-04-01 17:20:02 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 27 Fedora Update System 2017-04-05 23:18:07 UTC
gnome-shell-extension-no-topleft-hot-corner-14.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.