Spec URL: https://gil.fedorapeople.org/jsonassert.spec SRPM URL: https://gil.fedorapeople.org/jsonassert-1.4.0-1.fc24.src.rpm Description: JSONassert extends JUnit to write powerful JSON unit tests in very little code. Code JSON tests as if you are comparing a string. Under the covers, JSONassert converts your string into a JSON object and compares the logical structure and data with the actual JSON. Fedora Account System Username: gil Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16258818 Spring Framework 4.x dependency (spring-test)
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. There is an upstream bug about the licensing, so most files are "unknown". However the main license file agrees with the package licensing. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache (v2.0)". 36 files have unknown license. Detailed output of licensecheck in /var/tmp/1390156-jsonassert/licensecheck.txt See above. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. Sources are all java files, so looks fine. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. It's not a Java library but a "JUnit extension", and the name is the same as upstream, so it seems legit. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. Javadoc subpackage actually, but this is OK. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant It has a jsonassert.pom file which is installed. It builds using maven not ant. [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jsonassert-javadoc I'm not clear if this is a problem or not? [?]: Package functions as described. [x]: Latest version is packaged. Yes, 1.4.0 is the latest release upstream. [-]: Package does not include license text files separate from upstream. Strange double-negative review point, not sure what this means, but in any case the licensing is fine. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. Java so no problem there. [-]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jsonassert-1.4.0-1.fc26.noarch.rpm jsonassert-javadoc-1.4.0-1.fc26.noarch.rpm jsonassert-1.4.0-1.fc26.src.rpm jsonassert.noarch: W: spelling-error Summary(en_US) JUnit -> J Unit, Unit, Jun it jsonassert.src: W: spelling-error Summary(en_US) JUnit -> J Unit, Unit, Jun it 3 packages and 0 specfiles checked; 0 errors, 2 warnings. You can ignore these. Rpmlint (installed packages) ---------------------------- jsonassert.noarch: W: spelling-error Summary(en_US) JUnit -> J Unit, Unit, Jun it 2 packages and 0 specfiles checked; 0 errors, 1 warnings. You can ignore this. Requires -------- jsonassert (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.json:json) jsonassert-javadoc (rpmlib, GLIBC filtered): javapackages-tools Provides -------- jsonassert: jsonassert mvn(org.skyscreamer:jsonassert) mvn(org.skyscreamer:jsonassert:pom:) jsonassert-javadoc: jsonassert-javadoc Source checksums ---------------- https://github.com/skyscreamer/JSONassert/archive/jsonassert-1.4.0.tar.gz : CHECKSUM(SHA256) this package : 6561efb390999d3d8ad92bde796f88d0eb0faec63bb279edc465a66761992059 CHECKSUM(SHA256) upstream package : 6561efb390999d3d8ad92bde796f88d0eb0faec63bb279edc465a66761992059 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1390156 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Everything looks fine except for: [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jsonassert-javadoc Could you check if this is a problem or not? I have no idea.
(In reply to Richard W.M. Jones from comment #1) > Generic: > [x]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > There is an upstream bug about the licensing, so most files are > "unknown". However the main license file agrees with the package > licensing. > > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated", "*No copyright* Apache (v2.0)". 36 > files have unknown license. Detailed output of licensecheck in > /var/tmp/1390156-jsonassert/licensecheck.txt > See above. Open https://github.com/skyscreamer/JSONassert/issues/70 for this problem (and also a PR), waiting upstream response ... (In reply to Richard W.M. Jones from comment #2) > Everything looks fine except for: > > [ ]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in > jsonassert-javadoc > > Could you check if this is a problem or not? I have no idea. This a "noarch" package. and use the _isa notation, in this case, that not make sense
[x]: Fully versioned dependency in subpackages if applicable. ==> Packaged APPROVED by RWMJ.
Please set the "Assigned To" field
Thanks for the review! create new SCM request/s: https://admin.fedoraproject.org/pkgdb/package/requests/8586 https://admin.fedoraproject.org/pkgdb/package/requests/8587
create new SCM request/s: https://admin.fedoraproject.org/pkgdb/package/requests/8588 https://admin.fedoraproject.org/pkgdb/package/requests/8589
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/jsonassert
jsonassert-1.4.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-15dbccbf42
jsonassert-1.4.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-15dbccbf42
jsonassert-1.4.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.