Bug 1390498 - [v4 REST-API] Read only Attribute is missing from /api/disks/{disk id}/ or from /api/vms/{vm id}/diskattachments/{diskattachments id}
Summary: [v4 REST-API] Read only Attribute is missing from /api/disks/{disk id}/ or fr...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: RestAPI
Version: 4.0.5.1
Hardware: Unspecified
OS: Unspecified
high
high vote
Target Milestone: ovirt-4.1.2
: 4.1.2
Assignee: Tal Nisan
QA Contact: Lilach Zitnitski
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-01 09:03 UTC by Eyal Shenitzky
Modified: 2017-05-23 08:14 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-05-23 08:14:18 UTC
oVirt Team: Storage
rule-engine: ovirt-4.1+
ylavi: blocker+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 75362 0 master MERGED restapi: Show read only property on disk attachments 2017-04-20 12:21:00 UTC
oVirt gerrit 75363 0 master MERGED Add read only property to disk attachments 2017-04-17 08:26:51 UTC
oVirt gerrit 75394 0 ovirt-engine-4.1 MERGED restapi: Update to model 4.1.35 and metamodel 1.1.14 2017-04-19 13:32:27 UTC
oVirt gerrit 75601 0 model_4.1 MERGED Add read only property to disk attachments 2017-04-18 14:24:53 UTC
oVirt gerrit 75646 0 master MERGED restapi: Update to model 4.2.10 2017-04-19 13:28:28 UTC
oVirt gerrit 75689 0 ovirt-engine-4.1 MERGED restapi: Show read only property on disk attachments 2017-04-20 13:28:02 UTC

Description Eyal Shenitzky 2016-11-01 09:03:02 UTC
Description of problem:

Read only Attribute is missing from /api/disks/{disk id}/ 
or from /api/vms/{vm id}/diskattachments/{diskattachments id}

Version-Release number of selected component (if applicable):
Engine - 4.0.5.1-0.1.el7ev

How reproducible:
100%

Steps to Reproduce:
1. Create a VM with read-only disk attached
2. Check /api/disks/{disk id}/
3. Check /api/vms/{vm id}/diskattachments/{diskattachments id}

Actual results:
Read-only Attribute is missing

Expected results:
Read-only attribute should found under /api/disks/{disk id}/

Additional info:

Comment 1 Allon Mureinik 2016-11-01 12:53:19 UTC
The RO attribute was never moved to diskattachments, although logically it definitely belongs there.
Targeting for 4.1.

Comment 2 Raz Tamir 2016-12-26 09:26:37 UTC
This blocks all our 4.1 read only disks testing - changed the severity to high

Comment 3 Red Hat Bugzilla Rules Engine 2016-12-26 09:26:42 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 4 Yaniv Kaul 2017-01-02 19:09:06 UTC
(In reply to Raz Tamir from comment #2)
> This blocks all our 4.1 read only disks testing - changed the severity to
> high

Does it work with v3 API?

Comment 5 Eyal Shenitzky 2017-01-04 07:07:02 UTC
In V3 there is no diskattachment object, the read only attribute was under /api/disks/{disk id}/

Comment 6 Red Hat Bugzilla Rules Engine 2017-01-15 13:37:40 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 7 Yaniv Lavi 2017-02-23 11:25:52 UTC
Moving out all non blocker\exceptions.

Comment 8 Allon Mureinik 2017-04-20 16:17:13 UTC
Tal, do we need to document anything here, or is the API self-documenting?

Comment 9 Tal Nisan 2017-04-23 08:21:55 UTC
All relevant documentation is in the API

Comment 10 Lilach Zitnitski 2017-04-27 07:53:24 UTC
--------------------------------------
Tested with the following code:
----------------------------------------
rhevm-4.1.2-0.1.el7.noarch
vdsm-4.19.11-1.el7ev.x86_64

Tested with the following scenario:

Steps to Reproduce:
1. Create a VM with read-only disk attached
2. Check /api/vms/{vm id}/diskattachments/{diskattachments id}

Actual results:
Read_only attribute is found under /api/vms/{vm id}/diskattachments/{disk id}

Expected results:

Moving to VERIFIED!


Note You need to log in before you can comment on or make changes to this bug.