Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1390498

Summary: [v4 REST-API] Read only Attribute is missing from /api/disks/{disk id}/ or from /api/vms/{vm id}/diskattachments/{diskattachments id}
Product: [oVirt] ovirt-engine Reporter: Eyal Shenitzky <eshenitz>
Component: RestAPIAssignee: Tal Nisan <tnisan>
Status: CLOSED CURRENTRELEASE QA Contact: Lilach Zitnitski <lzitnits>
Severity: high Docs Contact:
Priority: high    
Version: 4.0.5.1CC: amureini, bugs, eshenitz, lveyde, ratamir, tnisan, ylavi
Target Milestone: ovirt-4.1.2Keywords: Automation, AutomationBlocker
Target Release: 4.1.2Flags: rule-engine: ovirt-4.1+
ylavi: blocker+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-05-23 08:14:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Eyal Shenitzky 2016-11-01 09:03:02 UTC
Description of problem:

Read only Attribute is missing from /api/disks/{disk id}/ 
or from /api/vms/{vm id}/diskattachments/{diskattachments id}

Version-Release number of selected component (if applicable):
Engine - 4.0.5.1-0.1.el7ev

How reproducible:
100%

Steps to Reproduce:
1. Create a VM with read-only disk attached
2. Check /api/disks/{disk id}/
3. Check /api/vms/{vm id}/diskattachments/{diskattachments id}

Actual results:
Read-only Attribute is missing

Expected results:
Read-only attribute should found under /api/disks/{disk id}/

Additional info:

Comment 1 Allon Mureinik 2016-11-01 12:53:19 UTC
The RO attribute was never moved to diskattachments, although logically it definitely belongs there.
Targeting for 4.1.

Comment 2 Raz Tamir 2016-12-26 09:26:37 UTC
This blocks all our 4.1 read only disks testing - changed the severity to high

Comment 3 Red Hat Bugzilla Rules Engine 2016-12-26 09:26:42 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 4 Yaniv Kaul 2017-01-02 19:09:06 UTC
(In reply to Raz Tamir from comment #2)
> This blocks all our 4.1 read only disks testing - changed the severity to
> high

Does it work with v3 API?

Comment 5 Eyal Shenitzky 2017-01-04 07:07:02 UTC
In V3 there is no diskattachment object, the read only attribute was under /api/disks/{disk id}/

Comment 6 Red Hat Bugzilla Rules Engine 2017-01-15 13:37:40 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 7 Yaniv Lavi 2017-02-23 11:25:52 UTC
Moving out all non blocker\exceptions.

Comment 8 Allon Mureinik 2017-04-20 16:17:13 UTC
Tal, do we need to document anything here, or is the API self-documenting?

Comment 9 Tal Nisan 2017-04-23 08:21:55 UTC
All relevant documentation is in the API

Comment 10 Lilach Zitnitski 2017-04-27 07:53:24 UTC
--------------------------------------
Tested with the following code:
----------------------------------------
rhevm-4.1.2-0.1.el7.noarch
vdsm-4.19.11-1.el7ev.x86_64

Tested with the following scenario:

Steps to Reproduce:
1. Create a VM with read-only disk attached
2. Check /api/vms/{vm id}/diskattachments/{diskattachments id}

Actual results:
Read_only attribute is found under /api/vms/{vm id}/diskattachments/{disk id}

Expected results:

Moving to VERIFIED!