Bug 1390870 - DHT: Rebalance- Misleading log messages from __dht_check_free_space function
Summary: DHT: Rebalance- Misleading log messages from __dht_check_free_space function
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: distribute
Version: 3.8
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: ankit
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-02 07:17 UTC by ankit
Modified: 2016-11-29 09:37 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.8.6
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-29 09:37:17 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description ankit 2016-11-02 07:17:38 UTC
+++ This bug was initially created as a clone of Bug #1167789 +++
+++ This bug was initially created as a clone of Bug #1341948 +++

Description of problem:
misleading message from logs about available disk space

Version-Release number of selected component (if applicable):
3.6.0.33-1.el6rhs.x86_64

How reproducible:
always

Steps to Reproduce:
1. create a volume and data 
2. add one more brick , make sure that there is some space discrepancy 
3. start the rebalance without force option
gluster volume rebalance <vol> start 
4. check the status of rebalance and make sure that some skipped files are there

Actual results:
2014-11-25 09:10:32.433141] I [dht-rebalance.c:902:dht_migrate_file] 0-gs-dht: /file9: attempting to move from gs-client-0 to gs-client-4
[2014-11-25 09:10:32.437164] W [MSGID: 109023] [dht-rebalance.c:568:__dht_check_free_space] 0-gs-dht: data movement attempted from node (gs-client-0:209540896) with higher disk space to a node (gs-client-4:209540960) with lesser disk space, file { blocks:2048, name:(/file9) }


[2014-11-25 09:10:32.438441] I [dht-common.c:1563:dht_lookup_everywhere_cbk] 0-gs-dht: attempting deletion of stale linkfile /file10 on gs-client-4 (hashed subvol is gs-client-6)



Here available space on source is gs-client-0:209540896 and on destination is gs-client-4:209540960 but log says source has higher space and destination has lesser which is misleading .

since calculation of free space is done in the following way

if ((dst_statfs_blocks - stbuf->ia_blocks) <
    (src_statfs_blocks + stbuf->ia_blocks)) 


the proper values has to be printed in the logs

--- Additional comment from RHEL Product and Program Management on 2014-11-25 07:53:37 EST ---

Since this issue was entered in bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

--- Additional comment from Sakshi on 2015-04-22 09:03:44 EDT ---

What is the size of the brick? Also what do you mean by space discrepancy? Should the brick added later be lesser in size compared to the existing bricks?

Comment 1 Worker Ant 2016-11-02 07:41:49 UTC
REVIEW: http://review.gluster.org/15765 (dht: Proper log message if data migration is skipped) posted (#1) for review on release-3.8 by ankitraj

Comment 2 Worker Ant 2016-11-03 04:22:14 UTC
REVIEW: http://review.gluster.org/15765 (dht: Proper log message if data migration is skipped There was a misleading message from logs about available disk space while rebalancing of bricks while calculating free space.) posted (#2) for review on release-3.8 by ankitraj

Comment 3 Worker Ant 2016-11-03 05:33:06 UTC
COMMIT: http://review.gluster.org/15765 committed in release-3.8 by Raghavendra G (rgowdapp) 
------
commit d54f8d96f18f23568221e765e9cd2189f686af80
Author: ankitraj <anraj>
Date:   Wed Nov 2 13:04:24 2016 +0530

    dht: Proper log message if data migration is skipped
    There was a misleading message from logs about
    available disk space while rebalancing of bricks
    while calculating free space.
    
    Bug: 1390870
    
    Backprt of http://review.gluster.org/#/c/15345/
    
    Change-Id: Ie9df0b2cbf00faaf13a0a3f0dbd657377a082755
    Signed-off-by: ankitraj <anraj>
    Reviewed-on: http://review.gluster.org/15765
    Tested-by: ankitraj
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 4 Niels de Vos 2016-11-29 09:37:17 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.6, please open a new bug report.

glusterfs-3.8.6 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://www.gluster.org/pipermail/packaging/2016-November/000217.html
[2] https://www.gluster.org/pipermail/gluster-users/


Note You need to log in before you can comment on or make changes to this bug.