Bug 1390936 - [CodeChange] move vdsm calls (mostly removeImage) from transactional endAction()
Summary: [CodeChange] move vdsm calls (mostly removeImage) from transactional endAction()
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.1.0
Hardware: All
OS: Linux
high
high vote
Target Milestone: ovirt-4.2.1
: ---
Assignee: Fred Rolland
QA Contact: Elad
URL:
Whiteboard:
Depends On:
Blocks: 1455871
TreeView+ depends on / blocked
 
Reported: 2016-11-02 09:46 UTC by Liron Aravot
Modified: 2019-04-28 13:54 UTC (History)
15 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1372743
: 1455871 (view as bug list)
Environment:
Last Closed: 2018-03-12 12:46:18 UTC
oVirt Team: Storage
rule-engine: ovirt-4.2?
rule-engine: ovirt-4.3?
rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1372743 0 high CLOSED Database transaction cancellations result in failed moveImage operations 2021-02-22 00:41:40 UTC

Internal Links: 1372743

Description Liron Aravot 2016-11-02 09:46:06 UTC 
Currently some flows has vdsm calls (mostly removeImage) performed on the endAction() method. If the endAction() is executed within transaction we might get a transaction timeout on some scenarios.
This RFE is about moving those calls out of the endAction() - In order to do that:
1. Our "COCO-Storage" infrastructure (serial callback) needs to be modified to support moving vdsm calls out of endWithFailure().
2. The relevant flows needs to start using the COCO infrastructure instead of relying on the tasks infrastructure.
Comment 1 Yaniv Lavi 2016-11-23 08:30:11 UTC 
Can you describe the functional impact?
Comment 2 Liron Aravot 2016-12-22 16:02:06 UTC 
Sure,
The functional impact is that we may get transaction timeouts when executing vdsm calls within transactional endAction(). 
In BZ 1372743 (see https://bugzilla.redhat.com/show_bug.cgi?id=1372743#c22) it caused us to remain with a locked disk.

Let me know if further info is needed.

Thanks,
Liron
Comment 3 Yaniv Lavi 2016-12-28 12:39:09 UTC 
Tal, I'm treating this as code change. Please decide on a target for it.
Comment 6 Yaniv Kaul 2018-03-12 10:03:59 UTC 
Downstream clone is VERIFIED, but this is on NEW?
Note You need to log in before you can comment on or make changes to this bug.