Bug 1391016 - [User Portal] When creating template in User Portal one can use Custom Properties
Summary: [User Portal] When creating template in User Portal one can use Custom Proper...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.UserPortal
Version: 4.0.5.5
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.1.0-beta
: 4.1.0.2
Assignee: Tomas Jelinek
QA Contact: Jiri Belka
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-02 12:05 UTC by Jiri Belka
Modified: 2017-02-01 14:34 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-01 14:34:39 UTC
oVirt Team: Virt
Embargoed:
rule-engine: ovirt-4.1+
rule-engine: planning_ack+
tjelinek: devel_ack+
pstehlik: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 69751 0 master MERGED userportal: don't show custom properties in user portal 2017-01-06 14:32:48 UTC
oVirt gerrit 69763 0 ovirt-engine-4.1 MERGED userportal: don't show custom properties in user portal 2017-01-09 10:44:22 UTC

Description Jiri Belka 2016-11-02 12:05:29 UTC
Description of problem:

When creating template in User Portal one can use Custom Properties, ie. UserDefinedVMProperties.

This could be serious as if there would be qemucmdline vdsm hook installed on hosts, then the user with TemplateCreator could modify VM's qemu process arguments and so bad things (eg. add another net ifaces, bypass bridges, initialize connections from _inside_ to remote hosts etc. etc...).

UserDefinedVMProperties: qemu_cmdline=^.*$ version: 4.0

Thus this can be a security issue if some conditions are met.

Version-Release number of selected component (if applicable):
ovirt-engine-userportal-4.0.5.4-0.1.el7ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. add an user with TemplateCreator to system and assign him a VM
2. login with this user to User Portal
3. create template

Actual results:
an user could modify custom properties when editing newly create template in user portal

Expected results:
custom properties should be filtered in template editing

Additional info:
maybe this should be available only for real admin roles (icon with sunglasses)

Comment 1 Jiri Belka 2016-11-02 12:34:53 UTC
I managed to modify qemu args successfully and this caused qemu process to connect to my server on Internet, thus access to VM from outside.

Comment 2 Jiri Belka 2017-01-23 16:42:58 UTC
ok, ovirt-engine-userportal-4.1.0.1-0.1.el7.noarch

not visible anymore for for templatecreator->templateowner.


Note You need to log in before you can comment on or make changes to this bug.