Bug 1391220 - "abandon changes" dialog appears on attempt to open another location via menu from timelines page
Summary: "abandon changes" dialog appears on attempt to open another location via menu...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.7.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: GA
: 5.8.0
Assignee: Harpreet Kataria
QA Contact: Ievgen Zapolskyi
URL:
Whiteboard: general:trivial:general:usability:ui:...
Depends On:
Blocks: 1414015
TreeView+ depends on / blocked
 
Reported: 2016-11-02 19:52 UTC by Ievgen Zapolskyi
Modified: 2017-06-12 16:32 UTC (History)
4 users (show)

Fixed In Version: 5.8.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1414015 (view as bug list)
Environment:
Last Closed: 2017-06-12 16:32:05 UTC
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
abandon changes dialog (152.27 KB, image/png)
2016-11-02 19:52 UTC, Ievgen Zapolskyi
no flags Details

Description Ievgen Zapolskyi 2016-11-02 19:52:00 UTC
Created attachment 1216716 [details]
abandon changes dialog

Description of problem:
When I try to open f.e. Compute->Infrastructure->Hosts from already opened Timelines for vm, I see "abandon changes" dialog.
Timelines doesn't have any changes except display/filter settings. 
Furthermore, when I leave this page in usual way, the display/filter settings aren't stored/restored as well. 
So, there is no reason for such dialog. 


Version-Release number of selected component (if applicable):
6.7.0.9

How reproducible:
100%

Steps to Reproduce:
1. Open Timelines for any vm 
2. Change default Timelines display settings and click Apply button
3. Try to go to f.e. Compute->Infrastructure->Hosts location thru menu

Actual results:
"Abandon changes" dialog appears

Expected results:
Such dialog shouldn't appear there.
If it is supposed that Timilines display settings have to be stored/restored before leaving Timelines page, those changes have to be stored silently w/o such dialog.

Comment 2 Harpreet Kataria 2017-01-12 21:40:59 UTC
https://github.com/ManageIQ/manageiq-ui-classic/pull/146

Comment 3 CFME Bot 2017-01-16 12:22:46 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:
https://github.com/ManageIQ/manageiq-ui-classic/commit/bb666e33f299951b1f5b24865e07004d49c7ba0b

commit bb666e33f299951b1f5b24865e07004d49c7ba0b
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Jan 12 16:34:48 2017 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Jan 12 16:34:48 2017 -0500

    Confirmation popup is not needed on timelines screen.
    
    "Abandon changes?" confirmation is not needed when leaving Timelines screen
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1391220

 app/assets/javascripts/miq_application.js | 4 +++-
 app/views/layouts/_tl_options.html.haml   | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)


Note You need to log in before you can comment on or make changes to this bug.