Bug 1391463 - VM's disk removal is not logged in VM's Events subtab
Summary: VM's disk removal is not logged in VM's Events subtab
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.0.5.5
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ovirt-4.1.0-beta
: 4.1.0.2
Assignee: Tal Nisan
QA Contact: Raz Tamir
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-03 11:27 UTC by Jiri Belka
Modified: 2017-02-01 14:49 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-01 14:49:20 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.1+
rule-engine: planning_ack+
rule-engine: devel_ack+
ratamir: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 69464 0 master MERGED core: Remove ternary operator usage in RemoveDiskCommand audit log 2017-01-05 10:11:34 UTC
oVirt gerrit 69465 0 master MERGED core: Upon disk removal log its attached VMs 2017-01-05 10:11:31 UTC
oVirt gerrit 69696 0 ovirt-engine-4.1 MERGED core: Remove ternary operator usage in RemoveDiskCommand audit log 2017-01-09 10:12:48 UTC
oVirt gerrit 69697 0 ovirt-engine-4.1 MERGED core: Upon disk removal log its attached VMs 2017-01-09 10:12:42 UTC

Description Jiri Belka 2016-11-03 11:27:20 UTC
Description of problem:

When one removes a disk from a VM the event is not logged into the VM Events subtab. Pretty odd, problematic to understand history actions on such VM.

~~~
...
 The disk fff_Disk1 was successfully added to VM fff.
 Add-Disk operation of fff_Disk1 was initiated on VM fff by admin@internal-authz.
 Disk fff_Disk1 was successfully removed from domain jb-rhevm40 (User user1.com.com).
(2631 rows)
~~~

There must be obviously missing some "glue" between this disk and the VM.

Version-Release number of selected component (if applicable):
ovirt-engine-backend-4.0.5.5-0.1.el7ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. Have a VM with a disk, not running
2. remove the disk from VM's Disk subtab -> Remove
3. monitor Events subtab

Actual results:
missing any info about VM's disk removal

Expected results:
should be there, it does make sense

Additional info:

Comment 1 Jiri Belka 2016-11-03 11:28:04 UTC
applies to User Portal as well, it was in fact discovered there

Comment 3 Tal Nisan 2016-11-06 08:23:50 UTC
This behavior is intentional since the problem in this case is that a disk can be attached to multiple VMs at the same time, so it doesn't make much sense to log all the VMs it is attached to at the time of deletion.
On the other hand logging only the VM from the deletion "content" (i.e. if we are deleting from a specific VM disks tab) doesn't make much sense as it gives partial data.

Comment 4 Tal Nisan 2016-11-17 12:24:11 UTC
After an offline discussion with QE it has been decided that if the disk was attached to VMs at the time of removal the event log will be changed to something similar to:

Disk ${DiskAlias} associated to VMs ${VmNames} was successfully removed from domain ${StorageDomainName}”

Comment 5 Raz Tamir 2017-01-22 16:53:20 UTC
Verified on ovirt-engine-4.1.0.3-0.0.master.20170122091652.gitc6fc2c2.el7.centos

Remove a Disk from VM's disks sub tab and in the event log:

Disk golden_env_mixed_virtio_3_1_Disk1 associated to the VMs golden_env_mixed_virtio_3_1 was successfully removed from domain iscsi_0


Note You need to log in before you can comment on or make changes to this bug.