Bug 1391716 - rhel-osp-director: regular expression not honored when specifying node in minor update
Summary: rhel-osp-director: regular expression not honored when specifying node in m...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: rhosp-director
Version: 10.0 (Newton)
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ga
: 10.0 (Newton)
Assignee: Angus Thomas
QA Contact: Omri Hochman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-03 20:19 UTC by Alexander Chuzhoy
Modified: 2016-12-29 16:54 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-08 07:03:22 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Alexander Chuzhoy 2016-11-03 20:19:40 UTC
rhel-osp-director:   regular expression not honored when specifying node in minor update

Environment:
openstack-puppet-modules-9.3.0-1.el7ost.noarch
instack-undercloud-5.0.0-2.el7ost.noarch
openstack-tripleo-heat-templates-5.0.0-1.2.el7ost.noarch

Steps to reproduce:
Note: this environment was already updated, but it shouldn't matter.

1. Try to run minor update and note the regex used to explicitly specify nodes to run the update on.

[stack@instack ~]$ openstack overcloud update stack  -i overcloud        

starting package update on stack overcloud
WAITING                                   
not_started: [u'overcloud-compute-0', u'overcloud-cephstorage-0', u'overcloud-controller-0']
on_breakpoint: [u'overcloud-controller-2', u'overcloud-controller-1']                       
Breakpoint reached, continue? Regexp or Enter=proceed (will clear d955983f-4405-4f63-ab6c-848d038d4924), no=cancel update, C-c=quit interactive mode: IN_PROGRESS
overcloud-cephstorage-0                                                                                                                                          
IN_PROGRESS                                                                                                                                                      
WAITING                                                                                                                                                          
completed: [u'overcloud-controller-1']                                                                                                                           
on_breakpoint: [u'overcloud-cephstorage-0', u'overcloud-compute-0', u'overcloud-controller-2', u'overcloud-controller-0']                                        
Breakpoint reached, continue? Regexp or Enter=proceed (will clear af95276d-de2d-4320-adc6-5f270471c910), no=cancel update, C-c=quit interactive mode: overcloud-cephstorage-0
WAITING                                                                                                                                                                      
completed: [u'overcloud-cephstorage-0', u'overcloud-controller-1']                                                                                                           
on_breakpoint: [u'overcloud-compute-0', u'overcloud-controller-2', u'overcloud-controller-0']                                                                                
Breakpoint reached, continue? Regexp or Enter=proceed (will clear af95276d-de2d-4320-adc6-5f270471c910), no=cancel update, C-c=quit interactive mode: overcloud-compute-0    
WAITING                                                                                                                                                                      
completed: [u'overcloud-cephstorage-0', u'overcloud-controller-1']                                                                                                           
on_breakpoint: [u'overcloud-compute-0', u'overcloud-controller-2', u'overcloud-controller-0']                                                                                
Breakpoint reached, continue? Regexp or Enter=proceed (will clear af95276d-de2d-4320-adc6-5f270471c910), no=cancel update, C-c=quit interactive mode: overcloud-compute-0    
WAITING                                                                                                                                                                      
completed: [u'overcloud-compute-0', u'overcloud-cephstorage-0', u'overcloud-controller-1']                                                                                   
on_breakpoint: [u'overcloud-controller-2', u'overcloud-controller-0']
Breakpoint reached, continue? Regexp or Enter=proceed (will clear af95276d-de2d-4320-adc6-5f270471c910), no=cancel update, C-c=quit interactive mode: WAITING
completed: [u'overcloud-compute-0', u'overcloud-cephstorage-0', u'overcloud-controller-1']
on_breakpoint: [u'overcloud-controller-2', u'overcloud-controller-0']
Breakpoint reached, continue? Regexp or Enter=proceed (will clear af95276d-de2d-4320-adc6-5f270471c910), no=cancel update, C-c=quit interactive mode: overcloud-controller-0
IN_PROGRESS
IN_PROGRESS
WAITING
completed: [u'overcloud-controller-0', u'overcloud-compute-0', u'overcloud-cephstorage-0', u'overcloud-controller-1']
on_breakpoint: [u'overcloud-controller-2']
Breakpoint reached, continue? Regexp or Enter=proceed (will clear 9081cdd3-2445-45e5-afc9-4b039fe27545), no=cancel update, C-c=quit interactive mode: overcloud-controller-1
WAITING
completed: [u'overcloud-controller-0', u'overcloud-compute-0', u'overcloud-cephstorage-0', u'overcloud-controller-1']
on_breakpoint: [u'overcloud-controller-2']
Breakpoint reached, continue? Regexp or Enter=proceed (will clear 9081cdd3-2445-45e5-afc9-4b039fe27545), no=cancel update, C-c=quit interactive mode: overcloud-controller-2
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS

IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
IN_PROGRESS
COMPLETE
update finished with status COMPLETE

Comment 1 Alexander Chuzhoy 2016-11-03 20:22:34 UTC
Note the following in comment #0

on_breakpoint: [u'overcloud-compute-0', u'overcloud-controller-2', u'overcloud-controller-0']                                                                                
Breakpoint reached, continue? Regexp or Enter=proceed (will clear af95276d-de2d-4320-adc6-5f270471c910), no=cancel update, C-c=quit interactive mode: overcloud-compute-0    
WAITING                                                                                                                                                                      
completed: [u'overcloud-cephstorage-0', u'overcloud-controller-1']                                                                                                           
on_breakpoint: [u'overcloud-compute-0', u'overcloud-controller-2', u'overcloud-controller-0'] 



Expected result:
overcloud-compute-0 should be completed.

Comment 3 Marios Andreou 2016-11-04 11:05:17 UTC
Clearing the breakpoints does not dictate the order in which a node will be updated but that there will be no pause before that node is updated. So if you clear breakpoints from 3 compute nodes for example, then their update can proceed w/out user prompt and simultaneously. 

You cannot dictate which node will be updated next, this is randomly chosen. 
I don't think this is a bug.

Comment 4 Alexander Chuzhoy 2016-11-04 16:29:15 UTC
This is what I understand from below:

Section 2.3 in https://access.redhat.com/documentation/en/red-hat-openstack-platform/9/paged/upgrading-red-hat-openstack-platform/chapter-2-director-based-
environments-performing-updates-to-minor-versions
"
Press Enter to clear the breakpoint from last node on the on_breakpoint list. This begins the update for that node. You can also type a node name to clear a breakpoint on a specific node, or a regular expression to clear breakpoints on multiple nodes at once.
"

Comment 7 Jaromir Coufal 2016-11-07 16:56:03 UTC
Seems like adjusting docs to specify correct expectations should be enough. Sasha, can you verify the behavior sync with our docs team to put together update to our documentation text? Thanks

Comment 8 Alexander Chuzhoy 2016-11-07 22:24:41 UTC
So the issue didn't reproduce and I got exactly what I expected:

on_breakpoint: [u'overcloud-compute-0', u'overcloud-serviceapi-1', u'overcloud-controller-2', u'overcloud-cephstorage-0', u'overcloud-controller-1', u'overcloud-objectstorage-0', u'overcloud-controller-0', u'overcloud-serviceapi-0', u'overcloud-serviceapi-2']
Breakpoint reached, continue? Regexp or Enter=proceed (will clear f4ff235d-6607-4835-9b43-f2be407d8cfe), no=cancel update, C-c=quit interactive mode: overcloud-compute-0
WAITING
completed: [u'overcloud-compute-0']
on_breakpoint: [u'overcloud-serviceapi-1', u'overcloud-controller-2', u'overcloud-cephstorage-0', u'overcloud-controller-1', u'overcloud-objectstorage-0', u'overcloud-controller-0', u'overcloud-serviceapi-0', u'overcloud-serviceapi-2']
Breakpoint reached, continue? Regexp or Enter=proceed (will clear f4ff235d-6607-4835-9b43-f2be407d8cfe), no=cancel update, C-c=quit interactive mode: overcloud-controller-2
IN_PROGRESS
WAITING
completed: [u'overcloud-compute-0', u'overcloud-controller-2']
on_breakpoint: [u'overcloud-serviceapi-1', u'overcloud-cephstorage-0', u'overcloud-controller-1', u'overcloud-objectstorage-0', u'overcloud-controller-0', u'overcloud-serviceapi-0', u'overcloud-serviceapi-2']
Breakpoint reached, continue? Regexp or Enter=proceed (will clear f4ff235d-6607-4835-9b43-f2be407d8cfe), no=cancel update, C-c=quit interactive mode: overcloud-objectstorage-0
WAITING
completed: [u'overcloud-compute-0', u'overcloud-controller-2', u'overcloud-objectstorage-0']
on_breakpoint: [u'overcloud-serviceapi-1', u'overcloud-cephstorage-0', u'overcloud-controller-1', u'overcloud-controller-0', u'overcloud-serviceapi-0', u'overcloud-serviceapi-2']
Breakpoint reached, continue? Regexp or Enter=proceed (will clear f4ff235d-6607-4835-9b43-f2be407d8cfe), no=cancel update, C-c=quit interactive mode: overcloud-serviceapi-0
WAITING
completed: [u'overcloud-compute-0', u'overcloud-controller-2', u'overcloud-objectstorage-0', u'overcloud-serviceapi-0']
on_breakpoint: [u'overcloud-controller-0', u'overcloud-controller-1', u'overcloud-cephstorage-0', u'overcloud-serviceapi-2', u'overcloud-serviceapi-1']
Breakpoint reached, continue? Regexp or Enter=proceed (will clear 11bbc3cc-4a6f-4c3a-9ca4-ec363f70cb46), no=cancel update, C-c=quit interactive mode: overcloud-cephstorage-0
WAITING
completed: [u'overcloud-compute-0', u'overcloud-controller-2', u'overcloud-cephstorage-0', u'overcloud-objectstorage-0', u'overcloud-serviceapi-0']
on_breakpoint: [u'overcloud-controller-0', u'overcloud-controller-1', u'overcloud-serviceapi-2', u'overcloud-serviceapi-1']
Breakpoint reached, continue? Regexp or Enter=proceed (will clear 11bbc3cc-4a6f-4c3a-9ca4-ec363f70cb46), no=cancel update, C-c=quit interactive mode: overcloud-serviceapi-1
IN_PROGRESS
WAITING
completed: [u'overcloud-compute-0', u'overcloud-serviceapi-1', u'overcloud-controller-2', u'overcloud-cephstorage-0', u'overcloud-objectstorage-0', u'overcloud-serviceapi-0']
on_breakpoint: [u'overcloud-controller-0', u'overcloud-serviceapi-2', u'overcloud-controller-1']
Breakpoint reached, continue? Regexp or Enter=proceed (will clear dbb1297e-a13f-4a23-95da-4525448

Comment 9 Marios Andreou 2016-11-08 07:03:22 UTC
thanks Sasha closing for now then as per our discussion yesterday and comment #8


Note You need to log in before you can comment on or make changes to this bug.