Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1391879

Summary: No need to show link " Edit resource requests and limits" in metrics warning info on dc page
Product: OpenShift Container Platform Reporter: Yanping Zhang <yanpzhan>
Component: Management ConsoleAssignee: Samuel Padgett <spadgett>
Status: CLOSED CURRENTRELEASE QA Contact: Yadan Pei <yapei>
Severity: low Docs Contact:
Priority: low    
Version: 3.4.0CC: aos-bugs, jforrest, jokerman, mmccomas, tdawson
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-12-12 13:04:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
warninginfo none

Description Yanping Zhang 2016-11-04 10:02:28 UTC
Created attachment 1217344 [details]
warninginfo

Description of problem:
When metrics is not configured on master,  after create hpa for dc not having any container with CPU request set, there will be warning info on dc page: "Metrics might not be configured by your cluster administrator. Metrics are required for autoscaling. Edit resource requests and limits "
The link "Edit resource requests and limits" should not be shown in this warning info.

Version-Release number of selected component (if applicable):
openshift v3.4.0.21+ca4702d

How reproducible:
Always

Steps to Reproduce:
1.Make sure metrics is not configured on master. Create hpa for dc not having any container with CPU request set
2.Check warning info on the dc page.
3.

Actual results:
2. There is link "Edit resource requests and limits" in the warning info: "Metrics might not be configured by your cluster administrator. Metrics are required for autoscaling. Edit resource requests and limits "

Expected results:
2.The link "Edit resource requests and limits" should not show in the metrics warning info.

Additional info:

Comment 1 Samuel Padgett 2016-11-04 17:28:00 UTC
I have no doubt you're seeing this, but I'm not able to reproduce :(  Do you see it every time?

Note that there is code to only show that link for CPU request warnings, so this is definitely a bug.

https://github.com/openshift/origin-web-console/blob/master/app/views/browse/deployment-config.html#L178

Comment 2 Yanping Zhang 2016-11-07 08:28:30 UTC
openshift v3.4.0.22+5c56720
kubernetes v1.4.0+776c994
etcd 3.1.0-rc.0

I could reproduce the bug every time after created hpa on above OCP env too. To reproduce it, Make sure metrics is not configured in master-config.yaml.

Comment 3 Jessica Forrester 2016-11-08 14:41:11 UTC
We think this should be fixed in https://github.com/openshift/origin-web-console/pull/847

Comment 4 Troy Dawson 2016-11-09 19:43:59 UTC
This has been merged into ose and is in OSE v3.4.0.24 or newer.

Comment 6 Yanping Zhang 2016-11-10 05:59:28 UTC
Checked on OCP v3.4.0.24, now that link for CPU request isn't shown in metrics configuration warning info. The bug has been fixed, so move it to Verified.