Bug 1391879 – No need to show link " Edit resource requests and limits" in metrics warning info on dc page

Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.

Bug 1391879 - No need to show link " Edit resource requests and limits" in metrics warning info on dc page

Summary:	No need to show link " Edit resource requests and limits" in metrics warning ...

Status:	CLOSED CURRENTRELEASE

Aliases:	None

Product:	OpenShift Container Platform
Classification:	Red Hat
Component:	Management Console (Show other bugs)
Sub Component:
Version:	3.4.0
Hardware:	Unspecified Unspecified

Priority	low Severity low
Target Milestone:	---
Target Release:	---
Assigned To:	Samuel Padgett
QA Contact:	Yadan Pei
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2016-11-04 06:02 EDT by Yanping Zhang
Modified:	2017-03-08 13 EST (History)
CC List:	5 users (show)

See Also:
Fixed In Version:
Doc Type:	No Doc Update
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2016-12-12 08:04:23 EST
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
warninginfo (80.49 KB, image/png) 2016-11-04 06:02 EDT, Yanping Zhang	no flags	Details
Add an attachment (proposed patch, testcase, etc.)

External Trackers
Tracker	ID	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2017:0066	normal	SHIPPED_LIVE	Red Hat OpenShift Container Platform 3.4 RPM Release Advisory	2017-01-18 12:23:26 EST

Groups: None (edit)

Description Yanping Zhang 2016-11-04 06:02:28 EDT

Created attachment 1217344 [details]
warninginfo

Description of problem:
When metrics is not configured on master,  after create hpa for dc not having any container with CPU request set, there will be warning info on dc page: "Metrics might not be configured by your cluster administrator. Metrics are required for autoscaling. Edit resource requests and limits "
The link "Edit resource requests and limits" should not be shown in this warning info.

Version-Release number of selected component (if applicable):
openshift v3.4.0.21+ca4702d

How reproducible:
Always

Steps to Reproduce:
1.Make sure metrics is not configured on master. Create hpa for dc not having any container with CPU request set
2.Check warning info on the dc page.
3.

Actual results:
2. There is link "Edit resource requests and limits" in the warning info: "Metrics might not be configured by your cluster administrator. Metrics are required for autoscaling. Edit resource requests and limits "

Expected results:
2.The link "Edit resource requests and limits" should not show in the metrics warning info.

Additional info:

Comment 1 Samuel Padgett 2016-11-04 13:28:00 EDT

I have no doubt you're seeing this, but I'm not able to reproduce :(  Do you see it every time?

Note that there is code to only show that link for CPU request warnings, so this is definitely a bug.

https://github.com/openshift/origin-web-console/blob/master/app/views/browse/deployment-config.html#L178

Comment 2 Yanping Zhang 2016-11-07 03:28:30 EST

openshift v3.4.0.22+5c56720
kubernetes v1.4.0+776c994
etcd 3.1.0-rc.0

I could reproduce the bug every time after created hpa on above OCP env too. To reproduce it, Make sure metrics is not configured in master-config.yaml.

Comment 3 Jessica Forrester 2016-11-08 09:41:11 EST

We think this should be fixed in https://github.com/openshift/origin-web-console/pull/847

Comment 4 Troy Dawson 2016-11-09 14:43:59 EST

This has been merged into ose and is in OSE v3.4.0.24 or newer.

Comment 6 Yanping Zhang 2016-11-10 00:59:28 EST

Checked on OCP v3.4.0.24, now that link for CPU request isn't shown in metrics configuration warning info. The bug has been fixed, so move it to Verified.

Note You need to log in before you can comment on or make changes to this bug.