Spec URL: https://jpena.fedorapeople.org/python-vmware-nsxlib/python-vmware-nsxlib.spec SRPM URL: https://jpena.fedorapeople.org/python-vmware-nsxlib/python-vmware-nsxlib-0.2.0-1.el7.centos.src.rpm Description: vmware-nsxlib is a common library that interfaces with VMware NSX Fedora Account System Username: jpena Opening this review against RDO and not Fedora because the library is only used by networking-vmware, which is not part of Fedora [1], and it requires other libraries only packaged in RDO, such as neutron-lib. [1] http://codesearch.openstack.org/?q=vmware_nsxlib&i=nope&files=&repos=
A couple of comments: - Any reason to not use http://tarballs.openstack.org in Source0? - I think we should use autosetup -S git
Thank you for the comments. I have updated the spec: Spec URL: https://jpena.fedorapeople.org/python-vmware-nsxlib/python-vmware-nsxlib.spec SRPM URL: https://jpena.fedorapeople.org/python-vmware-nsxlib/python-vmware-nsxlib-0.2.0-2.el7.centos.src.rpm
Updated version disabling python3 subpackage by default, until we get python3-neutron-lib. Spec URL: https://jpena.fedorapeople.org/python-vmware-nsxlib/python-vmware-nsxlib.spec SRPM URL: https://jpena.fedorapeople.org/python-vmware-nsxlib/python-vmware-nsxlib-0.2.0-3.el7.centos.src.rpm
Unit tests are failing because of missing requirements. We need to add tenacity and neutron-lib as BuildRequires to get tests running (in my tests it worked fine with these two additional packages and its deps). Note that tox installsw both requirements.txt and test-requirements.txt when testing in gate in this project so the most safe option would be to add all Requires as BR also.
Using http://trunk.rdoproject.org/centos7-master/current instead of consistent link works as python-tenacity has been added in the dependencies chain for neutron-lib (which was as BR since the previous version). However, it may be a good idea to add tenacity as a explicit BR.
New version: Spec URL: https://jpena.fedorapeople.org/python-vmware-nsxlib/python-vmware-nsxlib.spec SRPM URL: https://jpena.fedorapeople.org/python-vmware-nsxlib/python-vmware-nsxlib-0.2.0-4.el7.centos.src.rpm
I see everything ok now. Output of fedora-review: This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 10 files have unknown license. Detailed output of licensecheck in /tmp/1392374-python-vmware-nsxlib/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -vmware-nsxlib , python2-vmware-nsxlib-tests , python-vmware-nsxlib- doc [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-vmware-nsxlib-0.2.0-4.el7.centos.noarch.rpm python2-vmware-nsxlib-tests-0.2.0-4.el7.centos.noarch.rpm python-vmware-nsxlib-doc-0.2.0-4.el7.centos.noarch.rpm python-vmware-nsxlib-0.2.0-4.el7.centos.src.rpm python2-vmware-nsxlib-tests.noarch: W: no-documentation python-vmware-nsxlib-doc.noarch: W: summary-not-capitalized C vmware-nsxlib documentation 4 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- python2-vmware-nsxlib-tests.noarch: W: no-documentation python-vmware-nsxlib-doc.noarch: W: summary-not-capitalized C vmware-nsxlib documentation 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- python2-vmware-nsxlib (rpmlib, GLIBC filtered): python(abi) python-eventlet python-netaddr python-neutron-lib python-oslo-i18n python-oslo-log python-oslo-serialization python-oslo-service python-oslo-utils python-pbr python-six python-tenacity python2-vmware-nsxlib-tests (rpmlib, GLIBC filtered): python(abi) python2-vmware-nsxlib python-vmware-nsxlib-doc (rpmlib, GLIBC filtered): Provides -------- python2-vmware-nsxlib: python-vmware-nsxlib python2-vmware-nsxlib python2-vmware-nsxlib-tests: python2-vmware-nsxlib-tests python-vmware-nsxlib-doc: python-vmware-nsxlib-doc Source checksums ---------------- https://tarballs.openstack.org/vmware-nsxlib/vmware-nsxlib-0.2.0.tar.gz : CHECKSUM(SHA256) this package : 902d6b4a920f1012c78e1fd079bd3198323ec046f18bd52ce9a5f0e4a90953be CHECKSUM(SHA256) upstream package : 902d6b4a920f1012c78e1fd079bd3198323ec046f18bd52ce9a5f0e4a90953be Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1392374 -m dlrn-master Buildroot used: dlrn-centos-ocata-x86_64-1 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
I just realized previous fedora-review was incomplete. Right one: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or generated", "*No copyright* Apache (v2.0)". 26 files have unknown license. Detailed output of licensecheck in /tmp/1392374-python- vmware-nsxlib/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -vmware-nsxlib , python2-vmware-nsxlib-tests , python-vmware-nsxlib- doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-vmware-nsxlib-0.2.0-4.el7.centos.noarch.rpm python2-vmware-nsxlib-tests-0.2.0-4.el7.centos.noarch.rpm python-vmware-nsxlib-doc-0.2.0-4.el7.centos.noarch.rpm python-vmware-nsxlib-0.2.0-4.el7.centos.src.rpm python2-vmware-nsxlib-tests.noarch: W: no-documentation python-vmware-nsxlib-doc.noarch: W: summary-not-capitalized C vmware-nsxlib documentation 4 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- python2-vmware-nsxlib-tests.noarch: W: no-documentation python-vmware-nsxlib-doc.noarch: W: summary-not-capitalized C vmware-nsxlib documentation 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- python2-vmware-nsxlib (rpmlib, GLIBC filtered): python(abi) python-eventlet python-netaddr python-neutron-lib python-oslo-i18n python-oslo-log python-oslo-serialization python-oslo-service python-oslo-utils python-pbr python-six python-tenacity python2-vmware-nsxlib-tests (rpmlib, GLIBC filtered): python(abi) python2-vmware-nsxlib python-vmware-nsxlib-doc (rpmlib, GLIBC filtered): Provides -------- python2-vmware-nsxlib: python-vmware-nsxlib python2-vmware-nsxlib python2-vmware-nsxlib-tests: python2-vmware-nsxlib-tests python-vmware-nsxlib-doc: python-vmware-nsxlib-doc Source checksums ---------------- https://tarballs.openstack.org/vmware-nsxlib/vmware-nsxlib-0.2.0.tar.gz : CHECKSUM(SHA256) this package : 902d6b4a920f1012c78e1fd079bd3198323ec046f18bd52ce9a5f0e4a90953be CHECKSUM(SHA256) upstream package : 902d6b4a920f1012c78e1fd079bd3198323ec046f18bd52ce9a5f0e4a90953be Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m dlrn-master -b 1392374 Buildroot used: dlrn-centos-ocata-x86_64-1 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package is built and included in centos-master repo, available in: https://trunk.rdoproject.org/centos7/fd/5c/fd5cf462c66dfa751c6b68c41f38f8cf257eba3f_9593efd4/python-vmware-nsxlib-0.5.0-0.20161222235349.fc115e4.el7.centos.src.rpm