Spec URL: https://pagure.io/rpm-packaging/blob/master/f/SPECS/python-mlpy.spec SRPM URL: https://pagure.io/rpm-packaging/blob/master/f/SRPMS Description: *python-mlpy provides machine learning methods for supervised and unsupervised problems. *I would appreciate a review so that I can get it into Fedora. This is my first package and so I would also appreciate getting sponsored. I'm currently active in the Fedora Project as a CommOps and Marketing contributor. *With this package I'm hoping to be a member of Python SIG and Machine Learning SIG. Fedora Account System Username: dhanesh95 Koji build status: http://koji.fedoraproject.org/koji/taskinfo?taskID=16346771
Koji build status: *For F25 - http://koji.fedoraproject.org/koji/taskinfo?taskID=16351147 *For rawhide - http://koji.fedoraproject.org/koji/taskinfo?taskID=16351456
Please link to the raw file, so that fedora-review works: Spec URL: https://pagure.io/rpm-packaging/raw/master/f/SPECS/python-mlpy.spec SRPM URL: https://pagure.io/rpm-packaging/blob/master/f/SRPMS/python-mlpy-3.5.0-1.fc24.src.rpm
Bumped up spec. Removed unnecessary BRs. Spec URL: https://pagure.io/rpm-packaging/raw/master/f/SPECS/python-mlpy.spec SRPM URL: https://pagure.io/rpm-packaging/blob/master/f/SRPMS/python-mlpy-3.5.0-1.fc24.src.rpm Koji build status: *For F24: http://koji.fedoraproject.org/koji/taskinfo?taskID=16353282 *For F25: http://koji.fedoraproject.org/koji/taskinfo?taskID=16353354 *For rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=16353398
Sorry for the mix up. Linked wrong SRPM. * Updated SRPM URL: https://pagure.io/rpm-packaging/blob/master/f/SRPMS/python-mlpy-3.5.0-2.fc24.src.rpm
Something strange is happening in %prep. Why don't you just use: %autosetup -n %{srcname}-%{version} ? Requires and other dependencies should be listed on-per-line (for diffability and general legibility). %description is way too terse: is it a set of functions or building blocks, or does it provide ready tools, etc. Please extend it so that a person can get a general idea without going on the web. "Machine Learning Python" suggests that this is some variant of python, like pypy.
As suggested, changed the %prep section and all 'Requires' are listed on separate lines. Spec URL: https://pagure.io/rpm-packaging/raw/master/f/SPECS/python-mlpy.spec SRPM URL: https://pagure.io/rpm-packaging/blob/master/f/SRPMS/python-mlpy-3.5.0-3.fc24.src.rpm Koji build status: *For F24: http://koji.fedoraproject.org/koji/taskinfo?taskID=16401397 *For F25: http://koji.fedoraproject.org/koji/taskinfo?taskID=16401490 *For rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=16401570
rpmlint: python3-mlpy.x86_64: W: spelling-error %description -l en_US performace -> performance, perform ace, perform-ace Typo. python3-mlpy.x86_64: E: description-line-too-long C mlpy provides a wide range of state-of-the-art machine learning methods for supe rvised and unsupervised problems. It is a high performace Python library for predictive modeling. %description should be wrapped at ~72 columns. 3 packages and 0 specfiles checked; 2 errors, 2 warnings. fedora-review flags no errors. + package name is OK + builds and installs OK + license is acceptable (GPLv3) + license is specified correctly + latest version (no release since 2012 :( ) + provides/requires look sane + no scriptlets necessary + python macros are used + %python_provide is used I'll approve the package as soon as you are sponsored. Please fix the %description when uploading. -- I can sponsors you into the packagers group. My requirement (apart from this package, which is now satisfied), is two-three reviews of other packages (see http://fedoraproject.org/PackageReviewStatus/NEW.html). Plenty of python packages there, so install mock, fire up fedora-review, and review-away. Please indicate on the review that you're not a packager yet, hence the review is informal. You'll be able to approve those packages after you are in the packagers group, if nobody beats you to it.
Fixed the description. *SPEC URL: https://pagure.io/rpm-packaging/blob/master/f/SPECS/python-mlpy.spec *SRPM URL: https://pagure.io/rpm-packaging/blob/master/f/SRPMS/python-mlpy-3.5.0-4.fc24.src.rpm I may not be able to review other packages for a while now because I'm leaving on vacation for the rest of the month (https://apps.fedoraproject.org/calendar/vacation/#m4937). I'll start reviewing packages as soon as I get back. You may close the ticket and we'll revive it again after I return.
That's fine. Just post the links to the other tickets here once you're back.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #9) > That's fine. Just post the links to the other tickets here once you're back. It's been a long time coming. Here's a couple of reviews I did. Planning to do more of them. This is teaching me a lot. 1. https://bugzilla.redhat.com/show_bug.cgi?id=1402164#c2 2. https://bugzilla.redhat.com/show_bug.cgi?id=1431426#c1 3. https://bugzilla.redhat.com/show_bug.cgi?id=1409802#c1
Please always provide link to the raw files (spec and srpm). Fedora-review and wget and other tools are confused otherwise. python3-mlpy.x86_64: W: spelling-error %description -l en_US menthods -> methods, menthol The comments from comment #c7 still stand. Package is APPROVED. -- I've added you to the packagers group. Please keep up the good work. In particular please take 1409802. If you have any questions or get stuck with anything, drop me a note (zbyszek, zbyszek in #fedora-devel).
(In reply to Zbigniew Jędrzejewski-Szmek from comment #11) > Please always provide link to the raw files (spec and srpm). Fedora-review > and wget and other tools are confused otherwise. > > python3-mlpy.x86_64: W: spelling-error %description -l en_US menthods -> > methods, menthol > > The comments from comment #c7 still stand. Package is APPROVED. > Thank you so much. I'm sure this will be the final edit. (I like to keep things updated :P) *SPEC URL: https://pagure.io/rpm-packaging/raw/master/f/SPECS/python-mlpy.spec *SRPM URL: https://pagure.io/rpm-packaging/raw/master/f/SRPMS/python-mlpy-3.5.0-5.fc24.src.rpm > > I've added you to the packagers group. Please keep up the good work. In > particular please take 1409802. If you have any questions or get stuck with > anything, drop me a note (zbyszek, zbyszek in #fedora-devel). Thank you so much! I'll take 1409802. Glad to help!
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-mlpy
python-mlpy-3.5.0-6.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-f4f159153d
python-mlpy-3.5.0-6.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c77a5b46b9
python-mlpy-3.5.0-6.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-c77a5b46b9
python-mlpy-3.5.0-6.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-f4f159153d
python-mlpy-3.5.0-6.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
python-mlpy-3.5.0-6.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.